Re: [PATCH v9] tests/intel/xe_exec_capture: Add xe_exec_capture test

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

On Fri, 2024-12-06 at 14:59 -0800, Dong, Zhanjun wrote:
> Submit cmds to the GPU that result in a GuC engine reset and check that
> devcoredump register dump is generated, by the GuC, and includes the
> full register range.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> 
alan:snip

> +igt_main
> +{
> +       int xe;
> +
> +       igt_fixture
> +               xe = drm_open_driver(DRIVER_XE);
> +
> +       igt_subtest("reset") {
> +               int gpu_count = drm_prepare_filtered_multigpu(DRIVER_XE);
> +
> +               igt_require(xe > 0);
> +               if (gpu_count >= 2) {
alan: Zhanjun, i got some offline feedback from Kamil that we should break
up separate subtests for single gpu vs multi-gpu scenarios. That said,
he was okay with doing single GPU first and doing multi-gpu later as an
addition patch if we really need to get this test integrated sooner.
Let's follow up on what works for you (i believe breaking up
subtests for single-default-gpu vs multi-gpu is actually more straight
forward).
> +                       igt_info("Running test on multiple GPU\n");
> +
> +                       igt_multi_fork(child, gpu_count) {
> +                               int gpu_fd;
> +
> +                               gpu_fd = drm_open_filtered_card(child);
> +                               igt_assert_f(gpu_fd > 0, "cannot open gpu-%d, errno=%d\n", child,
> +                                            errno);
> +                               igt_assert(is_xe_device(gpu_fd));
> +
> +                               test_card(gpu_fd);
> +                               drm_close_driver(gpu_fd);
> +                       }
> +                       igt_waitchildren();
> +               } else {
> +                       igt_info("Running test on single GPU\n");
> +                       test_card(xe);
> +               }
> +       }

alan:snip