Re: [PATCH 3/3] tests/intel/xe_exec_reset: Add multi-queue long spin tests

[Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>]

On Thu, May 07, 2026 at 12:37:23PM -0700, Summers, Stuart wrote:
>On Wed, 2026-05-06 at 11:31 -0700, Niranjana Vishwanathapura wrote:
>> From: gta <gta@DUT4637NVLP.fm.intel.com>
>>
>> Add the following multi-queue tests and update xe_legacy_test_mode()
>> function to use queue_timestamp and multi_queue_switch spinner
>> options
>> for the multi-queue scenarios.
>>
>> multi-queue-long-spin-many-preempt
>> multi-queue-long-spin-reuse-many-preempt
>>
>> Signed-off-by: Niranjana Vishwanathapura
>> <niranjana.vishwanathapura@intel.com>
>> ---
>>  lib/xe/xe_legacy.c          |  2 ++
>>  tests/intel/xe_exec_reset.c | 17 +++++++++++++++++
>>  2 files changed, 19 insertions(+)
>>
>> diff --git a/lib/xe/xe_legacy.c b/lib/xe/xe_legacy.c
>> index f9bd5bcb61..b7054756cd 100644
>> --- a/lib/xe/xe_legacy.c
>> +++ b/lib/xe/xe_legacy.c
>> @@ -67,6 +67,8 @@ xe_legacy_test_mode(int fd, struct
>> drm_xe_engine_class_instance *eci,
>>         } *data;
>>         struct xe_spin_opts spin_opts = {
>>                 .preempt = flags & PREEMPT,
>> +               .multi_queue_switch = flags & MULTI_QUEUE,
>> +               .use_queue_timestamp = flags & MULTI_QUEUE,
>>  #define THREE_SEC      (3 * 1000000000ull)
>>                 .ctx_ticks = flags & LONG_SPIN ?
>>                         xe_spin_nsec_to_ticks(fd, 0, THREE_SEC) : 0,
>> diff --git a/tests/intel/xe_exec_reset.c
>> b/tests/intel/xe_exec_reset.c
>> index a3cf290abf..f7ae94a424 100644
>> --- a/tests/intel/xe_exec_reset.c
>> +++ b/tests/intel/xe_exec_reset.c
>> @@ -1179,6 +1179,23 @@ int igt_main()
>>                                           MULTI_QUEUE);
>>         }
>>  
>> +       igt_subtest("multi-queue-long-spin-many-preempt")
>
>These need to be documented now. The existing non-multi queue tests
>talk about preemption being the deciding factor in ensuring we aren't
>getting engine resets. So here would be nice to call out lite restore
>explicitly.
>
>Other than documentation the changes look good.
>

Sure, will add.

Niranjana

>Thanks,
>Stuart
>
>> +               xe_for_each_multi_queue_engine(fd, hwe) {
>> +                       xe_legacy_test_mode(fd, hwe, 4, 8,
>> +                                           LONG_SPIN | MULTI_QUEUE,
>> +                                           LEGACY_MODE_ADDR, false);
>> +                       break;
>> +               }
>> +
>> +       igt_subtest("multi-queue-long-spin-reuse-many-preempt")
>> +               xe_for_each_multi_queue_engine(fd, hwe) {
>> +                       xe_legacy_test_mode(fd, hwe, 4, 8,
>> +                                           LONG_SPIN | MULTI_QUEUE |
>> +                                           LONG_SPIN_REUSE_QUEUE,
>> +                                           LEGACY_MODE_ADDR, false);
>> +                       break;
>> +               }
>> +
>>         igt_fixture()
>>                 drm_close_driver(fd);
>>  }
>