From: Liviu Dudau <liviu.dudau@arm.com>
To: Deborah Brouwer <deborah.brouwer@collabora.com>
Cc: igt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
boris.brezillon@collabora.com, steven.price@arm.com,
adrian.larumbe@collabora.com, kamil.konieczny@linux.intel.com,
samitolvanen@google.com
Subject: Re: [PATCH i-g-t v3] tests/panthor: skip sparse VM_BIND tests before v1.9
Date: Tue, 22 Sep 2026 09:29:26 +0100 [thread overview]
Message-ID: <arI8ZszbxqnMetN8@e142607> (raw)
In-Reply-To: <20260921-b4-panthor_version_sparse-v3-1-c0af288ca073@collabora.com>
On Mon, Sep 21, 2026 at 08:05:37PM -0700, Deborah Brouwer wrote:
> Sparse VM_BIND support was introduced with Panthor DRM driver version
> 1.9. If a driver isn't advertising support for v1.9, skip the sparse
> VM_BIND subtests.
>
> Use the advertised driver version rather than probing for EINVAL, since
> EINVAL may also indicate a uAPI regression rather than lack of support for
> sparse VM_BIND.
>
> Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> ---
> Changes in v3:
> - change macro to function
> - move the helper functions to tests/panthor
> - add documentation for functions
> - Link to v2: https://lore.kernel.org/r/20260920-b4-panthor_version_sparse-v2-1-fa395c125eb1@collabora.com
>
> Changes in v2:
> - check for version at each subtest
> - make version check available to all panthor tests
> - use macro to suppress printing the last error
> - Link to v1: https://lore.kernel.org/r/20260915-b4-panthor_version_sparse-v1-1-7ac10b75e631@collabora.com
> ---
> tests/panthor/panthor_vm.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
> diff --git a/tests/panthor/panthor_vm.c b/tests/panthor/panthor_vm.c
> index 9011df25e..08a4b7f05 100644
> --- a/tests/panthor/panthor_vm.c
> +++ b/tests/panthor/panthor_vm.c
> @@ -7,6 +7,47 @@
> #include "igt_sizes.h"
> #include "panthor_drm.h"
>
> +/**
> + * panthor_driver_version_at_least:
> + * @fd: panthor device file descriptor
> + * @major: required Panthor major version
> + * @minor: required Panthor minor version
> + *
> + * Returns true if the Panthor version is at least the requested version.
> + */
> +static bool
> +panthor_driver_version_at_least(int fd, int major, int minor)
> +{
> + drmVersionPtr version = drmGetVersion(fd);
> + bool supported;
> +
> + igt_assert(version);
> + supported = version->version_major > major ||
> + (version->version_major == major &&
> + version->version_minor >= minor);
> + drmFreeVersion(version);
> +
> + return supported;
> +}
> +
> +/**
> + * require_panthor_version:
> + * @fd: device file descriptor
> + * @major: required Panthor major version
> + * @minor: required Panthor minor version
> + *
> + * Require the Panthor version to be at least the requested version.
> + */
> +static void
> +require_panthor_version(int fd, int major, int minor)
> +{
> + if (!panthor_driver_version_at_least(fd, major, minor)) {
> + /* Clear irrelevant errno to avoid printing it in the skip log. */
> + errno = 0;
> + igt_skip("Panthor version %d.%d or newer required\n", major, minor);
> + }
> +}
> +
> int igt_main() {
> int fd = -1;
>
> @@ -293,6 +334,7 @@ int igt_main() {
> uint32_t vm_id;
> uint64_t map_size = SZ_4K * 4;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -306,6 +348,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -321,6 +364,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -336,6 +380,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -351,6 +396,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -366,6 +412,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -382,6 +429,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -402,6 +450,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -422,6 +471,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -442,6 +492,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -463,6 +514,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -483,6 +535,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -503,6 +556,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -524,6 +578,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -545,6 +600,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -566,6 +622,7 @@ int igt_main() {
> uint64_t map_size = SZ_2M * 3;
> const int INITIAL_VA = SZ_4M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -585,6 +642,7 @@ int igt_main() {
> uint64_t map_size = ALIGN_DOWN(UINT64_MAX, SZ_2M) - (SZ_2M * 3);
> const int INITIAL_VA = SZ_512M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
> @@ -599,6 +657,7 @@ int igt_main() {
> uint64_t unmap_size = ALIGN_DOWN(UINT64_MAX, SZ_2M) - map_size;
> const int INITIAL_VA = SZ_512M;
>
> + require_panthor_version(fd, 1, 9);
> igt_panthor_vm_create(fd, &vm_id, 0);
> igt_assert(vm_id != 0);
>
>
> ---
> base-commit: 520aba273f391e31e18b6fe98d71201eb505a683
> change-id: 20260915-b4-panthor_version_sparse-5fbd31cc0d5d
>
> Best regards,
> --
> Deborah Brouwer <deborah.brouwer@collabora.com>
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2026-09-22 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 3:05 [PATCH i-g-t v3] tests/panthor: skip sparse VM_BIND tests before v1.9 Deborah Brouwer
2026-09-22 3:42 ` ✗ Xe.CI.BAT: failure for tests/panthor: skip sparse VM_BIND tests before v1.9 (rev2) Patchwork
2026-09-22 15:56 ` Kamil Konieczny
2026-09-22 4:04 ` ✓ i915.CI.BAT: success " Patchwork
2026-09-22 8:29 ` Liviu Dudau [this message]
2026-09-22 12:20 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-22 15:57 ` Kamil Konieczny
2026-09-22 12:33 ` ✗ i915.CI.Full: " Patchwork
2026-09-22 15:58 ` Kamil Konieczny
2026-09-22 15:54 ` [PATCH i-g-t v3] tests/panthor: skip sparse VM_BIND tests before v1.9 Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arI8ZszbxqnMetN8@e142607 \
--to=liviu.dudau@arm.com \
--cc=adrian.larumbe@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=samitolvanen@google.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox