From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20180928102002.10541-1-chris@chris-wilson.co.uk> <153842301482.23109.9425007086680751049@skylake-alporthouse-com> From: Antonio Argenziano Message-ID: Date: Mon, 1 Oct 2018 12:53:46 -0700 MIME-Version: 1.0 In-Reply-To: <153842301482.23109.9425007086680751049@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: CgpPbiAwMS8xMC8xOCAxMjo0MywgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IFF1b3RpbmcgQW50b25p byBBcmdlbnppYW5vICgyMDE4LTEwLTAxIDE5OjM2OjI0KQo+Pgo+Pgo+PiBPbiAyOC8wOS8xOCAw MzoxOSwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4gSWYgdGhlIGRyaXZlciBkb2Vzbid0IHN1cHBv cnQgdGhlIGdldGZiIGlmYWNlIChlLmcuIGJlY2F1c2UgS01TIGhhcyBiZWVuCj4+PiBkaXNhYmxl ZCksIHRoZSBpb2N0bHMgd2lsbCBmYWlsIHdpdGggRU5PVFNVUC4gVGhpcyBpcyBleHBlY3RlZCwg c28gc2tpcAo+Pj4gdGhlIHRlc3QgYXMgbm90aGluZyB1c2VmdWwgY2FuIGJlIGxlYXJudC4KPj4+ Cj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPj4+IC0tLQo+Pj4gICAgdGVzdHMva21zX2dldGZiLmMgfCA0MCArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tCj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMzggaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvdGVzdHMva21zX2dl dGZiLmMgYi90ZXN0cy9rbXNfZ2V0ZmIuYwo+Pj4gaW5kZXggODFkNzk2YTQyLi43MWQ2NTQ4OGYg MTAwNjQ0Cj4+PiAtLS0gYS90ZXN0cy9rbXNfZ2V0ZmIuYwo+Pj4gKysrIGIvdGVzdHMva21zX2dl dGZiLmMKPj4+IEBAIC00MCw2ICs0MCw0MCBAQAo+Pj4gICAgI2luY2x1ZGUgImRybS5oIgo+Pj4g ICAgI2luY2x1ZGUgImRybV9mb3VyY2MuaCIKPj4+ICAgIAo+Pj4gK3N0YXRpYyBib29sIGhhc19n ZXRmYl9pZmFjZShpbnQgZmQpCj4+PiArewo+Pj4gKyAgICAgc3RydWN0IGRybV9tb2RlX2ZiX2Nt ZCBhcmcgPSB7IH07Cj4+PiArICAgICBpbnQgZXJyOwo+Pj4gKwo+Pj4gKyAgICAgZXJyID0gMDsK Pj4+ICsgICAgIGlmIChkcm1Jb2N0bChmZCwgRFJNX0lPQ1RMX01PREVfR0VURkIsICZhcmcpKQo+ Pj4gKyAgICAgICAgICAgICBlcnIgPSAtZXJybm87Cj4+PiArICAgICBzd2l0Y2ggKGVycikgewo+ Pj4gKyAgICAgY2FzZSAtRU5PVFRZOiAvKiBpb2N0bCB1bnJlY29nbmlzZWQgKGtlcm5lbCB0b28g b2xkKSAqLwo+Pj4gKyAgICAgY2FzZSAtRU5PVFNVUDogLyogZHJpdmVyIGRvZXNuJ3Qgc3VwcG9y dCBLTVMgKi8KPj4+ICsgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+Pj4gKyAgICAgZGVmYXVs dDoKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+PiArICAgICB9Cj4+PiArfQo+Pj4g Kwo+Pj4gK3N0YXRpYyBib29sIGhhc19hZGRmYjJfaWZhY2UoaW50IGZkKQo+Pj4gK3sKPj4+ICsg ICAgIHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyIGFyZyA9IHsgfTsKPj4+ICsgICAgIGludCBlcnI7 Cj4+PiArCj4+PiArICAgICBlcnIgPSAwOwo+Pj4gKyAgICAgaWYgKGRybUlvY3RsKGZkLCBEUk1f SU9DVExfTU9ERV9BRERGQjIsICZhcmcpID09IDApCj4+PiArICAgICAgICAgICAgIGVyciA9IC1l cnJubzsKPj4KPj4gU2hvdWxkbid0IHRoaXNeIGJlICE9IDA/Cj4gCj4gWXVwLgo+ICAgCj4+PiAr ICAgICBzd2l0Y2ggKGVycikgewo+Pj4gKyAgICAgY2FzZSAtRU5PVFRZOiAvKiBpb2N0bCB1bnJl Y29nbmlzZWQgKGtlcm5lbCB0b28gb2xkKSAqLwo+Pj4gKyAgICAgY2FzZSAtRU5PVFNVUDogLyog ZHJpdmVyIGRvZXNuJ3Qgc3VwcG9ydCBLTVMgKi8KPj4+ICsgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwo+Pj4gKyAgICAgZGVmYXVsdDoKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+ Cj4+IFNob3VsZG4ndCB3ZSBmYWlsIG9uIGV2ZXJ5IGVycm5vPwo+IAo+IE5vLiBXZSB3YW50IHRv IGJlIHZlcnkgY2FyZWZ1bCBpbiBvbmx5IGZhaWwgYXQgdGhpcyBwb2ludCBmb3IgZXJybm8gd2UK PiBrbm93IGltcGx5IHRoZSBpbnRlcmZhY2UgaXMgbm90IHN1cHBvcnRlZCBzbyB0aGF0IHdlIGRv IG5vdCBjb25mdXNlIGFuCj4gaWxsZWdhbCBhZGRmYjIgcmVxdWVzdCBhbmQgZmFpbCBsYXRlciBp biB0aGUgYWN0dWFsIHRlc3QuCgpGYWlyIGVub3VnaC4KCkFja2VkLWJ5OiBBbnRvbmlvIEFyZ2Vu emlhbm8gPGFudG9uaW8uYXJnZW56aWFub0BpbnRlbC5jb20+Cgpmb3IgdGhlIHNlcmllcy4KCj4g LUNocmlzCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=