Re: [igt-dev] [PATCH i-g-t v3 0/8] Add vmwgfx support

[Zack Rusin <zackr@vmware.com>]

On Wed, 2023-04-12 at 18:32 +0200, Kamil Konieczny wrote:
> !! External Email
> 
> Hi Zack,
> 
> On 2023-04-11 at 22:33:21 -0400, Zack Rusin wrote:
> > From: Zack Rusin <zackr@vmware.com>
> > 
> > v2: Split up tests into individual changes and fix various reported
> > warnings
> > v3: Rename vmw tests and commits, regenerate headers and fix the order
> > of driver names in drmtest
> > 
> > Introduce explicit support for vmwgfx. The general support is largely
> > self contained, the only additionl change is to increase number of
> > available crtcs which is needed by vmwgfx but doesn't affect other
> > drivers.
> > 
> > Besides the core support add a number of vmwgfx specific tests which
> > use and test various vmwgfx specific ioctl's.
> > 
> > Maaz Mombasawala (7):
> >   lib/svga: Add generated headers for the svga device
> >   lib: Add vmwgfx support
> >   tests/vmwgfx: Add triangle test
> >   tests/vmwgfx: Add execution buffer test
> >   tests/vmwgfx: Add surface copy test
> >   tests/vmwgfx: Add mob stress test
> >   tests/vmwgfx: Add reference counting tests
> 
> This looks almost ok, in file from first patch:
> lib/svga/svga3d_surfacedefs.h
> 
> SPDX should be placed on first line.

That one is currently verbatim from the kernel. This is on our immediate todo (both
for kernel and igt) because that part of our autogenerated files is broken. I can
hand edit it if it's important for igt though.

> btw checkpatch.pl has many warnings and found two misspelled
> words in
> lib/svga/vm_basic_types.h
> 
> Is this file also part of ones copied from linux driver ?
> While all that ints and other stuff looks basic, that MKS...
> looks like some performance counting data structure (so it
> don't looks like "basic").

basic in the sense that a lot of other code relies on it. This is a glue which has
to be changed for igt anyway due to userspace/kernel difference so I'll edit that
and respin the series.

z