Re: [PATCH i-g-t v2] tests/intel/kms_joiner: Fix mixed_output subtest skips

[Karthik B S <karthik.b.s@intel.com>]

On 7/8/2026 1:28 PM, Santhosh Reddy Guddati wrote:
> In the mixed output case, mixed_output[1] is a non-big-joiner output,
> but bigjoiner_mode_found() was unconditionally called for both outputs,
> causing the subtest to skip. Only require a big joiner mode for the
> first output (j=0); the second uses its default mode.
>
> V2: Split compound statements by replacing with variables (Karthik)
>
> cc: Karthik B.S <karthik.b.s@intel.com>
> cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/intel/kms_joiner.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_joiner.c b/tests/intel/kms_joiner.c
> index d26eb3b01..dfcb24004 100644
> --- a/tests/intel/kms_joiner.c
> +++ b/tests/intel/kms_joiner.c
> @@ -382,10 +382,17 @@ static void test_invalid_modeset_two_joiner(data_t *data,
>   		for (j = 0; j < INVALID_TEST_OUTPUT; j++) {
>   			igt_crtc_t *crtc;
>   			enum pipe pipe = data->pipe_seq[i + j];
> +			/*
> +			 * In the mixed case only the first output (j == 0) is a
> +			 * big joiner output; the second is a non-big-joiner output.
> +			 * In all other cases every output is a big joiner output.
> +			 */
> +			bool is_big_joiner_output = !mixed || j == 0;
> +			bool needs_big_joiner_mode = !force_joiner && is_big_joiner_output;
>   
>   			output = outputs[j];
>   
> -			if (!force_joiner) {
> +			if (needs_big_joiner_mode) {
>   				igt_require_f(bigjoiner_mode_found(data->drm_fd, output->config.connector, max_dotclock, &mode),
>   							  "No big joiner mode found on output %s\n", output->name);
>   				igt_output_override_mode(output, &mode);