Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_plane_cursor: limit simulation to first and last CRTC
Date: Mon, 16 Nov 2026 11:35:32 +0200	[thread overview]
Message-ID: <b1165a2bd1484d569c1422c94cf1cc9da2a51b7a@intel.com> (raw)
In-Reply-To: <20261116040120.3197381-1-jeevan.b@intel.com>

On Mon, 16 Nov 2026, Jeevan B <jeevan.b@intel.com> wrote:
> Running on every CRTC makes the test hit the timeout on simulation.
> Restrict it to the first and last usable CRTC when running in
> simulation, which keeps coverage while avoiding the timeout.
>
> v2:
>  - Test the first and last usable CRTC instead of the first 2 pipes, and
>    drop SIM_MAX_PIPES.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/kms_plane_cursor.c | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 4b69f1a17..982505575 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -327,8 +327,37 @@ int igt_main()
>  	for (i = 0; i < ARRAY_SIZE(tests); i++) {
>  		igt_describe_f("%s", tests[i].desc);
>  		igt_subtest_with_dynamic_f("%s", tests[i].name) {
> +			igt_crtc_t *first_crtc = NULL, *last_crtc = NULL;
> +
> +			/*
> +			 * In simulation, only test the first and last usable
> +			 * CRTC to avoid timeouts while keeping coverage.
> +			 */
> +			if (igt_run_in_simulation()) {
> +				for_each_crtc_with_single_output(&data.display,
> +								 crtc, output) {
> +					if ((tests[i].flags & TEST_OVERLAY) &&
> +					    !igt_crtc_get_plane_type(crtc,
> +								     DRM_PLANE_TYPE_OVERLAY))
> +						continue;
> +
> +					igt_display_reset(display);
> +					igt_output_set_crtc(output, crtc);
> +					if (!intel_pipe_output_combo_valid(display))
> +						continue;
> +
> +					if (!first_crtc)
> +						first_crtc = crtc;
> +					last_crtc = crtc;
> +				}
> +			}

Why are you duplicating the for_each_crtc_with_single_output() loop?
Aren't you also *adding* more modesets for simulation here?!

BR,
Jani.


> +
>  			for_each_crtc_with_single_output(&data.display, crtc,
>  							 output) {
> +				if (igt_run_in_simulation() &&
> +				    crtc != first_crtc && crtc != last_crtc)
> +					continue;
> +
>  				if ((tests[i].flags & TEST_OVERLAY) &&
>  				    !igt_crtc_get_plane_type(crtc,
>  							     DRM_PLANE_TYPE_OVERLAY))

-- 
Jani Nikula, Intel

      parent reply	other threads:[~2026-11-16  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  4:01 [PATCH i-g-t] tests/kms_plane_cursor: limit simulation to first and last CRTC Jeevan B
2026-11-16  5:04 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-11-16  5:20 ` ✓ i915.CI.BAT: " Patchwork
2026-11-16  7:03 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-11-16  7:49 ` ✗ i915.CI.Full: " Patchwork
2026-11-16  9:35 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1165a2bd1484d569c1422c94cf1cc9da2a51b7a@intel.com \
    --to=jani.nikula@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox