Re: [PATCH i-g-t v1 1/2] tests/kms_plane_scaling: Skip unsupported scaling scenarios

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

Hi Jeevan,

Thanks for the review.

On 3/11/2026 3:30 PM, B, Jeevan wrote:
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Naladala
>> Ramanaidu
>> Sent: Wednesday, March 11, 2026 1:10 PM
>> To: igt-dev@lists.freedesktop.org
>> Cc: Sharma, Swati2 <swati2.sharma@intel.com>; Naladala, Ramanaidu
>> <ramanaidu.naladala@intel.com>
>> Subject: [PATCH i-g-t v1 1/2] tests/kms_plane_scaling: Skip unsupported scaling
>> scenarios
>>
>> Skip unsupported downscale tests on Intel platforms, aligning test coverage with
>> hardware limitations and reducing CI noise.
>>
>> Bspec: 50441
>>
>> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
>> ---
>>   tests/kms_plane_scaling.c | 38 ++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 38 insertions(+)
>>
>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c index
>> ab619fb2b..60390fae8 100644
>> --- a/tests/kms_plane_scaling.c
>> +++ b/tests/kms_plane_scaling.c
>> @@ -533,6 +533,24 @@ const struct {
>>   	},
>>   };
>>
>> +static bool is_intel_downscale_supported(data_t *data, const char * const
>> name,
>> +					 const enum scaler_combo_test_type
>> test_type) {
>> +	if ((intel_display_ver(data->devid) >= 14) &&
>> +	    (test_type == TEST_PLANES_DOWNSCALE))
>> +		return false;
>> +
>> +	if ((intel_display_ver(data->devid) >= 14) &&
>> +	    (test_type == TEST_PLANES_UPSCALE_DOWNSCALE) &&
>> +	    strstr(name, "planes-upscale"))
>> +		return false;
>> +
>> +	if (strstr(name, "downscale-factor-0-25"))
>> +		return false;
>> +
>> +	return true;
>> +}
>> +
>>   static int get_width(drmModeModeInfo *mode, double scaling_factor)  {
>>   	if (scaling_factor == 0.0)
>> @@ -1373,6 +1391,11 @@ int igt_main_args("", long_opts, help_str,
>> opt_handler, &data)
>>   		for (int index = 0; index <
>> ARRAY_SIZE(scaler_with_pixel_format_tests); index++) {
>>
>> 	igt_describe(scaler_with_pixel_format_tests[index].describe);
>>
>> 	igt_subtest_with_dynamic(scaler_with_pixel_format_tests[index].name)
>> {
>> +				if (is_intel_device(data.drm_fd) &&
>> +				    !is_intel_downscale_supported(&data,
>> +
>> 	scaler_with_pixel_format_tests[index].name,
>> +							0))
>> +					continue;
>>   				for_each_crtc(&data.display, crtc) {
>>   					igt_dynamic_f("pipe-%s",
>> igt_crtc_name(crtc)) {
>>
>> 	for_each_valid_output_on_crtc(&data.display,
>> @@ -1404,6 +1427,11 @@ int igt_main_args("", long_opts, help_str,
>> opt_handler, &data)
>>   		for (int index = 0; index <
>> ARRAY_SIZE(scaler_with_rotation_tests); index++) {
>>
>> 	igt_describe(scaler_with_rotation_tests[index].describe);
>>
> I think we should avoid using continue here and instead use igt_skip_on() or igt_require().
> Since this is inside a dynamic subtest, the block should not be entered if the feature is not supported.
> We should skip the test and proceed with the next case without listing an unsupported test.
>
> Thanks
> Jeevan B
Agree. I will fix and float next rev.
>> 	igt_subtest_with_dynamic(scaler_with_rotation_tests[index].name) {
>> +				if (is_intel_device(data.drm_fd) &&
>> +				    !is_intel_downscale_supported(&data,
>> +
>> 	scaler_with_rotation_tests[index].name,
>> +							0))
>> +					continue;
>>   				for_each_crtc(&data.display, crtc) {
>>   					igt_dynamic_f("pipe-%s",
>> igt_crtc_name(crtc)) {
>>
>> 	for_each_valid_output_on_crtc(&data.display,
>> @@ -1435,6 +1463,11 @@ int igt_main_args("", long_opts, help_str,
>> opt_handler, &data)
>>   		for (int index = 0; index <
>> ARRAY_SIZE(scaler_with_modifiers_tests); index++) {
>>
>> 	igt_describe(scaler_with_modifiers_tests[index].describe);
>>
>> 	igt_subtest_with_dynamic(scaler_with_modifiers_tests[index].name) {
>> +				if (is_intel_device(data.drm_fd) &&
>> +				    !is_intel_downscale_supported(&data,
>> +
>> 	scaler_with_modifiers_tests[index].name,
>> +							0))
>> +					continue;
>>   				for_each_crtc(&data.display, crtc) {
>>   					igt_dynamic_f("pipe-%s",
>> igt_crtc_name(crtc)) {
>>
>> 	for_each_valid_output_on_crtc(&data.display,
>> @@ -1548,6 +1581,11 @@ int igt_main_args("", long_opts, help_str,
>> opt_handler, &data)
>>   		for (int index = 0; index <
>> ARRAY_SIZE(scaler_with_2_planes_tests); index++) {
>>
>> 	igt_describe(scaler_with_2_planes_tests[index].describe);
>>
>> 	igt_subtest_with_dynamic(scaler_with_2_planes_tests[index].name) {
>> +				if (is_intel_device(data.drm_fd) &&
>> +				    !is_intel_downscale_supported(&data,
>> +
>> 	scaler_with_2_planes_tests[index].name,
>> +
>> 	scaler_with_2_planes_tests[index].test_type))
>> +					continue;
>>   				for_each_crtc(&data.display, crtc) {
>>   					igt_dynamic_f("pipe-%s",
>> igt_crtc_name(crtc)) {
>>
>> 	for_each_valid_output_on_crtc(&data.display,
>> --
>> 2.43.0