From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>,
igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] lib/igt_pm: Restore runtime pm state on test exit
Date: Wed, 28 Feb 2018 11:38:01 +0000 [thread overview]
Message-ID: <b21d4eb9-4fd3-cd41-d73f-437b930c7e0d@linux.intel.com> (raw)
In-Reply-To: <151981633284.21577.15318265579483089548@mail.alporthouse.com>
On 28/02/2018 11:12, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-02-28 11:08:29)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Some tests (the ones which call igt_setup_runtime_pm and
>> igt_pm_enable_audio_runtime_pm) change default system configuration and
>> never restore it.
>>
>> The configured runtime suspend is aggressive and may influence behaviour
>> of subsequent tests, so it is better to restore to previous values on test
>> exit.
>>
>> This way system behaviour, with regards to a random sequence of executed
>> tests, will be more consistent from one run to another.
>
> Otoh, if behaviour changes in subsequent tests, we likely have a lack of
> testing :(
Yeah, and I am not saying it does - haven't spotted anything like that,
just that it leaves the auto-suspend with zero delay afterwards,
compared to otherwise default 10s.
Maybe it is good for coverage, even with the downside of randomness
considering shard runs, or maybe it needs to be more explicit.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-28 11:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 11:08 [igt-dev] [PATCH i-g-t] lib/igt_pm: Restore runtime pm state on test exit Tvrtko Ursulin
2018-02-28 11:12 ` [igt-dev] [Intel-gfx] " Chris Wilson
2018-02-28 11:38 ` Tvrtko Ursulin [this message]
2018-02-28 12:27 ` Chris Wilson
2018-02-28 14:33 ` Tvrtko Ursulin
2018-02-28 12:50 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-02-28 15:17 ` Tvrtko Ursulin
2018-02-28 14:23 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2018-02-28 15:35 ` [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
2018-03-01 8:12 ` [igt-dev] " Chris Wilson
2018-03-02 9:29 ` [igt-dev] " Imre Deak
2018-03-02 9:51 ` [Intel-gfx] [PATCH i-g-t v3] " Tvrtko Ursulin
2018-03-02 9:56 ` [igt-dev] [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
2018-03-02 12:29 ` Imre Deak
2018-02-28 16:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_pm: Restore runtime pm state on test exit (rev2) Patchwork
2018-02-28 20:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-03-02 18:21 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_pm: Restore runtime pm state on test exit (rev3) Patchwork
2018-03-05 9:04 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-03-05 10:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b21d4eb9-4fd3-cd41-d73f-437b930c7e0d@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox