From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DBD0D4335D for ; Thu, 7 Nov 2024 13:28:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F338010E84B; Thu, 7 Nov 2024 13:28:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="X3Elrhp8"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 389E210E846 for ; Thu, 7 Nov 2024 13:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730986082; x=1762522082; h=message-id:date:subject:to:references:from:in-reply-to: mime-version; bh=F/4MteHWYbSWPUPBvCMOiScps8JlqyAy0xP8UQQi3+A=; b=X3Elrhp8L2QBrOJESS+HgnerHuruD5XoBb6CDeuqPFN6QKiGsJgGqyp+ PkXOCAnK84zzO2Frv7RAiOrtOAc/rkC/eCdieQHNeHdnCZtEH5ITXtTvQ 9jnKyu29uvzpzwXMqHmbP0PfbnecdAoTf/7LDqoO9i/fmo25OrczAlv/i i1IK5q48iQh6pFaZMPiTdv0ClHuJj07R5ueKLa1lYLKj/i05XqBplu3aA BXznT8uyS5japuRl/uTnaYKKqdiazazieCIjkeho/J9eUplQTPRGV9mTt pnzywZ/rpHC915X35TvOjUq8C9m5G16GT/W11ReBTpaTc+L/D7NmofR4f A==; X-CSE-ConnectionGUID: NdecD9lgSZ2nz7AEY4L6bw== X-CSE-MsgGUID: lzmkwbj/TOqGljPuyJ7bmQ== X-IronPort-AV: E=McAfee;i="6700,10204,11249"; a="30231545" X-IronPort-AV: E=Sophos;i="6.12,266,1728975600"; d="scan'208,217";a="30231545" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2024 05:28:02 -0800 X-CSE-ConnectionGUID: KzzuJIu9SI2anC1lThi86w== X-CSE-MsgGUID: UcnVkpOBSViQ24Gp/PIvTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,266,1728975600"; d="scan'208,217";a="122595914" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Nov 2024 05:28:02 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 7 Nov 2024 05:28:01 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 7 Nov 2024 05:28:01 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 7 Nov 2024 05:28:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mfD6cW7ytOGAP+uL0EdPMkOSxPg2VQnclmIXnknOspm1Yo9Fi5bZC86zvK2U3J8oXtyVt6j7gShua5jV0SI0DB+XtOUo11i898FxN19pvn1gjAZaaMuS4KjXKH/2NFpNAr7fIAgRooNqNcgc1F7OUX4hcidiynlr41AD7Hgwh/u1eaFykXF9Hxl57o/Py74mP/fsicHb/MM0qYl3fY++BGnnH2IFQPtcG2eeefTm3adLyTQbxwrmCzyD/q7RlflNRpblCkzxzOw+eGIK/6u0jC9P7bBU/QTtIgi04RsHC+senVBuCIYmZJfSv/F59HNf8nKPEBv6cVykNnVfFEF3cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OiUIHzXzpcVAKglYT+Gg8m1zknVA93PxDJJDq00dVyI=; b=p6eI9yJGt7AvXVw/UjutUj+GehTIVT9+k79Wqytd3k/KfS8n4f3RphfDPHOF5GssIr04AVMUwZ7KQQV2AFwr8xvoGJd3rkNpG6dmrMsRA/NuOEZrV5T+lzj64RUBpZcj3JaIIDZnh0lHjZusapOEpzEjNd990AEXBPyKAJGbNvguPI8aVWn9JFVibIZ3gu1KhvRpwuRxgsxOl0U/y4SVG2jq+XgPLDxUr4MUakqx81qOo14aBhsgzY4PzlQxZY90n3+fs8KhNREtOoOKxa+arbvSwFY1dIUMndTkdM3TslH42mLLMKFyueyW93zKZw9u8BH0uiaGLDbOl7hreFreSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM6PR11MB4738.namprd11.prod.outlook.com (2603:10b6:5:2a3::18) by BL3PR11MB6361.namprd11.prod.outlook.com (2603:10b6:208:3b4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.19; Thu, 7 Nov 2024 13:27:58 +0000 Received: from DM6PR11MB4738.namprd11.prod.outlook.com ([fe80::7064:9c9a:d2ca:c6a1]) by DM6PR11MB4738.namprd11.prod.outlook.com ([fe80::7064:9c9a:d2ca:c6a1%6]) with mapi id 15.20.8137.018; Thu, 7 Nov 2024 13:27:58 +0000 Content-Type: multipart/alternative; boundary="------------hAsDoalv5JPsZni10bc6UGIw" Message-ID: Date: Thu, 7 Nov 2024 18:56:30 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t 1/2] tests/kms_flip.c: Updating the skip message To: References: <20241015171849.1733664-1-pranay.samala@intel.com> Content-Language: en-US From: "Naladala, Ramanaidu" In-Reply-To: <20241015171849.1733664-1-pranay.samala@intel.com> X-ClientProxiedBy: PN3PR01CA0153.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:c8::18) To DM6PR11MB4738.namprd11.prod.outlook.com (2603:10b6:5:2a3::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR11MB4738:EE_|BL3PR11MB6361:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e042f34-0415-4c05-57fe-08dcff2ffe94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R1d1RjlkYTJWVWEvZms2YzZmaDMrS1JHeEJPQUhwNGtWSGE3bGt1N3dSellD?= =?utf-8?B?L0xoTXJhNk9sY1JGdkUvZ3lUWEoyeEFJdjdZcC9yL2hFZnZ1eFVPdm1Pakt4?= =?utf-8?B?NUwwUWZUaFBwUGZkRmRJWUZvL3dBcnlVMTlLM1pjbDg4NHoyVWdrNVcxQVJo?= =?utf-8?B?c0dUZHlHR2tKK2c5L1ljY2dUWXVMVnlvV0liODV5M1o3c0lNRWNkaHo2RTBX?= =?utf-8?B?SCs2cVhGQ05rVUhmTk9Ld2lSUG5FQTNxUkpRVE9YTnNjd2JZNWxLV0xHb2lr?= =?utf-8?B?RTEwVjJ3cXo4TTR0bEU0c2lJZDNMSkdlcit4ditsMGoyNG5EVjRDYU1rT2pZ?= =?utf-8?B?TUxkcitzUVdQSW52MXVOTVJaWmd1WkNrV1R4WFh3RGZiNUZZRXV5eTgwZXdQ?= =?utf-8?B?ZWIwSmI1aDVaSnJNcFJkZ0pKQVdlMCtUMDlVTzh1TDBZOVlHMUhnRmFGdDRE?= =?utf-8?B?S2szT3h1S29rWXBkRkZ4U2RFM3plUW1GTVFPZEdOSDQ3Ky9PWFBnVWdPV3Zm?= =?utf-8?B?clh5b3dINmhCNkhpZGtHUG9aVG1mY1BRVzg3VllWSDV3WDBORzluZzIzUmZF?= =?utf-8?B?U2FKdHpyMFE0QUxKc21zcUZsWnlFYUNHVDB1WjFuWFNjQlBCOGdOZ21kR3JG?= =?utf-8?B?aTlaeWZPZ0pUMmR5aDhHbGlKdnU1c2NmL0ZhdkJVV2F6a2pYd05aYnVxbFR1?= =?utf-8?B?WWdFTVFsazhPZTdxWFkxdCt2VWh3N2loT3JjRS96ODZxS3RNZjJpY2xTUWMw?= =?utf-8?B?R0FQcjVlTW9PenppYysxY2pEeUhjUXBLUFBta253NGxGMjdDNER3MmkrZk8x?= =?utf-8?B?OXFFNkM2Q3ZERzcyMVdFS2VNU25DS0ExU1FmZk9JVGYyZ1V3aTdqM3U3OEJR?= =?utf-8?B?NWlLWkZuNGR1MG45RlhKZlN1ZGZERFhhMmErdkJLdXlxdTFaTTNUWjBWN1hw?= =?utf-8?B?UU9ob0pqSE9VeHRKNmttM3RqSkJ1T2FnNE16MmtHRGNFdWlkY2U1QnZaRThW?= =?utf-8?B?VVJnYzhMU3FzaDhRbXF4MDg3ODdwZmFBdFZPKys0NjR0d1BrR2NSZkVhTk0w?= =?utf-8?B?QjZrTWEydHltd3hRbmVGSzAzL3BCSkFCQ3Z4WWw4bnU3Um5KODJ3eUhOdllt?= =?utf-8?B?V29DZFp0MXlBZkFsTHVURm5DZWx2enJFS1NYQXE5c0RCYTlBYXJJSDZhSW9p?= =?utf-8?B?NmJhSTBuRFM5VnF1Zkh3cVFLbFQ2cUNDeGVlcGRZZXFiUktjZUllS2hVY29V?= =?utf-8?B?TTJuWS9Dczc1SzdYbm9FanJUejYzenNoc2NDeS9TQTRady9leEZqay9XWTR4?= =?utf-8?B?UnRudEpzNG9mZFV6dU5nVUI5cys2OTFRVUdCaUs4dVh2WktwUS9nczZDYTVR?= =?utf-8?B?MmorcFgrR0Y3VDVBbGp0Z29zZWxncmFydC8vOHkrMTlyQWV2S1B6WmJpb1FS?= =?utf-8?B?M1UrWFBxeHhhNEZ1ZzYyb3FBamZocmxqS3o5bVhFYlNtcUJIMDRxcXlXVFI5?= =?utf-8?B?MXpNd1RIUW43UlMyQ3BpUlVJa2NmVjFMK0ZiaTgyOGtWcXZFNzZaOVo0dVE3?= =?utf-8?B?eVY5MW5la2xyQTZtTXFyeGdQWFM4RWwrZ2QySHVKd0E0VXJzV2RYR1Boa1cv?= =?utf-8?B?RmFTOHNnSUFXR2FHUkNoV01GcHlTbjRkN09rMTlmN0pJOVNCTFpjTU5jMTZI?= =?utf-8?B?M0d6R2t4NlRnWGQrUE5NZmYwenF2QXNVVEt1U0dyblV2bytIZUJ4T21JYS8w?= =?utf-8?Q?TofteI/S4nMfeAniUcZToBUDYm10y3sPNEHGmjU?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4738.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm4zM1BveXR4cGpqRHgrSkllSVFTcWxLMVBEN2dlcFhaaXRLMWx1cnFEWTdl?= =?utf-8?B?RmVoNHV1bGE1dGZ6QlorZTAzUXlJTFNWcVY2Y0ZjTENzM0d1QnFKTnpoMWhX?= =?utf-8?B?L3pSTGNOU2xrbnNneEVvOC9NOWdRcFpEN0U2VjVHYi83WWtOT2hFSy95YXR1?= =?utf-8?B?THNPRjU3S0h4NGtYSUlNdjR0Ni9oUnA3RkRWV0RDTVNCdkk2djRZa09xK2cz?= =?utf-8?B?UnF5MVFOYS9XK0lOZzBqM0xyRmRCNndmVWNMb1N4MTIzVDV2SlBueVc5R2g3?= =?utf-8?B?eGNtQmxaVGV3YjM1Z2VSc1E3VGtzSWREVmtXOVJlV2FRb21Mdkkxc1NlK0VC?= =?utf-8?B?VWM1VXgwc3VSMzhOb0JTNERDNkhYWkVWVkJTSjdMSDlyNTFjMFpEa3R1cW90?= =?utf-8?B?YmpBcUxiY1BMenRNVlpEek9JNyszeFNBdGRRdktocXd1VUhraEt3Wmt5Z2gx?= =?utf-8?B?TElwa1V4OVo4N0piUnZXOGZOZ0ZHV2NlZWdrVjB5NkxHY2RYT0g2dzNHUm94?= =?utf-8?B?bUt1dHg1dFR0b2dTSWFNK2ZUNVplWFNLeStWcjRZRjVaWWUxanVtVnZsN0s3?= =?utf-8?B?QWQxQmdCellxL0ZMUGE4TzhLYm1LclZSWHFabkYvdmw2VUNRVCs0MHZYMHMy?= =?utf-8?B?VHk1dnFUL3V2b0t4NERqY3RWOE5ydjMvejdtL0VlZndYMFpWZFlhRWtxY29O?= =?utf-8?B?dGtFZmh4NUkzUkF6VnpGS3ZielFqZHUrS3RWNGVjYXV2Z3YxVkx1aUN2SnVV?= =?utf-8?B?V3NtMEM0bWFrbUdNdXQvL3AzQUdqOEFVQmQ0czl6S3d6NnFQdS80Z0hmQWQ5?= =?utf-8?B?MElxREsyVHZHL3UwS1R3SE9ETnM1S3FQQVF4N1Z3b0VmT1VlbnhzdTVHc1E3?= =?utf-8?B?NnVNTzZxUmx5YkZhUFljM3VkcCtDdW1ERytreHE0VWVZejZEcDlUUElaVkU1?= =?utf-8?B?K0w5VThPcy9MMXI4RDQ0dzhOU2Z6UGdKOWxGNjJoR2RQZUV3a1JsMlJEVFQ0?= =?utf-8?B?SGdlMnRGb0VsR2l1eVZaUnp2NmRUelZvR3V2UFZ0cEdhZ2tFU2NIdkJuRllT?= =?utf-8?B?RzZVY0hZakxNUUF0N2Z1VDIwQ1ZkamJWQkJwc3FmQzAwMzlOTVdSTFYydjU1?= =?utf-8?B?eWtyazE2aVlyZGVOam9mVnVMejFTbkVBNEcrdjMrQ2J1THpLTHNkWWQwRGpB?= =?utf-8?B?UU1ZT0l4UUF3dldYQWZUWUJCTHpQZzB4Nkl2N1ZCNFZ2MjJPYkY3Z2piVVIw?= =?utf-8?B?SDVNUTNRRHdZWjc4cG9xUkYyVmJmMjVoZFhPem1sQ3g3NHd6YkJDWDB5VGV6?= =?utf-8?B?d2FETCt2czJ1Njlaei9hS2NUZ05TeldLcjJMMlRZVkxmSEp6WnExOUVMMVpt?= =?utf-8?B?aEUvSER2QXl3NHZCb3BCUHltY0tjbUhEVGUyT20zM0RWS1ljWGVCU3gxcXFS?= =?utf-8?B?aTRHRm82M1h0UFhVOWNxcVJIUW1aRWhKL1NzSUpXeVJUMnFORzN3QjJFZ2t4?= =?utf-8?B?RnZJSVhOaTE1TDRTU3dXMXJiV2Z5SWtXTmRxblY5S0V5TG4vdzA2TkVMRlFF?= =?utf-8?B?OHE2aFNSZllOZmNJazI5eTlWaGVHWDlmV3psb0MybVJOdE9PRzEyUTJsc1VY?= =?utf-8?B?SG9wMWtKQnVXVER4NnhINkxMdlQxSXM3TUk4NE81cmo0U3pEL3JUaGgzOWh3?= =?utf-8?B?eThqbXRyYk5YSXY4b3hPcjhYTGs2KzRua2pUbnBwRlk1OG44ZzBmWTluMTcx?= =?utf-8?B?LzlRZUJldGQzV2NwMVdxVmZRSTJkMkp4WDdTcy9UQTFFTmZlNEtyM0V0dVRI?= =?utf-8?B?bnNJOThubTJRdXluRE4ybEl1RGxJM2JYTnArTnFhWHhpbGN6T0ozSi9JcEVa?= =?utf-8?B?dElwTDNjK0MvNG0rMmcrbVhVcGNvZHZFMXZyL09ENkJSZ20wM05mUWwzcmNQ?= =?utf-8?B?WlZ2czV5VzVTWkp1K2xyVU1OZy9TZFVkR1F4RTBsdFpYKzcvaU14VTVtUDh1?= =?utf-8?B?N2RSNmNVSHFHV3NJZmFObG5NUW1JTkY1T3FjSG1zaHQ5T25uQ3BaQUJPeGlO?= =?utf-8?B?emdvekptZHBtVWNGWkFjZUN5T2g2endzNHN1L3dLNlBCajFLMFYrZFNDSkNR?= =?utf-8?B?WjErZ3pJaEVTSDQ4OEw5RXFxc0Q1TlhkMTUwaVNmZWRUOG9rRVY0SWxIMGls?= =?utf-8?B?R3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8e042f34-0415-4c05-57fe-08dcff2ffe94 X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4738.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2024 13:27:58.3322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RNOyVP2oArl8aAnHZmhnetG93BK28HiukWmMTSXoVQSLyKMBcabE7QR75tO6mh/paP7LRh2uMOabDTNfLRfSXrxehATZOLNBzKtFiNPhfEU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6361 X-OriginatorOrg: intel.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" --------------hAsDoalv5JPsZni10bc6UGIw Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 10/15/2024 10:48 PM, Pranay Samala wrote: > Debugging would be easier if we had logs available for > test failures and skips. This patch rephrases the skip > message for better understanding. > > Signed-off-by: Pranay Samala > --- > tests/kms_flip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c > index cbabbe74f..88cd41083 100755 > --- a/tests/kms_flip.c > +++ b/tests/kms_flip.c > @@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags) > > /* If we have fewer than 2 connected outputs then we won't have any > * configuration at all. So skip in that case. */ > - igt_require_f(modes, "At least two displays required\n"); > + igt_require_f(modes, "At least two displays with same modes are required\n"); LGTM, Reviewed-by: Naladala Ramanaidu > > if (duration) { > duration = duration * 1000 / modes; --------------hAsDoalv5JPsZni10bc6UGIw Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 10/15/2024 10:48 PM, Pranay Samala wrote:
Debugging would be easier if we had logs available for
test failures and skips. This patch rephrases the skip
message for better understanding.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/kms_flip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index cbabbe74f..88cd41083 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags)
 
 	/* If we have fewer than 2 connected outputs then we won't have any
 	 * configuration at all. So skip in that case. */
-	igt_require_f(modes, "At least two displays required\n");
+	igt_require_f(modes, "At least two displays with same modes are required\n");
LGTM,
Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
 
 	if (duration) {
 		duration = duration * 1000 / modes;
--------------hAsDoalv5JPsZni10bc6UGIw--