From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F77710E233 for ; Mon, 3 Jul 2023 19:47:49 +0000 (UTC) Message-ID: Date: Mon, 3 Jul 2023 16:47:41 -0300 MIME-Version: 1.0 To: Arthur Grillo , Development mailing list for IGT GPU Tools References: <20230703190052.14865-2-arthurgrillo@riseup.net> Content-Language: en-US From: Maira Canal In-Reply-To: <20230703190052.14865-2-arthurgrillo@riseup.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add check for intel device on use_enginecopy List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tales.aparecida@gmail.com, andrealmeid@riseup.net Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Arthur, On 7/3/23 16:00, Arthur Grillo wrote: > Certain tests (eg: kms_plane) are failing on vkms due to an assert in > intel_get_drm_devid which checks for an intel device. > > Add check for intel device before calling intel_get_drm_devid. > > Fixes: 422557124731 ("lib/igt_fb: include lib/intel_blt functions to blitter path") > > Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal Best Regards, - Maíra > --- > lib/igt_fb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/igt_fb.c b/lib/igt_fb.c > index 9529d198a..a8988274f 100644 > --- a/lib/igt_fb.c > +++ b/lib/igt_fb.c > @@ -2526,6 +2526,9 @@ static bool blitter_ok(const struct igt_fb *fb) > > static bool use_enginecopy(const struct igt_fb *fb) > { > + if (!is_intel_device(fb->fd)) > + return false; > + > if (!is_xe_device(fb->fd) && blitter_ok(fb)) > return false; >