Re: [PATCH i-g-t 4/6] lib/igt_kms: Export get_max_pipe_hdisplay as public helper

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

Hello Jani,

On 01-04-2026 17:17, Jani Nikula wrote:
> On Wed, 01 Apr 2026, Kunal Joshi <kunal1.joshi@intel.com> wrote:
>> Rename the static get_max_pipe_hdisplay to igt_get_max_pipe_hdisplay
>> and export it as a public API. This function returns the maximum
>> hdisplay a single pipe can drive. Tests like basic-max-non-joiner
>> need this value to distinguish outputs that can reach the single-pipe
>> boundary from those that cannot
>>
>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>> ---
>>   lib/igt_kms.c | 8 ++++----
>>   lib/igt_kms.h | 1 +
>>   2 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index dbd419a9b..961538932 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -6907,12 +6907,12 @@ int igt_get_current_cdclk(int fd)
>>   }
>>   
>>   /**
>> - * get_max_hdisplay:
>> + * igt_get_max_pipe_hdisplay:
>>    * @drm_fd: drm file descriptor
>>    *
>>    * Returns: The maximum hdisplay supported per pipe.
>>    */
>> -static int get_max_pipe_hdisplay(int drm_fd)
>> +int igt_get_max_pipe_hdisplay(int drm_fd)
> This is purely about Intel limitations, isn't it? The name is misleading
> for anything else.
>
> BR,
> Jani.
Correct, Will add intel prefix.

Thanks and Regards
Kunal Joshi
>
>>   {
>>   	int dev_id = intel_get_drm_devid(drm_fd);
>>   
>> @@ -6933,7 +6933,7 @@ static int get_max_pipe_hdisplay(int drm_fd)
>>    */
>>   bool igt_bigjoiner_possible(int drm_fd, drmModeModeInfo *mode, int max_dotclock)
>>   {
>> -	return (mode->hdisplay > get_max_pipe_hdisplay(drm_fd) ||
>> +	return (mode->hdisplay > igt_get_max_pipe_hdisplay(drm_fd) ||
>>   		mode->clock > max_dotclock);
>>   }
>>   
>> @@ -7047,7 +7047,7 @@ bool igt_is_joiner_enabled_for_pipe(int drmfd, enum pipe pipe)
>>    */
>>   bool igt_ultrajoiner_possible(int drm_fd, drmModeModeInfo *mode, int max_dotclock)
>>   {
>> -	return (mode->hdisplay > 2 * get_max_pipe_hdisplay(drm_fd) ||
>> +	return (mode->hdisplay > 2 * igt_get_max_pipe_hdisplay(drm_fd) ||
>>   		mode->clock > 2 * max_dotclock);
>>   }
>>   
>> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
>> index f994d91d3..2b5196c90 100644
>> --- a/lib/igt_kms.h
>> +++ b/lib/igt_kms.h
>> @@ -1236,6 +1236,7 @@ void igt_sort_connector_modes(drmModeConnector *connector,
>>   bool igt_max_bpc_constraint(igt_display_t *display, igt_crtc_t *crtc,
>>   			    igt_output_t *output, int bpc);
>>   int igt_get_max_dotclock(int fd);
>> +int igt_get_max_pipe_hdisplay(int drm_fd);
>>   int igt_get_max_cdclk(int fd);
>>   int igt_get_current_cdclk(int fd);
>>   bool igt_bigjoiner_possible(int drm_fd, drmModeModeInfo *mode, int max_dotclock);