From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB67588549 for ; Mon, 14 Jan 2019 18:05:40 +0000 (UTC) References: <20190111161548.15732-1-lukasz.kalamarz@intel.com> <4b44e8164060e99e7d67c8a5727d23ae659b06a6.camel@intel.com> From: Daniele Ceraolo Spurio Message-ID: Date: Mon, 14 Jan 2019 10:05:39 -0800 MIME-Version: 1.0 In-Reply-To: <4b44e8164060e99e7d67c8a5727d23ae659b06a6.camel@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t v3 1/4] lib/ioctl_wrapper: use defines for get_param instead of param number List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Kalamarz, Lukasz" , "igt-dev@lists.freedesktop.org" List-ID: CgpPbiAwMS8xNC8yMDE5IDA3OjU1IEFNLCBLYWxhbWFyeiwgTHVrYXN6IHdyb3RlOgo+IE9uIEZy aSwgMjAxOS0wMS0xMSBhdCAwOTo1NCAtMDgwMCwgRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyB3cm90 ZToKPj4KPj4gT24gMDEvMTEvMjAxOSAwODoxNSBBTSwgTHVrYXN6IEthbGFtYXJ6IHdyb3RlOgo+ Pj4gSW4gbGliIGNvZGUgdGhlcmUgd2VyZSBmZXcgZnVuY3Rpb25zIHVzaW5nIHBhcmFtIG51bWJl ciBpbnN0ZWFkIG9mCj4+PiBkZWZpbmVzLiBUaGlzIGNvdWxkIGxlYWQgdG8gc29tZSBpc3N1ZXMg KGkuZS4gc3RvbGVuIHN1cHBvcnQKPj4+IHBvaW50aW5nIG9uIGRpZmZlcmVudCBwYXJhbWV0ZXIp IGFuZCB3ZSB3b3VsZCBsaWtlIHRvIGF2b2lkIHRoZW0uCj4+Cj4+IFRoZSAzIGRlZmluZXMgeW91 J3JlIHRvdWNoaW5nIGFyZSBwYXJ0IG9mIHRoZSBwdWJsaXNoZWQga2VybmVsIHVhcGksCj4+IHNv Cj4+IHRoZXJlIGlzIG5vIHdheSBmb3IgdGhlbSB0byBjaGFuZ2UgYW5kIGNhdXNlIGlzc3Vlcy4g VGhlIGNoYW5nZSBpcwo+IAo+IAo+IEluIHRoZW9yeSB3aGF0IFlvdSd2ZSBzYWlkIGlzIHRydWUs IGJ1dCB3ZSBoYWQgb25lIGV4YW1wbGUgd2l0aGluIElHVAo+IHRoYXQgbWF5IGJlIGNhdXNpbmcg dHJvdWJsZXMuIFdlIGhhZCBnZW1fc3RvbGVuIGlzc3VlLCB3aGVyZSB3ZSBhcmUKPiBwb2ludGlu ZyB0byBwYXJhbSB3aXRoIGRpcmVjdCBudW1iZXIgKDM4KSwgYnV0IHRoZW4gdWFwaSBpcyBwb2lu dGluZyBvbgo+IHNvbWV0aGluZyBkaWZmZXJlbnQgKGNoYW5nZXMgaW4gaTkxNSBmb3Igc3RvbGUg c3VwcG9ydCB3ZXJlIG5ldmVyCj4gbWVyZ2VkKS4gV2hlbiBydW5uaW5nIHRob3NlIHRlc3RzIChv bmx5IGhpYmVybmF0ZSB0ZXN0Y2FzZSBpcyBub3QgcnVuCj4gaW4gZHVyaW5nIGZ1bGxydW4gZXhl Y3V0aW9ucykgd2UgbWF5IGJlIHRvdWNoaW5nIHNvbWV0aGluZyBkaWZmZXJlbnQKPiB0aGFuIHdl IGV4cGVjdC4KPiAKCk15IGNvbW1lbnQgd2FzIHJlZ2FyZGluZyBleGNsdXNpdmVseSB0aGUgZmxh Z3MgdG91Y2hlZCBieSB0aGlzIHBhdGNoLiAKVGhlIHRlc3QgaW4geW91ciBleGFtcGxlIHdhcyBt ZXJnZWQgdG8gSUdUIGJlZm9yZSB0aGUgZmxhZyB3YXMgbWVyZ2VkIGluIAp0aGUga2VybmVsLCB3 aGljaCBtZWFudCB0aGUgbGF0dGVyIHdhcyBzdGlsbCBub3QgcGFydCBvZiB0aGUgdWFwaSBhbmQg CnRodXMgY291bGQgc3RpbGwgY2hhbmdlLgoKRGFuaWVsZQoKPj4gc3RpbGwKPj4gd29ydGggZG9p bmcgSU1PIHNpbmNlIGRlZmluZXMgYXJlIGJldHRlciB0aGFuIGhhcmQtY29kZWQgbnVtYmVycy4K Pj4KPj4+IHYyOiBSZWJhc2VkIHBhdGNoCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogTHVrYXN6IEth bGFtYXJ6IDxsdWthc3oua2FsYW1hcnpAaW50ZWwuY29tPgo+Pj4gQ2M6IE1pY2hhbCBXaW5pYXJz a2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+Pj4gQ2M6IEthdGFyenluYSBEZWMgPGth dGFyenluYS5kZWNAaW50ZWwuY29tPgo+Pj4gQ2M6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRh bmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4+Cj4+IEFsbCAzIGRlZnMgYXJlIGluIHRoZSBpOTE1X2Ry bS5oIGZpbGUgaW4gSUdULCBzbyB3aXRoIGEgY2xlYW5lZAo+PiBjb21taXQKPj4gbWVzc2FnZToK Pj4KPj4gUmV2aWV3ZWQtYnk6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9s b3NwdXJpb0BpbnRlbC5jb20+Cj4+Cj4+PiAtLS0KPj4+ICAgIGxpYi9pb2N0bF93cmFwcGVycy5j IHwgNiArKystLS0KPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2xpYi9pb2N0bF93cmFwcGVycy5jIGIvbGli L2lvY3RsX3dyYXBwZXJzLmMKPj4+IGluZGV4IDlmMjU1NTA4Li5mNzFmMGUzMiAxMDA2NDQKPj4+ IC0tLSBhL2xpYi9pb2N0bF93cmFwcGVycy5jCj4+PiArKysgYi9saWIvaW9jdGxfd3JhcHBlcnMu Ywo+Pj4gQEAgLTcwOCwxMiArNzA4LDEyIEBAIGJvb2wgZ2VtX21tYXBfX2hhc193YyhpbnQgZmQp Cj4+PiAgICAJCWhhc193YyA9IDA7Cj4+PiAgICAKPj4+ICAgIAkJbWVtc2V0KCZncCwgMCwgc2l6 ZW9mKGdwKSk7Cj4+PiAtCQlncC5wYXJhbSA9IDQwOyAvKiBNTUFQX0dUVF9WRVJTSU9OICovCj4+ PiArCQlncC5wYXJhbSA9IEk5MTVfUEFSQU1fTU1BUF9HVFRfVkVSU0lPTjsKPj4+ICAgIAkJZ3Au dmFsdWUgPSAmZ3R0X3ZlcnNpb247Cj4+PiAgICAJCWlvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9H RVRQQVJBTSwgJmdwKTsKPj4+ICAgIAo+Pj4gICAgCQltZW1zZXQoJmdwLCAwLCBzaXplb2YoZ3Ap KTsKPj4+IC0JCWdwLnBhcmFtID0gMzA7IC8qIE1NQVBfVkVSU0lPTiAqLwo+Pj4gKwkJZ3AucGFy YW0gPSBJOTE1X1BBUkFNX01NQVBfVkVSU0lPTjsKPj4+ICAgIAkJZ3AudmFsdWUgPSAmbW1hcF92 ZXJzaW9uOwo+Pj4gICAgCQlpb2N0bChmZCwgRFJNX0lPQ1RMX0k5MTVfR0VUUEFSQU0sICZncCk7 Cj4+PiAgICAKPj4+IEBAIC05NjQsNyArOTY0LDcgQEAgc3RhdGljIGludCBnZW1fZ3R0X3R5cGUo aW50IGZkKQo+Pj4gICAgCWludCB2YWwgPSAwOwo+Pj4gICAgCj4+PiAgICAJbWVtc2V0KCZncCwg MCwgc2l6ZW9mKGdwKSk7Cj4+PiAtCWdwLnBhcmFtID0gMTg7IC8qIEhBU19BTElBU0lOR19QUEdU VCAqLwo+Pj4gKwlncC5wYXJhbSA9IEk5MTVfUEFSQU1fSEFTX0FMSUFTSU5HX1BQR1RUOwo+Pj4g ICAgCWdwLnZhbHVlID0gJnZhbDsKPj4+ICAgIAo+Pj4gICAgCWlmIChpb2N0bChmZCwgRFJNX0lP Q1RMX0k5MTVfR0VUUEFSQU0sICZncCwgc2l6ZW9mKGdwKSkpCj4+PgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3Qt ZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK