public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/kms_sharpness_filter: Restructure modifier validation into per-modifier subtests
@ 2026-02-17  9:30 Pranay Samala
  2026-02-17 20:30 ` ✓ Xe.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Pranay Samala @ 2026-02-17  9:30 UTC (permalink / raw)
  To: igt-dev; +Cc: karthik.b.s, sameer.lattannavar, pranay.samala

Previously, all modifiers were exercised within a single
subtest, making failures/skips hard to isolate and debug.
This new flow generates explicit subtest names (filter-modifier-%s)
for each modifier, improving clarity and CI reporting.

Each subtest now validates only the selected modifier, and
unsupported format/modifier combinations are cleanly skipped.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_sharpness_filter.c | 34 +++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index eddfad6b9..0140363bc 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -21,9 +21,6 @@
  * SUBTEST: filter-strength
  * Description: Verify that varying strength (0-255), affects the degree of sharpeness applied.
  *
- * SUBTEST: filter-modifiers
- * Description: Verify content adaptive sharpness filter with varying modifiers.
- *
  * SUBTEST: filter-rotations
  * Description: Verify content adaptive sharpness filter with varying rotations.
  *
@@ -70,6 +67,17 @@
  *              sharpness filter.
 */
 
+/**
+ * SUBTEST: filter-modifier-%s
+ * Description: Verify content adaptive sharpness filter with varying modifiers.
+ *
+ * arg[1]:
+ *
+ * @linear:	linear
+ * @x-tiled:	x-tiled
+ * @4-tiled:	4-tiled
+ */
+
 IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
 
 /*
@@ -596,16 +604,22 @@ int igt_main_args("l", NULL, help_str, opt_handler, &data)
 		}
 	}
 
-	igt_describe("Verify content adaptive sharpness filter with "
-		     "varying modifiers.");
-	igt_subtest_with_dynamic("filter-modifiers") {
+	for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
 		data.rotation = IGT_ROTATION_0;
 		data.format = DRM_FORMAT_XRGB8888;
 		data.filter_strength = MID_FILTER_STRENGTH;
-
-		for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
-			data.modifier = modifiers[i].modifier;
-			data.modifier_name = modifiers[i].name;
+		data.modifier = modifiers[i].modifier;
+		data.modifier_name = modifiers[i].name;
+
+		igt_describe("Verify content adaptive sharpness filter with "
+			     "varying modifiers.");
+		igt_subtest_with_dynamic_f("filter-modifier-%s", data.modifier_name) {
+			igt_skip_on_f((!igt_display_has_format_mod(&data.display,
+								   DRM_FORMAT_XBGR8888,
+								   data.modifier)),
+				       "Skipping: Modifier " IGT_MODIFIER_FMT
+				       " is not supported on this platform\n",
+				       IGT_MODIFIER_ARGS(data.modifier));
 
 			run_sharpness_filter_test(&data, TEST_FILTER_MODIFIERS);
 		}
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-02-26  3:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-17  9:30 [PATCH i-g-t] tests/intel/kms_sharpness_filter: Restructure modifier validation into per-modifier subtests Pranay Samala
2026-02-17 20:30 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-02-17 21:01 ` ✓ i915.CI.BAT: " Patchwork
2026-02-17 23:38 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-18  3:11 ` ✗ i915.CI.Full: " Patchwork
2026-02-26  3:01 ` [PATCH i-g-t] " Naladala, Ramanaidu
2026-02-26  3:48   ` Samala, Pranay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox