From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF000D1813D for ; Mon, 14 Oct 2024 19:05:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BBA910E4A4; Mon, 14 Oct 2024 19:05:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.b="NJs72J2E"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03E3310E4A4 for ; Mon, 14 Oct 2024 19:05:49 +0000 (UTC) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49EAo1ot032499; Mon, 14 Oct 2024 19:05:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IRZYeUiVXvHPbu6eBdLOrt5Ms10O78QiGeueaqqjLtE=; b=NJs72J2EtSitkf8D iQI9rADCpAoOX1J2ppSdYUfw/DmDci/XqEOJimAQCG5i4nDtGVkRX879r6ZWpQPx 46zPNGYvh1NGe4JacVSZH0w0TXw0f0baVc2Tz38hCJvUunFAIOzg79KXqn2mfoxf GZAxOlhwR+fwVmm6LRUOj/dbM6CbuU90ao1ynmbA/gLyEG4kl08ebxikQ8yM8Ufk /m4d8iQQWso6y2i9OhQYxaMELkscdQ47G6zPgf0pWd+1DPV099Er/ZLxzzd4t8ew At3pxhfnDJ5jrtICKnyzt8Ska85G8/OeCYBjEd/PMXwQ8OhVfHMYND3USm9zw4Gy MwqIbw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 427gpxnc1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 19:05:39 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 49EJ5c3A023281 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 19:05:38 GMT Received: from [10.110.109.95] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 14 Oct 2024 12:05:37 -0700 Message-ID: Date: Mon, 14 Oct 2024 12:05:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t v4 1/4] tests/kms_writeback: clear writeback properties in teardown path To: Kamil Konieczny , , Jessica Zhang , Petri Latvala , Arkadiusz Hiler , Juha-Pekka Heikkila , Bhanuprakash Modem , Ashutosh Dixit , Alex Hung References: <20240925-igt-cwb-v4-0-e516cd1e888e@quicinc.com> <20240925-igt-cwb-v4-1-e516cd1e888e@quicinc.com> <6e23b2b9-0e1c-4789-8de3-4a17e2a1e0c6@quicinc.com> <20241014135233.eshijf2ovgo54ntg@kamilkon-desk.igk.intel.com> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <20241014135233.eshijf2ovgo54ntg@kamilkon-desk.igk.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: LtAOIWo1bKn6l-RNm8ovow_Ie4fnwgTR X-Proofpoint-ORIG-GUID: LtAOIWo1bKn6l-RNm8ovow_Ie4fnwgTR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011 suspectscore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 malwarescore=0 mlxlogscore=929 priorityscore=1501 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410140135 X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On 10/14/2024 6:52 AM, Kamil Konieczny wrote: > Hi Abhinav, > On 2024-09-25 at 13:46:32 -0700, Abhinav Kumar wrote: >> >> >> On 9/25/2024 1:37 PM, Jessica Zhang wrote: >>> Drop the WRITEBACK_FB_ID property check and refactor detach_crtc() so >>> that it properly clears all writeback-related properties before calling >>> a NULL commit. >>> >>> The current WRITEBACK_FB_ID check in detach_crtc() will always return 0 >>> due to the return value being hardcoded to 0 in the framework [1]. >>> Because of this, detach_crtc() will never call the NULL commit to clean >>> up the atomic state. >>> >>> Since the NULL commit is failing for cases where the WRITEBACK_FB_ID and >>> OUT_FENCE_PTR haven't been cleared by a non-NULL commit, let's >>> explicitly clear these properties before calling the NULL commit. >>> >>> [1] https://elixir.bootlin.com/linux/v6.10.6/source/drivers/gpu/drm/drm_atomic_uapi.c#L853 >>> >>> Fixes: 7c3ceb08b ("tests/kms_writeback: Add helper method to detach pipe from output when test finishes") >>> Signed-off-by: Jessica Zhang >>> --- >>> tests/kms_writeback.c | 14 +++++--------- >>> 1 file changed, 5 insertions(+), 9 deletions(-) >>> >> >> >> This fixes a long pending issue today where kms_writeback does not clear the >> crtc it was using. Hence, >> >> Reviewed-by: Abhinav Kumar > > I will merge this now as in our CI this test skips. > > As for rest patches in series please re-work and resend and make sure > CI will be green (as 2/4 and 3/4 touch lib/kms). > > Regards, > Kamil > Thanks Kamil, noted. Abhinav