From: "Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
Cc: chaitanya.kumar.borah@intel.com
Subject: Re: [PATCH i-g-t] tests/kms_hdmi_inject: Retry ELD check to avoid transient audio races
Date: Tue, 28 Apr 2026 12:07:51 +0300 [thread overview]
Message-ID: <b538a92a-1e68-4166-be1f-741c1a90320d@gmail.com> (raw)
In-Reply-To: <20260427105856.133153-1-jeevan.b@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 27/04/2026 13.58, Jeevan B wrote:
> ELD population can lag HDMI audio enable on some platforms.
> Retry once to avoid spurious test failures.
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14867
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_hdmi_inject.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
> index 00eb5e4a4..f388a84c3 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -200,7 +200,13 @@ hdmi_inject_audio(int drm_fd, drmModeConnector *connector)
> * Test if we have /proc/asound/HDMI/eld#0.0 and is its contents are
> * valid.
> */
> - igt_assert(eld_has_igt());
> + if (!eld_has_igt()) {
> + igt_info("HDMI audio enabled but ELD not visible yet; retrying\n");
> + usleep(200 * 1000);
> +
> + igt_assert_f(eld_has_igt(),
> + "HDMI ELD missing after retry\n");
> + }
>
> igt_remove_fb(drm_fd, &fb);
>
next prev parent reply other threads:[~2026-04-28 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 10:58 [PATCH i-g-t] tests/kms_hdmi_inject: Retry ELD check to avoid transient audio races Jeevan B
2026-04-27 19:38 ` ✓ i915.CI.BAT: success for tests/kms_hdmi_inject: Retry ELD check to avoid transient audio races (rev2) Patchwork
2026-04-27 20:29 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-27 23:36 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-28 1:15 ` ✓ Xe.CI.FULL: success " Patchwork
2026-04-28 9:07 ` Juha-Pekka Heikkilä [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 10:56 [PATCH i-g-t] tests/kms_hdmi_inject: Retry ELD check to avoid transient audio races Jeevan B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b538a92a-1e68-4166-be1f-741c1a90320d@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox