From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC58CC369A2 for ; Wed, 9 Apr 2025 23:53:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F67E10E340; Wed, 9 Apr 2025 23:53:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="UNfDQw+x"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E6BA10E340 for ; Wed, 9 Apr 2025 23:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jYfavz1GguqALVn7LslPNK1xqUSNt8Rsn9Tk3gxSTUM=; b=UNfDQw+xG4EvPRJKs8FsH506D8 hz3AT2BDOTAPJEwcpDVs5+SLOlw5eKTITtIyRNz4psr8k4N4DILSPocpWW6g4hgiwGfNHQk2jHoej 4N6IWkwWnVrdd3UUZ4+fJgEiwvaDQnWZS4rwJs6huEqO9Z4zyvcSyzMv9peg/Iuh8dSnrC5j9IKA1 aN13lB5WEQYB1v3f0BFholIOnZEszFr4Zb6ji+aGqWrlQf8Oa7KJC1FOFhsRGgfty5Icrt4ccqOWQ 4RbIYTd9CMGe8OBmqvEm2/2bN7LdjnRRSiOZlm1PMXoSRNY1rM9MJOua+rDxWs5uMzqS3QPNKS0qp hluHwJrg==; Received: from [189.6.35.67] (helo=[192.168.0.55]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1u2fE0-00ENx4-7n; Thu, 10 Apr 2025 01:52:56 +0200 Message-ID: Date: Wed, 9 Apr 2025 20:52:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 0/4] tests/kms_async_flips: Create subtest for overlay planes To: =?UTF-8?Q?Andr=C3=A9_Almeida?= , igt-dev@lists.freedesktop.org, Jeevan B , Kamil Konieczny Cc: kernel-dev@igalia.com, Vitaly Prosyak , Alex Hung , Rodrigo Siqueira References: <20250409152206.132022-1-andrealmeid@igalia.com> Content-Language: en-US From: Melissa Wen In-Reply-To: <20250409152206.132022-1-andrealmeid@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On 09/04/2025 12:22, André Almeida wrote: > This patchset creates a subtest for overlay planes. This is supported by amdgpu > and is merged in the kernel: > > https://lore.kernel.org/lkml/173948734065.719858.7405160715916126757.b4-ty@linaro.org/ Hi, I just waited a while for CI results and they look good. So I applied this series to master. Thanks! Melissa > > v8: > - Make "Async page flip" name consistent in patch 1 > - Clarify documentation about asserting with a bad fd in igt_has_drm_cap() > > v7: > - igt_has_drm_cap() asserts only if it was a bad fd. The rest is up to the > caller to assert or require. > - we now have different errors for when the cap is not supported by the driver, > and when the cap doesn't exist in the kernel > > v6: > - Added missing `test_init_ops()` for "overlay-atomic" test > - Reworked `test_init_fbs()`: it destroys all buffers when the modifier > changes, and recreate then if they are need for the next test. It also destroys > overlay buffers if they are not needed anymore > > v5: > - Added a new patch "lib/ioctl_wrappers: let the caller handle capability check > result" by Melissa Wen > - This patch solved an issue that the test was exiting instead of skipping when > the driver did not support ATOMIC_ASYNC_PAGE_FLIP > - test_finish() is now called test_init_ops() and is called in the beginning of > every test. This was done because some asserts prevented the test to reach > the final of the run_test() function. > - Fixed a typo to correctly set the overlay fb to the overlay plane > - Added code to remove the overlay fb by the end of the test > - Fixed a bug that test_init_fbs() was skipping the fb creation for overlay > planes > - Fixed require_overlay_flip_support() by changing the fb to be flipped with > the async flip > > v4: > - Created a patch to check for DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP, so drivers > without support for it, skips instead of failing (Melissa) > - Encapsulated all test paths options into a function to easy maintenance (Melissa) > - Brought back test description for GitLab compilation > > v3: > - Fixed a bug that was mixing `alternate_sync_async = true` with the overlay path > - Refactored how the test parameters are being set/unset (patch 1/2) > - Fixed a bug where a primary buffer was being used with an overlay plane > > v2: Add test description for GitLab compilation > > André Almeida (4): > lib/ioctl_wrappers: let the caller handle capability check result > tests/kms_async_flips: Check for atomic async flip cap > kms_async_flips: Refactor data options > tests/kms_async_flips: Create subtest for overlay planes > > lib/ioctl_wrappers.c | 21 ++++--- > lib/ioctl_wrappers.h | 2 +- > tests/kms_async_flips.c | 131 ++++++++++++++++++++++++++++++++++------ > 3 files changed, 128 insertions(+), 26 deletions(-) >