Re: [igt-dev] [PATCH i-g-t v3 2/5] lib/igt_core: Add igt_require_fd()

Petri Latvala
2020-04-20T09:29:55Z

On Fri, Apr 17, 2020 at 05:10:22PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> Like igt_assert_fd(), but using igt_require() instead
>
> Changes since v1:
> * Fix documentation error in igt_require_fd() - Petri Latvala
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>

Reviewed-by: Petri Latvala <petri.latvala@intel.com>

> ---
> lib/igt_core.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/lib/igt_core.h b/lib/igt_core.h
> index 3f69b072..8f68b2dd 100644
> --- a/lib/igt_core.h
> +++ b/lib/igt_core.h
> @@ -1021,6 +1021,18 @@ void igt_describe_f(const char *fmt, ...);
> else igt_debug("Test requirement passed: %s\n", #expr); \
> } while (0)
>
> +/**
> + * igt_require_fd:
> + * @fd: file descriptor
> + *
> + * Skips (sub-) test if the given file descriptor is invalid.
> + *
> + * Like igt_require(), but displays the stringified identifier that was supposed
> + * to contain a valid fd on failure.
> + */
> +#define igt_require_fd(fd) \
> + igt_require_f(fd >= 0, "file descriptor " #fd " failed\n");
> +
> /**
> * igt_skip_on_f:
> * @expr: condition to test
> --
> 2.25.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev