Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Alex Hung <alex.hung@amd.com>, igt-dev@lists.freedesktop.org
Cc: harry.wentland@amd.com, mark.broadworth@amd.com, sunpeng.li@amd.com
Subject: Re: [PATCH 3/5] tools/amd_hdmi_compliance: Fix VIC 0 not working
Date: Tue, 29 Oct 2024 10:03:53 -0600	[thread overview]
Message-ID: <b5a5e1e0-304d-41dc-a471-16fa07b562ab@amd.com> (raw)
In-Reply-To: <20241024210345.511501-3-alex.hung@amd.com>



On 10/24/24 3:03 PM, Alex Hung wrote:
> From: Stylon Wang <stylon.wang@amd.com>
> 
> [WHY]
> VIC 0 is not working with -t option
> 
> [HOW]
> Make 0 pass as a valid VIC
> 
> Signed-off-by: Alex Hung <alex.hung@amd.com>
> Signed-off-by: Stylon Wang <stylon.wang@amd.com>
> ---
>   tools/amd_hdmi_compliance.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/amd_hdmi_compliance.c b/tools/amd_hdmi_compliance.c
> index c0a324eb9..f06af72b0 100644
> --- a/tools/amd_hdmi_compliance.c
> +++ b/tools/amd_hdmi_compliance.c
> @@ -527,7 +527,7 @@ int main(int argc, char **argv)
>   	if (max_bpc)
>   		set_max_bpc(&data, max_bpc, conn_id);
>   
> -	if (vic) {
> +	if (vic >= 0) {

Maybe you should squash this commit in the first one.

>   		if (vic > ARRAY_SIZE(test_modes) ||
>   		!test_modes[vic].name[0]) {
>   			igt_warn("VIC %d is not supported\n", vic);


  reply	other threads:[~2024-10-29 16:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 21:03 [PATCH 1/5] tools/amd_hdmi_compliance: Additional functionalities Alex Hung
2024-10-24 21:03 ` [PATCH 2/5] tools/amd_hdmi_compliance: Fix atomic commit failure Alex Hung
2024-10-29 16:02   ` Rodrigo Siqueira Jordao
2024-10-24 21:03 ` [PATCH 3/5] tools/amd_hdmi_compliance: Fix VIC 0 not working Alex Hung
2024-10-29 16:03   ` Rodrigo Siqueira Jordao [this message]
2024-10-24 21:03 ` [PATCH 4/5] tools/amd_hdmi_compliance: Support VIC 91 and 92 Alex Hung
2024-10-29 16:04   ` Rodrigo Siqueira Jordao
2024-10-24 21:03 ` [PATCH 5/5] tools/amd_hdmi_compliance: Add timeout option Alex Hung
2024-10-29 16:06   ` Rodrigo Siqueira Jordao
2024-10-24 22:46 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] tools/amd_hdmi_compliance: Additional functionalities Patchwork
2024-10-24 23:25 ` ✗ CI.xeBAT: " Patchwork
2024-10-28 13:39   ` Hung, Alex
2024-10-29 17:27     ` Kamil Konieczny
2024-10-26  7:09 ` ✗ CI.xeFULL: " Patchwork
2024-10-29 12:14 ` Patchwork
2024-10-29 16:01 ` [PATCH 1/5] " Rodrigo Siqueira Jordao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5a5e1e0-304d-41dc-a471-16fa07b562ab@amd.com \
    --to=rodrigo.siqueira@amd.com \
    --cc=alex.hung@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mark.broadworth@amd.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox