From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Date: Thu, 26 Jan 2023 16:12:32 +0000 MIME-Version: 1.0 Content-Language: en-US To: Kamil Konieczny , igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Dmitry Rogozhkin References: <20230112174730.1101192-1-tvrtko.ursulin@linux.intel.com> <20230112174730.1101192-5-tvrtko.ursulin@linux.intel.com> <20230126155017.hx37o7gmvolcah5p@kamilkon-desk1> From: Tvrtko Ursulin In-Reply-To: <20230126155017.hx37o7gmvolcah5p@kamilkon-desk1> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 4/4] intel_gpu_top: Aggregate engine classes in all output modes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 26/01/2023 15:50, Kamil Konieczny wrote: > On 2023-01-12 at 17:47:30 +0000, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> Use the same default for stdout and JSON output modes as it is for >> interactive. >> >> Previously added command line switch can be used to go back to showing all >> physical engines. >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Dmitry Rogozhkin > > Reviewed-by: Kamil Konieczny Downside with this one is that the default output for -l and -J modes will change. Which may result in bug reports. I am undecided on balance.. should have tagged it as RFC really. Thoughts? Regards, Tvrtko >> --- >> tools/intel_gpu_top.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >> index e91b47baf72b..7aa233570463 100644 >> --- a/tools/intel_gpu_top.c >> +++ b/tools/intel_gpu_top.c >> @@ -2509,11 +2509,12 @@ int main(int argc, char **argv) >> if (signal(SIGINT, sigint_handler) == SIG_ERR) >> fprintf(stderr, "Failed to install signal handler!\n"); >> >> + class_view = !physical_engines; >> + >> switch (output_mode) { >> case INTERACTIVE: >> pops = &term_pops; >> interactive_stdin(); >> - class_view = !physical_engines; >> break; >> case STDOUT: >> pops = &stdout_pops; >> -- >> 2.34.1 >>