From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190322092155.1656-1-chris@chris-wilson.co.uk> <20190322092155.1656-5-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: Date: Tue, 26 Mar 2019 09:19:33 +0000 MIME-Version: 1.0 In-Reply-To: <20190322092155.1656-5-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 05/24] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDIyLzAzLzIwMTkgMDk6MjEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBtYXkgdXNlIEhX IHNlbWFwaG9yZXMgdG8gc2NoZWR1bGUgbmVhcmx5LXJlYWR5IHdvcmsgc3VjaCB0aGF0IHRoZXkK PiBhcmUgYWxyZWFkeSBzcGlubmluZyBvbiB0aGUgR1BVIHdhaXRpbmcgZm9yIHRoZSBjb21wbGV0 aW9uIG9uIGFub3RoZXIKPiBlbmdpbmUuIEhvd2V2ZXIsIHdlIGRvbid0IHdhbnQgZm9yIHRoYXQg c3Bpbm5pbmcgdGFzayB0byBhY3R1YWxseSBibG9jawo+IGFueSByZWFsIHdvcmsgc2hvdWxkIGl0 IGJlIHNjaGVkdWxlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIHRlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1bGUu YyB8IDg3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIDEgZmlsZSBjaGFu Z2VkLCA4NyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2k5MTUvZ2VtX2V4 ZWNfc2NoZWR1bGUuYyBiL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1bGUuYwo+IGluZGV4IDRm MDU3N2I0ZS4uYWU4NTBjNGEzIDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2No ZWR1bGUuYwo+ICsrKyBiL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1bGUuYwo+IEBAIC00OCw2 ICs0OCwxMCBAQAo+ICAgCj4gICAjZGVmaW5lIE1BWF9DT05URVhUUyAxMDI0Cj4gICAKPiArI2Rl ZmluZSBMT0NBTF9JOTE1X0VYRUNfQlNEX1NISUZUICAgICAgKDEzKQo+ICsjZGVmaW5lIExPQ0FM X0k5MTVfRVhFQ19CU0RfTUFTSyAgICAgICAoMyA8PCBMT0NBTF9JOTE1X0VYRUNfQlNEX1NISUZU KQo+ICsjZGVmaW5lIEVOR0lORV9NQVNLICAoSTkxNV9FWEVDX1JJTkdfTUFTSyB8IExPQ0FMX0k5 MTVfRVhFQ19CU0RfTUFTSykKPiArCj4gICBJR1RfVEVTVF9ERVNDUklQVElPTigiQ2hlY2sgdGhh dCB3ZSBjYW4gY29udHJvbCB0aGUgb3JkZXIgb2YgZXhlY3V0aW9uIik7Cj4gICAKPiAgIHN0YXRp YyBpbmxpbmUKPiBAQCAtMzIwLDYgKzMyNCw4NiBAQCBzdGF0aWMgdm9pZCBzbW9rZXRlc3QoaW50 IGZkLCB1bnNpZ25lZCByaW5nLCB1bnNpZ25lZCB0aW1lb3V0KQo+ICAgCX0KPiAgIH0KPiAgIAo+ ICtzdGF0aWMgdWludDMyX3QgX19iYXRjaF9jcmVhdGUoaW50IGk5MTUsIHVpbnQzMl90IG9mZnNl dCkKPiArewo+ICsJY29uc3QgdWludDMyX3QgYmJlID0gTUlfQkFUQ0hfQlVGRkVSX0VORDsKPiAr CXVpbnQzMl90IGhhbmRsZTsKPiArCj4gKwloYW5kbGUgPSBnZW1fY3JlYXRlKGk5MTUsIEFMSUdO KG9mZnNldCArIDQsIDQwOTYpKTsKPiArCWdlbV93cml0ZShpOTE1LCBoYW5kbGUsIG9mZnNldCwg JmJiZSwgc2l6ZW9mKGJiZSkpOwo+ICsKPiArCXJldHVybiBoYW5kbGU7Cj4gK30KPiArCj4gK3N0 YXRpYyB1aW50MzJfdCBiYXRjaF9jcmVhdGUoaW50IGk5MTUpCj4gK3sKPiArCXJldHVybiBfX2Jh dGNoX2NyZWF0ZShpOTE1LCAwKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgc2VtYXBob3JlX3Vz ZXJsb2NrKGludCBpOTE1KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4ZWNfb2JqZWN0 MiBvYmogPSB7Cj4gKwkJLmhhbmRsZSA9IGJhdGNoX2NyZWF0ZShpOTE1KSwKPiArCX07Cj4gKwlp Z3Rfc3Bpbl90ICpzcGluID0gTlVMTDsKPiArCXVuc2lnbmVkIGludCBlbmdpbmU7Cj4gKwl1aW50 MzJfdCBzY3JhdGNoOwo+ICsKPiArCWlndF9yZXF1aXJlKGdlbV9zY2hlZHVsZXJfaGFzX3ByZWVt cHRpb24oaTkxNSkpOwo+ICsKPiArCS8qCj4gKwkgKiBHaXZlbiB0aGUgdXNlIG9mIHNlbWFwaG9y ZXMgdG8gZ292ZXJuIHBhcmFsbGVsIHN1Ym1pc3Npb24KPiArCSAqIG9mIG5lYXJseS1yZWFkeSB3 b3JrIHRvIEhXLCB3ZSBzdGlsbCB3YW50IHRvIHJ1biBhY3R1YWxseQo+ICsJICogcmVhZHkgd29y ayBpbW1lZGlhdGVseS4gV2l0aG91dCBzZW1hcGhvcmVzLCB0aGUgZGVwZW5kZW50Cj4gKwkgKiB3 b3JrIHdvdWxkbid0IGJlIHN1Ym1pdHRlZCBzbyBvdXIgcmVhZHkgd29yayB3aWxsIHJ1bi4KPiAr CSAqLwo+ICsKPiArCXNjcmF0Y2ggPSBnZW1fY3JlYXRlKGk5MTUsIDQwOTYpOwo+ICsJZm9yX2Vh Y2hfcGh5c2ljYWxfZW5naW5lKGk5MTUsIGVuZ2luZSkgewo+ICsJCWlmICghc3Bpbikgewo+ICsJ CQlzcGluID0gaWd0X3NwaW5fYmF0Y2hfbmV3KGk5MTUsCj4gKwkJCQkJCSAgLmRlcGVuZGVuY3kg PSBzY3JhdGNoLAo+ICsJCQkJCQkgIC5lbmdpbmUgPSBlbmdpbmUpOwo+ICsJCX0gZWxzZSB7Cj4g KwkJCXR5cGVvZihzcGluLT5leGVjYnVmLmZsYWdzKSBzYXZlZCA9IHNwaW4tPmV4ZWNidWYuZmxh Z3M7Cgp1NjQgcmVhZHMgYmV0dGVyIGFuZCBzdHJ1Y3QgZWIgd29uJ3QgY2hhbmdlIGFueXdheS4K Cj4gKwo+ICsJCQlzcGluLT5leGVjYnVmLmZsYWdzICY9IH5FTkdJTkVfTUFTSzsKPiArCQkJc3Bp bi0+ZXhlY2J1Zi5mbGFncyB8PSBlbmdpbmU7Cj4gKwo+ICsJCQlnZW1fZXhlY2J1ZihpOTE1LCAm c3Bpbi0+ZXhlY2J1Zik7CgpEbyB5b3UgbmVlZCB0byB3YWl0IGZvciBzcGlubmVyIHRvIGJlIHJ1 bm5pbmcgYmVmb3JlIHN1Ym1pdHRpbmcgdGhlc2UgCm9uZXMsIHRvIG1ha2Ugc3VyZSB0aGUgbG9n aWMgZW1pdHMgYSBzZW1hcGhvcmUgcG9sbCBmb3IgdGhlbSBhbmQgc3VibWl0cyAKdGhlbSBzdHJh aWdodCBhd2F5PwoKPiArCj4gKwkJCXNwaW4tPmV4ZWNidWYuZmxhZ3MgPSBzYXZlZDsKPiArCQl9 Cj4gKwl9Cj4gKwlpZ3RfcmVxdWlyZShzcGluKTsKPiArCWdlbV9jbG9zZShpOTE1LCBzY3JhdGNo KTsKPiArCj4gKwkvKgo+ICsJICogT24gYWxsIGRlcGVuZGVudCBlbmdpbmVzLCB0aGUgcmVxdWVz dCBtYXkgYmUgZXhlY3V0aW5nIChidXN5d2FpdGluZwo+ICsJICogb24gYSBIVyBzZW1hcGhvcmUp IGJ1dCBpdCBzaG91bGQgbm90IHByZXZlbnQgYW55IHJlYWwgd29yayBmcm9tCj4gKwkgKiB0YWtp bmcgcHJlY2VkZW5jZS4KPiArCSAqLwo+ICsJc2NyYXRjaCA9IGdlbV9jb250ZXh0X2NyZWF0ZShp OTE1KTsKPiArCWZvcl9lYWNoX3BoeXNpY2FsX2VuZ2luZShpOTE1LCBlbmdpbmUpIHsKPiArCQlz dHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4ZWNidWZmZXIyIGV4ZWNidWYgPSB7Cj4gKwkJCS5idWZmZXJz X3B0ciA9IHRvX3VzZXJfcG9pbnRlcigmb2JqKSwKPiArCQkJLmJ1ZmZlcl9jb3VudCA9IDEsCj4g KwkJCS5mbGFncyA9IGVuZ2luZSwKPiArCQkJLnJzdmQxID0gc2NyYXRjaCwKPiArCQl9Owo+ICsK PiArCQlpZiAoZW5naW5lID09IChzcGluLT5leGVjYnVmLmZsYWdzICYgRU5HSU5FX01BU0spKQo+ ICsJCQljb250aW51ZTsKClVnaCBzYXZpbmcgYW5kIHJlc3RvcmluZyBlYiBmbGFncyB0byBmaW5k IHRoZSBzcGlubmluZyBlbmdpbmUgaGVyZSBJIApmZWVsIHdpbGwgYmUgYSBsYW5kIG1pbmUgZm9y IHRoZSB1cGNvbWluZyBmb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUgCmNvbnZlcnNpb24gYnV0IHdo YXQgY2FuIHdlIGRvLgoKPiArCj4gKwkJZ2VtX2V4ZWNidWYoaTkxNSwgJmV4ZWNidWYpOwo+ICsJ fQo+ICsJZ2VtX2NvbnRleHRfZGVzdHJveShpOTE1LCBzY3JhdGNoKTsKPiArCWdlbV9zeW5jKGk5 MTUsIG9iai5oYW5kbGUpOyAvKiB0byBoYW5nIHVubGVzcyB3ZSBjYW4gcHJlZW1wdCAqLwoKSSBn b3QgbG9zdCAtIGhvdyBkb2VzIHRoaXMgd29yayBpZiB0aGUgc3Bpbm5lciBpcyBzdGlsbCBrZWVw aW5nIHRoZSAKb2JqLmhhbmRsZSBidXN5PwoKPiArCWdlbV9jbG9zZShpOTE1LCBvYmouaGFuZGxl KTsKPiArCj4gKwlpZ3Rfc3Bpbl9iYXRjaF9mcmVlKGk5MTUsIHNwaW4pOwo+ICt9Cj4gKwo+ICAg c3RhdGljIHZvaWQgcmVvcmRlcihpbnQgZmQsIHVuc2lnbmVkIHJpbmcsIHVuc2lnbmVkIGZsYWdz KQo+ICAgI2RlZmluZSBFUVVBTCAxCj4gICB7Cj4gQEAgLTEzMDcsNiArMTM5MSw5IEBAIGlndF9t YWluCj4gICAJCQlpZ3RfcmVxdWlyZShnZW1fc2NoZWR1bGVyX2hhc19jdHhfcHJpb3JpdHkoZmQp KTsKPiAgIAkJfQo+ICAgCj4gKwkJaWd0X3N1YnRlc3QoInNlbWFwaG9yZS11c2VyIikKPiArCQkJ c2VtYXBob3JlX3VzZXJsb2NrKGZkKTsKPiArCj4gICAJCWlndF9zdWJ0ZXN0KCJzbW9rZXRlc3Qt YWxsIikKPiAgIAkJCXNtb2tldGVzdChmZCwgQUxMX0VOR0lORVMsIDMwKTsKPiAgIAo+IAoKUmVn YXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=