From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4563E77188 for ; Mon, 30 Dec 2024 16:33:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 61F2210E37F; Mon, 30 Dec 2024 16:33:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="UdNfp6a/"; dkim-atps=neutral Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2075.outbound.protection.outlook.com [40.107.93.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6888410E37F for ; Mon, 30 Dec 2024 16:33:53 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y3BvpLabj44d7pqkdWVeEU8qLwCJgpNlCkMGK6/lBWrLq4T1y9MIKl0sTgmnU8UBerLO3i47LrY+RQwGJYOn6YbJ54QEumgEnStRB+hDJMvtb6YWCHeUPc8KeOr2msA5/xBLBAyCYxUJc0nSIlrCuukBGsGM41efIPgCJHFTMQjCCRe+ivwTsmVNXkU36OYHk4IBTK9WXFBsthQhpOPsamKHLKmiVBRAhlCjwLkacPjl6wdyTrMFXO+x1CgxTrldWd3VQs8kKqIrMrW+CXT78NWi8jleqPORVy1s/mHiiNPKpSk4dYUaktdIF75Om5Qfa6fw0qs2jjCpV/u+roHw6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GMpMUWgWlT7a/2+sMOZKOZQRjvvXVQNu3k4gt4zSXro=; b=iLIeLe6LcdIYOzx1iEq6djg8tRjhU1c0EyrooFSOeQJ6fFCXfJy1yVKxnMD20UlTXJt9J1iKLeatIO07GQIIiTJnm3yGuuWww9T1VCTyE41HjEwE/5D5NzZgZ7c95RQ9rrA0AhuttG3+mBtk3cxqs+RWxbryp3V3G7n4ajJf0Sf2xDWWl/IraTVWFwgS4UPbrJZAd8qtJyuVVVJDa52wTRc9VpoY8Lh2yJ9rj/CS4BmREB/RPrm0W+hUnWo8HyUY8hRbVdCb1Nm/ylfTK+WMzDSt5/5di7I/eaKMeX3OYctBKXO6cVJnr9NHkPsA4thpTQ/tKzaiCnQTj54P7ghtnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GMpMUWgWlT7a/2+sMOZKOZQRjvvXVQNu3k4gt4zSXro=; b=UdNfp6a/gGVcv2jvE69KJwz7DeEZHVeRns44Sd1t3MvD6HPIrElwnpvZACaxW2tULKd/0pkWJWNIioZmL88SyYLQxY2JpNcwXSx9jlhn7X3d9SSkXjB7iGsSHVnKFr/4Fiw0Y9MpnUCVWy/G9DlIIV7N2c5b3/zRth77NQQY4o8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB6420.namprd12.prod.outlook.com (2603:10b6:510:1fc::18) by SA1PR12MB6776.namprd12.prod.outlook.com (2603:10b6:806:25b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.18; Mon, 30 Dec 2024 16:33:45 +0000 Received: from PH7PR12MB6420.namprd12.prod.outlook.com ([fe80::e0e7:bd76:e99:43af]) by PH7PR12MB6420.namprd12.prod.outlook.com ([fe80::e0e7:bd76:e99:43af%5]) with mapi id 15.20.8293.000; Mon, 30 Dec 2024 16:33:45 +0000 Message-ID: Date: Mon, 30 Dec 2024 11:33:42 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t] lib/amdgpu: add GFX1153 to GFX1150 family To: Tim Huang , igt-dev@lists.freedesktop.org Cc: vitaly.prosyak@amd.com, alexander.deucher@amd.com, jie1zhan@amd.com References: <20241230065607.3335566-1-tim.huang@amd.com> Content-Language: en-US From: vitaly prosyak In-Reply-To: <20241230065607.3335566-1-tim.huang@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0139.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:87::13) To PH7PR12MB6420.namprd12.prod.outlook.com (2603:10b6:510:1fc::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB6420:EE_|SA1PR12MB6776:EE_ X-MS-Office365-Filtering-Correlation-Id: abf1e156-500c-4432-e8a9-08dd28efbac4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Ti9mdnRRcmtycG5GeWVZM0Qyb3JIVGM3dXRRaFR4Qnp0ZW5jei8rajJjMUYr?= =?utf-8?B?WU9FSnUrSXNmbjlYMVp3cysyTVZJL2ZkdkhpN1k4QVBmSlZEdVdPRFAzdGUy?= =?utf-8?B?K0lGK3VEZ0o5YUszOGZqQXlhVHhBNmxVMER1Z1hESzJ6Nk9iR3k2b3I1Qi84?= =?utf-8?B?SGFOUmk2MTgrMjhqZFhyOURhNTZ0b0JEMDJWVWRKU3prVzBOL1Y0K3FkOXNQ?= =?utf-8?B?b3NxWWt6TzJrOXFrUmYvYTdWcEZ2OTYyZm8rM3lTU2VjVVZ6ZUxrbEFJNk5s?= =?utf-8?B?cFp5OVZSRGpFQ1orRGRGTlVnS1FDK2NZWEVOSDJzTk12aDk0Mlo3aWNxSGs1?= =?utf-8?B?aGNCM3NaQWpUSXZjTVBuWHlHeHkxVG40VFVFRTRFQ0VuZ25LdDlZVkdhWFpZ?= =?utf-8?B?a2g3eU5iUk40RWNyMFVlOHZPKzNqZzdySjNES0hGQVpmM1ZiWFg4by9LaDcv?= =?utf-8?B?MjlsL3NtT0NiVnFvbnBYS0J6NlNtMXVLS205OFozODNEaEZBcStrVEd1Tk9i?= =?utf-8?B?Uk5VYVNWcWxUVTJQeVdGZE1lY1RzYUtwZ3J3a1BsTll0bEV4blVOeng1emdl?= =?utf-8?B?MnpBa1RkSE91L05ib2tnakRsMjZjQlFkb2dTMjJPSG9qYkNWSUxVeDRKbmdq?= =?utf-8?B?dmUrRGFiTEVBbnJGL3Q0SHFkazRRL2lncGpRd2dmZmNmM3RjRkJVcDhRSzIr?= =?utf-8?B?TitsdUFUOWVnaTN1cUpYbTgvSHBTaExYSUh0QlFqeFdQUWdxNUFQcDJoNmY3?= =?utf-8?B?bzEvNGNpUnFUaG5qZktBaDYyaTU0S0xkV2VqYlNsVXo4TzMwQmV5YVJjMWx0?= =?utf-8?B?Rmw3QVYrbk5xQXhKVTJGc2k1b0loSXU5ZGdNQ3N2bkRxQTlSU3BVMUlMTURH?= =?utf-8?B?MjRhS3BTUU5KREluT0tFdUpzWmxyQ09NT0J3OS8xZktPSVIyZ21xQmVhWUNV?= =?utf-8?B?amQyS05lMTIyWkRtMTEwcUlXTnN0RjFTMDQwQXRKNXJoSnQ5NHp6L2JiNjFX?= =?utf-8?B?NERyejd4eFJldHRtMFplb1dEY0Y2SkZ2TDN5bmFJbFNPMTE5a2pKRm1FK2hz?= =?utf-8?B?WTRHZjdLZzNqQUtVMTJRN3hkMmUvZW1VTHBjOEdWK3c3K1UyaTNpdkhMOVBK?= =?utf-8?B?RHBkRDJlUithaU5Ib1J3cnBhT2JQK294cHNTT0tmajM5Z2taMVpBbmhETGlp?= =?utf-8?B?Q1MrSDZ6eTllU1RlcTUwSTFYU1RUS29HbjAya1E1MDUxR3FhMWExaVJ2eGVI?= =?utf-8?B?cXp2bTVqdVo3MW5HODlxK1VXSE5tR053ai93eHR5Qkdwa3REYTBsOWlCRzZJ?= =?utf-8?B?R2RZOHZIR0VRWFhFMDMyeUh0YThmdTMwdjhmbzJURE1oY3czRktLSnZiMjdo?= =?utf-8?B?bTBrSS9aVVFad0IxUjdhSUhkaWNPL2JvNmlBeG8xSU1uMHFBUHNzUzBXR0tL?= =?utf-8?B?RU5iYTc5SGQwdHpJZjAyMllwTGUyY3VRWGJLQzE0Nzdpb3RDbkYwckxjUTd2?= =?utf-8?B?MXZBMk03NEMrWmJuZzJzTkVERGc3blBZM1h2QkV4akp5Wk8wTjM2YlJFazhu?= =?utf-8?B?dmhLK214b1l6Q3N6VnNvUllIOGZMaUhlOWptbzRKTzc0V2VOSjZ4MlFOVVVQ?= =?utf-8?B?dUdJMGJIR214OHJGTFFjWXZCYzBBSFJIaTlHdkpPWENFdUxlR1JQYWZ1NkFa?= =?utf-8?B?R1dtSDFlNGFPY1FhQ2FXcjg2bys3U0ZaQlQ3cnBQZjdHSXZPSUF2REhwOUF6?= =?utf-8?B?VVdYSEZQRExiTFh5Ny9nZzk0SlZCZEowclRZZ0JkRGd4SE5waDJMbXhPdFhT?= =?utf-8?B?bHhSdytZUE9hWFRLV2FVWFpYUFBUcnFQRVZNTGlvT1k2anBDRUkxa1lMM1Vq?= =?utf-8?Q?8JJCVlOR81H07?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB6420.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akkzbURsMDlFamJtdithTUZFbGJSVjNFM1VNZmRkZ1FWTkNpN3ZKSFZCUUF5?= =?utf-8?B?OHNRcmtLUTlMM09GUmh2dWNkak52Vk1uS3ZKZE53ZTEwTklGS0YrWVBSZUs4?= =?utf-8?B?T3dod1FMbFh3SHkrRVp0WkNsN0J5MitiNys1VURiVDN5MkZsQXVDcEJIRkhS?= =?utf-8?B?NDQvZFJ3ZUU2VnJCV2oyZnkyckdNMjVPOG9hT3hJaHhKanJpTmY4ampCcnZu?= =?utf-8?B?UERXb0w4ck5vNWJwbzlmaWFhL1oyTmZMNjRTUTYySkkxUzhZWTBFbDVOcnc5?= =?utf-8?B?dUF6cCtISzRXNTA1MTNjbkVGR3Z1VHJzLzdSL1o3a2lGTkhPUnFScDl5ckg5?= =?utf-8?B?bDU0Si9WckF6UDVua3U4dmFXZE5Cd0J6Vkk1aGZkdjRtcjk2S0ozZHVqL3ZE?= =?utf-8?B?blBRTEUzMHozTVpyS0tpbXVwWUJsNTNKWU9IRVMxUVZGbGZYMmUvV0FuTVZv?= =?utf-8?B?TlNZZnZzdE1vVEtiWnI1Q1N6cFRxOFNHdDFZbWxJVTUvNVJyODdINWdacWcx?= =?utf-8?B?TnZ6ajEvaGJpVTJjb2tYQUxRV2RQeFE0RTMyV2hNVGtCZnRVNWY5bFlTK2Jp?= =?utf-8?B?TU85cVRad0lvSTVHWVJDcWxQVWd1MzIzNzBUWkVtUWYxYlhnM1Y5OWFxWDVP?= =?utf-8?B?TVFRdklYbUloeW5lZXhwTC82TUE3SWNUcTZTV3lXNUtNWXcxanBwQSt4SVFB?= =?utf-8?B?czMxajlmTk5COTJtbnRvSmFHNHlBeERUL0VNaUJpaWJlUjlvRnQvZE9aS2Zh?= =?utf-8?B?aWZKRE9waWZ0NVJLemVKUWFxejEzQTNzK2wxTGhLNndTbDRYRGtYYkM0MnV4?= =?utf-8?B?UXh3WWlNbWl6MWRQNGdBZ2h4QXM0SVlCNmQxVXRUNVQ1aHRwSmNEbDd2TFRP?= =?utf-8?B?SmszYllQYUcxQm42RitBdDBweWZnQVdibHl2T2FCR2V6UGpCbWQzY0theDNr?= =?utf-8?B?ZC9tQmV0OXJpWmt0eUM0VVExbHp2YzRTdWR5dURlOHcxbHZKWGxDTzBpVFpx?= =?utf-8?B?SmE0TnQ0T2RXY1lraUFtd1p4SVdpZUw0TlFrbktlMHNBQmdrTkVOamRoNnFV?= =?utf-8?B?Vy90OHJOOXhHTHBrY0FjbXU2akhhQXZjTU9mamFRbFlCWVdHUVMwR1cwd1li?= =?utf-8?B?NDlNejBWdFAzNmtpbmlySUtCVm1vY0U0YWhBWk83NGhkQXRQL3V4ZzBlMitE?= =?utf-8?B?S0c5TEpVdUt5M21tT0tSdUJES1o4R2FlN3dNUU9LT2VpUmQ5ZzBuNkR6L0xQ?= =?utf-8?B?OS9tWXVpdFNnZmp6Nk9oKzEvRlpEY2tVMTRyOEdPVVJhMlcyazNtZnBUUWFz?= =?utf-8?B?aTVUcTJFNThEaU9Jb1lJbUoxQzlBcVRadUh5R1NFK0x0RkF5emxZZ1pkVzhK?= =?utf-8?B?Y2NnTjVnL0Y5ZGN1R3gvd1FYdmN4NVR1L01YSE9XOTdKdVBLWUZmek95bEsx?= =?utf-8?B?Y3V2bWdlMGd0S2V0YlpDK1BMeWRCTi84MjRXc2tRdmhnM0M4K0hNV1k0cWlJ?= =?utf-8?B?WHZtNEFNN243YysrYzFUZ2QzTTVaOTJqZFpiZHhUVmVnTHZhb1lkd2hJWUdN?= =?utf-8?B?Y0RFTHFzZnZESWJRa3hIUlBDUDZYdVhpaEpGdWpuejRnUHk5S3lEaDB3WW13?= =?utf-8?B?dlNZRklEM2JLWURGYTg1NGRIT2gyS09FZ0JRNHh1U2N5b0s4L0NrZGZEVXJ0?= =?utf-8?B?MUpZTE1vZmR2M0czQ0REZk9jZXdlOTJqOEcvTC8xbFNDc2VZNWY3dlA2azVN?= =?utf-8?B?NGsxeHh0WUZUQXlsckorc0x5SG9IODBLSWZTdTg0TTdmMzNYVERZRENHaWNR?= =?utf-8?B?aC9VSGNkNXJGY0tobndUejd0TFh1VS9CdU9wSFNST2hVdXM2RVdxaGIwS3hC?= =?utf-8?B?L1Mvbi90RTFxdDJBT0JjTU1ESmh4by9EZmtPbGxYVjdHRjQ1TE9FeFlEb2d4?= =?utf-8?B?NFFLcnp2RUVEUmIwdGJLQTM1MTIzeUtlcFc4YnpvTVlLdWdTR21NQnhpVlBQ?= =?utf-8?B?SzljSld3RFEwaHFqNzdpZnhzU2xyTkxmN0JDeTlmcGtteXh6KzQ0d2paNUNi?= =?utf-8?B?YlFsQVhUc3pFVzlDWkxuL2JGa3VFQTRscDVod1Ywc3FEMDd1TG9GSmxEOXk2?= =?utf-8?Q?U/UUAUGGre42UN0pRM2jRKUN8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: abf1e156-500c-4432-e8a9-08dd28efbac4 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6420.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2024 16:33:45.4802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cxsa93E6rbnwRd25uzXeH3K7b4GfrsgOTzJiWtJI0v63bU+lPesnRh/cdUfGZGGSYJM/RtUGxK4LCjXAEge6Bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6776 X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The change looks good to me. Please create a Git patch and send it my way, or if you have the necessary access, feel free to merge it directly. Reviewed-by: Vitaly Prosyak On 2024-12-30 01:56, Tim Huang wrote: > Add GFX1153 to the amdgpu supported chip list. > > Signed-off-by: Tim Huang > --- > lib/amdgpu/amd_family.h | 1 + > lib/amdgpu/amd_ip_blocks.c | 1 + > lib/amdgpu/amdgpu_asic_addr.h | 2 ++ > 3 files changed, 4 insertions(+) > > diff --git a/lib/amdgpu/amd_family.h b/lib/amdgpu/amd_family.h > index 54b0ae1d8..60190c639 100644 > --- a/lib/amdgpu/amd_family.h > +++ b/lib/amdgpu/amd_family.h > @@ -107,6 +107,7 @@ enum radeon_family { > CHIP_GFX1150, > CHIP_GFX1151, > CHIP_GFX1152, > + CHIP_GFX1153, > CHIP_GFX1200, > CHIP_LAST, > }; > diff --git a/lib/amdgpu/amd_ip_blocks.c b/lib/amdgpu/amd_ip_blocks.c > index 980bb9b0b..cc4163bfc 100644 > --- a/lib/amdgpu/amd_ip_blocks.c > +++ b/lib/amdgpu/amd_ip_blocks.c > @@ -800,6 +800,7 @@ int setup_amdgpu_ip_blocks(uint32_t major, uint32_t minor, struct amdgpu_gpu_inf > identify_chip(GFX1150); > identify_chip(GFX1151); > identify_chip(GFX1152); > + identify_chip(GFX1153); > break; > case FAMILY_GFX1200: > identify_chip(GFX1200); > diff --git a/lib/amdgpu/amdgpu_asic_addr.h b/lib/amdgpu/amdgpu_asic_addr.h > index d5579ce4c..63cea1a5d 100644 > --- a/lib/amdgpu/amdgpu_asic_addr.h > +++ b/lib/amdgpu/amdgpu_asic_addr.h > @@ -110,6 +110,7 @@ > #define AMDGPU_GFX1150_RANGE 0x01, 0x40 //# 01 <= x < 64 > #define AMDGPU_GFX1151_RANGE 0xc0, 0xFF //# 192 <= x < 255 > #define AMDGPU_GFX1152_RANGE 0x40, 0x50 //# 64 <= x < 80 > +#define AMDGPU_GFX1153_RANGE 0x50, 0xC0 //# 80 <= x < 192 > #define AMDGPU_GFX1200_RANGE 0x01, 0xFF //# 01 <= x < 255 > > #define AMDGPU_EXPAND_FIX(x) x > @@ -177,6 +178,7 @@ > #define ASICREV_IS_GFX1150(r) ASICREV_IS(r, GFX1150) > #define ASICREV_IS_GFX1151(r) ASICREV_IS(r, GFX1151) > #define ASICREV_IS_GFX1152(r) ASICREV_IS(r, GFX1152) > +#define ASICREV_IS_GFX1153(r) ASICREV_IS(r, GFX1153) > #define ASICREV_IS_GFX1200(r) ASICREV_IS(r, GFX1200) > > #endif // _AMDGPU_ASIC_ADDR_H