From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 522848929C for ; Mon, 8 Apr 2019 16:25:16 +0000 (UTC) References: <20190408161533.2421-1-andi.shyti@intel.com> <20190408161533.2421-5-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: Date: Mon, 8 Apr 2019 17:25:13 +0100 MIME-Version: 1.0 In-Reply-To: <20190408161533.2421-5-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v19 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDA4LzA0LzIwMTkgMTc6MTUsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gRW5naW5lcyByZWZlcnJl ZCBieSBjbGFzcyBhbmQgaW5zdGFuY2UgYXJlIGdldHRpbmcgbW9yZSBwb3B1bGFyZSwKPiBnZW1f ZW5naW5lX2Nhbl9zdG9yZV9kd29yZCgpIHNob3VsZCBoYW5kbGUgdGhlIHNpdHVhdGlvbi4KPiAK PiBTdWdnZXN0ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogQW5kaSBTaHl0aSA8YW5kaS5zaHl0aUBpbnRlbC5jb20+Cj4gLS0t Cj4gICBsaWIvaWd0X2d0LmMgfCAxMSArKysrKysrKy0tLQo+ICAgbGliL2lndF9ndC5oIHwgIDEg Kwo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZ3QuYyBiL2xpYi9pZ3RfZ3QuYwo+IGluZGV4IDhjZDU4 ZjdhZmJmZC4uNWQwYThlODA2MGE3IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZ3QuYwo+ICsrKyBi L2xpYi9pZ3RfZ3QuYwo+IEBAIC01NTcsNyArNTU3LDcgQEAgY29uc3Qgc3RydWN0IGludGVsX2V4 ZWN1dGlvbl9lbmdpbmUgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXNbXSA9IHsKPiAgIAl7IE5VTEws IDAsIDAgfQo+ICAgfTsKPiAgIAo+IC1ib29sIGdlbV9jYW5fc3RvcmVfZHdvcmQoaW50IGZkLCB1 bnNpZ25lZCBpbnQgZW5naW5lKQo+ICtib29sIGdlbV9jbGFzc19jYW5fc3RvcmVfZHdvcmQoaW50 IGZkLCBpbnQgY2xhc3MpCj4gICB7Cj4gICAJdWludDE2X3QgZGV2aWQgPSBpbnRlbF9nZXRfZHJt X2RldmlkKGZkKTsKPiAgIAljb25zdCBzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gKmluZm8gPSBp bnRlbF9nZXRfZGV2aWNlX2luZm8oZGV2aWQpOwo+IEBAIC01NjksOCArNTY5LDggQEAgYm9vbCBn ZW1fY2FuX3N0b3JlX2R3b3JkKGludCBmZCwgdW5zaWduZWQgaW50IGVuZ2luZSkKPiAgIAlpZiAo Z2VuID09IDMgJiYgKGluZm8tPmlzX2dyYW50c2RhbGUgfHwgaW5mby0+aXNfYWx2aXNvKSkKPiAg IAkJcmV0dXJuIGZhbHNlOyAvKiBvbmx5IHN1cHBvcnRzIHBoeXNpY2FsIGFkZHJlc3NlcyAqLwo+ ICAgCj4gLQlpZiAoZ2VuID09IDYgJiYgKChlbmdpbmUgJiAweDNmKSA9PSBJOTE1X0VYRUNfQlNE KSkKPiAtCQlyZXR1cm4gZmFsc2U7IC8qIGtpbGxzIHRoZSBtYWNoaW5lISAqLwo+ICsJaWYgKGdl biA9PSA2ICYmIGNsYXNzID09IEk5MTVfRU5HSU5FX0NMQVNTX1ZJREVPKQo+ICsJCXJldHVybiBm YWxzZTsKPiAgIAo+ICAgCWlmIChpbmZvLT5pc19icm9hZHdhdGVyKQo+ICAgCQlyZXR1cm4gZmFs c2U7IC8qIE5vdCBzdXJlIHlldC4uLiAqLwo+IEBAIC01NzgsNiArNTc4LDExIEBAIGJvb2wgZ2Vt X2Nhbl9zdG9yZV9kd29yZChpbnQgZmQsIHVuc2lnbmVkIGludCBlbmdpbmUpCj4gICAJcmV0dXJu IHRydWU7Cj4gICB9Cj4gICAKPiArYm9vbCBnZW1fY2FuX3N0b3JlX2R3b3JkKGludCBmZCwgdW5z aWduZWQgaW50IGVuZ2luZSkKPiArewo+ICsJcmV0dXJuIGdlbV9jbGFzc19jYW5fc3RvcmVfZHdv cmQoZmQsIGdlbV9lYl90b19jbGFzcyhlbmdpbmUpKTsKPiArfQo+ICsKPiAgIGNvbnN0IHN0cnVj dCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiBpbnRlbF9leGVjdXRpb25fZW5naW5lczJbXSA9IHsK PiAgIAl7ICJyY3MwIiwgSTkxNV9FTkdJTkVfQ0xBU1NfUkVOREVSLCAwIH0sCj4gICAJeyAiYmNz MCIsIEk5MTVfRU5HSU5FX0NMQVNTX0NPUFksIDAgfSwKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9n dC5oIGIvbGliL2lndF9ndC5oCj4gaW5kZXggYjEzMDYyZWY3ZDMzLi5hZjRjYzM4YTFlZjcgMTAw NjQ0Cj4gLS0tIGEvbGliL2lndF9ndC5oCj4gKysrIGIvbGliL2lndF9ndC5oCj4gQEAgLTkwLDYg KzkwLDcgQEAgYm9vbCBnZW1fcmluZ19pc19waHlzaWNhbF9lbmdpbmUoaW50IGZkLCB1bnNpZ25l ZCBpbnQgcmluZyk7Cj4gICBib29sIGdlbV9yaW5nX2hhc19waHlzaWNhbF9lbmdpbmUoaW50IGZk LCB1bnNpZ25lZCBpbnQgcmluZyk7Cj4gICAKPiAgIGJvb2wgZ2VtX2Nhbl9zdG9yZV9kd29yZChp bnQgZmQsIHVuc2lnbmVkIGludCBlbmdpbmUpOwo+ICtib29sIGdlbV9jbGFzc19jYW5fc3RvcmVf ZHdvcmQoaW50IGZkLCBpbnQgY2xhc3MpOwo+ICAgCj4gICBleHRlcm4gY29uc3Qgc3RydWN0IGlu dGVsX2V4ZWN1dGlvbl9lbmdpbmUyIHsKPiAgIAljb25zdCBjaGFyICpuYW1lOwo+IAoKUmV2aWV3 ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRz LAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==