From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "karthik.b.s@intel.com" <karthik.b.s@intel.com>,
"swati2.sharma@intel.com" <swati2.sharma@intel.com>,
"jani.nikula@intel.com" <jani.nikula@intel.com>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"gildekel@google.com" <gildekel@google.com>,
"navaremanasi@google.com" <navaremanasi@google.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Paul-pl Chen (陳柏霖)" <Paul-pl.Chen@mediatek.com>,
"kamil.konieczny@linux.intel.com"
<kamil.konieczny@linux.intel.com>,
"Lancelot Wu (吳瑋晟)" <Lancelot.Wu@mediatek.com>,
"fshao@chromium.org" <fshao@chromium.org>,
"markyacoub@chromium.org" <markyacoub@chromium.org>
Subject: Re: [PATCH i-g-t v3 2/2] tests/kms_setmode: Add basic-no-cpu-idle subtest
Date: Tue, 14 Jul 2026 07:55:31 +0000 [thread overview]
Message-ID: <b77c9195d446be40ef2ba7494950b08e81f3f565.camel@mediatek.com> (raw)
In-Reply-To: <20260713121159.dyctydohvvtmyrfn@kamilkon-DESK.igk.intel.com>
[snip]
> > +
> > + igt_require_f(igt_pm_disable_cpu_deep_sleep(),
> > + "Platform does not support CPU idle
> > control\n");
>
> Maybe return an int idicating how many CPUs entered non-idle
> state. This require also shows that igt_warn() in lib is not
> needed, imho remove any igt_info()/igt_warn() from a lib
> function.
OK, I'll change their return to int and remove all the
igt_info()/igt_warn() inside.
Regards
Jason-JH Lin
>
> Regards,
> Kamil
next prev parent reply other threads:[~2026-07-14 7:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 9:52 [PATCH i-g-t v3 0/2] Add CPU idle state control for accurate vblank timing Jason-JH Lin
2026-07-10 9:52 ` [PATCH i-g-t v3 1/2] lib/igt_pm: Add CPU idle state control for vblank timing stability Jason-JH Lin
2026-07-13 12:08 ` Kamil Konieczny
2026-07-14 7:53 ` Jason-JH Lin (林睿祥)
2026-07-14 16:37 ` Kamil Konieczny
2026-07-15 2:50 ` Jason-JH Lin (林睿祥)
2026-07-10 9:52 ` [PATCH i-g-t v3 2/2] tests/kms_setmode: Add basic-no-cpu-idle subtest Jason-JH Lin
2026-07-13 12:11 ` Kamil Konieczny
2026-07-14 7:55 ` Jason-JH Lin (林睿祥) [this message]
2026-07-10 10:37 ` ✓ Xe.CI.BAT: success for Add CPU idle state control for accurate vblank timing Patchwork
2026-07-10 10:49 ` ✓ i915.CI.BAT: " Patchwork
2026-07-10 18:55 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-07-11 13:42 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b77c9195d446be40ef2ba7494950b08e81f3f565.camel@mediatek.com \
--to=jason-jh.lin@mediatek.com \
--cc=Lancelot.Wu@mediatek.com \
--cc=Paul-pl.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=fshao@chromium.org \
--cc=gildekel@google.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=karthik.b.s@intel.com \
--cc=markyacoub@chromium.org \
--cc=navaremanasi@google.com \
--cc=swati2.sharma@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox