From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F78F89C6C for ; Wed, 5 Sep 2018 17:09:28 +0000 (UTC) From: "Pandiyan, Dhinakaran" Date: Wed, 5 Sep 2018 17:09:26 +0000 Message-ID: References: <20180829215713.20962-1-dhinakaran.pandiyan@intel.com> In-Reply-To: Content-Language: en-US Content-ID: <4023C2295E26EC4EAE99ACAD87DC68C2@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/6] lib/psr: Add support for toggling edp psr through debugfs, v5. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Souza, Jose" Cc: "Vivi, Rodrigo" List-ID: T24gVHVlLCAyMDE4LTA5LTA0IGF0IDE0OjU5IC0wNzAwLCBTb3V6YSwgSm9zZSB3cm90ZToNCj4g T24gV2VkLCAyMDE4LTA4LTI5IGF0IDE0OjU3IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy b3RlOg0KPiA+IEZyb206IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51 eC5pbnRlbC5jb20+DQo+ID4gDQo+ID4gSXQncyBoYXJtZnVsIHRvIHdyaXRlIHRvIGVuYWJsZV9w c3IgYXQgcnVudGltZSwgYW5kIHRoZSBwYXRjaCB0aGF0DQo+ID4gYWxsb3dzDQo+ID4gdXMgdG8g Y2hhbmdlIGk5MTVfZWRwX3Bzcl9kZWJ1ZyB3aXRoIHRoZSBwYW5lbCBydW5uaW5nIHdpbGwgcmVx dWlyZQ0KPiA+IHVzDQo+ID4gdG8gYWJhbmRvbiB0aGUgbW9kdWxlIHBhcmFtZXRlci4gSGVuY2Ug dGhlIHVzZXJzcGFjZSBjaGFuZ2UgbmVlZHMNCj4gPiB0bw0KPiA+IGJlDQo+ID4gcHV0IGluIElH VCBmaXJzdCBiZWZvcmUgd2UgY2FuIGNoYW5nZSBpdCBhdCBrZXJuZWwgdGltZS4NCj4gPiANCj4g PiBUb2dnbGluZyBpdCB0byBkZWJ1Z2ZzIHdpbGwgbWVhbiB3ZSBjYW4gc2tpcCBhIG1vZGVzZXQg d2hlbg0KPiA+IGNoYW5naW5nDQo+ID4gb3VyDQo+ID4gZmVhdHVyZSBzZXQuDQo+ID4gDQo+ID4g Q2hhbmdlcyBzaW5jZSB2MToNCj4gPiAtIFJlYmFzZSB3aXRoIHRoZSBwcmV2aW91cyBwYXRjaGVz IGRyb3BwZWQuDQo+ID4gQ2hhbmdlcyBzaW5jZSB2MjoNCj4gPiAtIFJlYmFzZSBvbiB0b3Agb2Yg bmV3IGFwaSBpbiBpOTE1X2VkcF9wc3JfZGVidWcuDQo+ID4gQ2hhbmdlcyBzaW5jZSB2MzoNCj4g PiAtIEVuYWJsZSBJUlEgZGVidWdnaW5nIGZvciBleHRyYSBsb2dnaW5nLg0KPiA+IC0gRm9yY2Ug UFNSMSBtb2RlLiAoZGhua3JuKQ0KPiA+IC0gTW92ZSBQU1IgZW5hYmxlL2Rpc2FibGUgZnVuY3Rp b25zIHRvIGxpYi9pZ3RfcHNyLiAoZGhua3JuKQ0KPiA+IENoYW5nZXMgc2luY2UgdjQ6DQo+ID4g LSBSZWRpc2FibGUgaXJxcyByaWdodCBhd2F5IHdoZW4gZGVidWdmcyBhcGkgZG9lc24ndCB3b3Jr LiAoZGhua3JuKQ0KPiA+IC0gVXNlIGhleCBldmVyeXdoZXJlLiAoZGhua3JuKQ0KPiA+IA0KPiA+ IFJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGlu dGVsLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5s YW5raG9yc3RAbGludXguaW50ZWwuY29tDQo+ID4gPg0KPiA+IC0tLQ0KPiA+ICBsaWIvaWd0X3Bz ci5jICAgICAgICAgICAgICAgICAgICB8IDg2DQo+ID4gKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrLQ0KPiA+ICBsaWIvaWd0X3Bzci5oICAgICAgICAgICAgICAgICAgICB8 ICAyICsNCj4gPiAgdGVzdHMva21zX2Zyb250YnVmZmVyX3RyYWNraW5nLmMgfCAgNiArLS0NCj4g PiAgMyBmaWxlcyBjaGFuZ2VkLCA4OSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQ0KPiA+ IA0KPiA+IGRpZmYgLS1naXQgYS9saWIvaWd0X3Bzci5jIGIvbGliL2lndF9wc3IuYw0KPiA+IGlu ZGV4IGM5NzliMGI1Li42MTRjYWE2ZiAxMDA2NDQNCj4gPiAtLS0gYS9saWIvaWd0X3Bzci5jDQo+ ID4gKysrIGIvbGliL2lndF9wc3IuYw0KPiA+IEBAIC0yMSw3ICsyMSw5IEBADQo+ID4gICAqIElO IFRIRSBTT0ZUV0FSRS4NCj4gPiAgICovDQo+ID4gIA0KPiA+IC0jaW5jbHVkZSAgImlndF9wc3Iu aCINCj4gPiArI2luY2x1ZGUgImlndF9wc3IuaCINCj4gPiArI2luY2x1ZGUgImlndF9zeXNmcy5o Ig0KPiA+ICsjaW5jbHVkZSA8ZXJybm8uaD4NCj4gPiAgDQo+ID4gIGJvb2wgcHNyX2FjdGl2ZShp bnQgZmQsIGJvb2wgY2hlY2tfYWN0aXZlKQ0KPiA+ICB7DQo+ID4gQEAgLTM4LDMgKzQwLDg1IEBA IGJvb2wgcHNyX3dhaXRfZW50cnkoaW50IGZkKQ0KPiA+ICB7DQo+ID4gIAlyZXR1cm4gaWd0X3dh aXQocHNyX2FjdGl2ZShmZCwgdHJ1ZSksIDUwMCwgMSk7DQo+ID4gIH0NCj4gPiArDQo+ID4gK3N0 YXRpYyBzc2l6ZV90IHBzcl93cml0ZShpbnQgZmQsIGNvbnN0IGNoYXIgKmJ1ZikNCj4gPiArew0K PiA+ICsJcmV0dXJuIGlndF9zeXNmc193cml0ZShmZCwgImk5MTVfZWRwX3Bzcl9kZWJ1ZyIsIGJ1 ZiwNCj4gPiBzdHJsZW4oYnVmKSk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgaGFz X3Bzcl9kZWJ1Z2ZzKGludCBmZCkNCj4gPiArew0KPiA+ICsJaW50IHJldDsNCj4gPiArDQo+ID4g KwkvKg0KPiA+ICsJICogQ2hlY2sgaWYgbmV3IFBTUiBkZWJ1Z2ZzIGFwaSBpcyB1c2FibGUgYnkg d3JpdGluZyBhbg0KPiA+IGludmFsaWQNCj4gPiB2YWx1ZS4NCj4gPiArCSAqIExlZ2FjeSBtb2Rl IHdpbGwgcmV0dXJuIE9LIGhlcmUsIGRlYnVnZnMgYXBpIHdpbGwNCj4gPiByZXR1cm4NCj4gPiAt RUlOVkFMLg0KPiA+ICsJICogLUVOT0RFViBpcyByZXR1cm5lZC4NCj4gPiArCSAqLw0KPiA+ICsJ cmV0ID0gcHNyX3dyaXRlKGZkLCAiMHhmIik7DQo+ID4gKwlpZiAocmV0ID09IC1FSU5WQUwpDQo+ ID4gKwkJcmV0dXJuIDA7DQo+ID4gKwllbHNlIGlmIChyZXQgPCAwKQ0KPiA+ICsJCXJldHVybiBy ZXQ7DQo+ID4gKw0KPiA+ICsJLyogbGVnYWN5IGRlYnVnZnMgYXBpLCB3ZSBlbmFibGVkIGlycXMg Ynkgd3JpdGluZywgZGlzYWJsZQ0KPiA+IHRoZW0uICovDQo+ID4gKwlwc3Jfd3JpdGUoZmQsICIw Iik7DQo+ID4gKwlyZXR1cm4gLUVJTlZBTDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGJv b2wgcHNyX21vZHBhcmFtX3NldChpbnQgdmFsKQ0KPiA+ICt7DQo+ID4gKwlzdGF0aWMgaW50IG9s ZHZhbCA9IC0xOw0KPiANCj4gVGhpcyBsb29rcyB3cm9uZywgd2h5IG5vdCByZWFkIHRoZSBtb2R1 bGUgcGFyYW1ldGVyPyBpdCB3aWxsIGd1YXJhdGVlDQo+IHRoYXQgdGhlIHJldHVybmVkIHZhbHVl IGlzIGNvcnJlY3QgaGVyZSBpZiBzb21ldGhpbmcgZWxzZSBsZWZ0IHRoZQ0KPiBwYXJhbWV0ZXIg d2l0aCBhbm90aGVyIHZhbHVlLg0KPiANClRoaXMgcGF0Y2ggd2FzIG1lcmdlZCBhcyBwYXJ0IG9m IGEgZGlmZmVyZW50IHNlcmllcywgc2VuZCBhIGZpeCBhbmQgQ2MNCk1hYXJ0ZW4/DQo+IA0KPiA+ ICsNCj4gPiArCWlndF9zZXRfbW9kdWxlX3BhcmFtX2ludCgiZW5hYmxlX3BzciIsIHZhbCk7DQo+ ID4gKw0KPiA+ICsJaWYgKHZhbCA9PSBvbGR2YWwpDQo+ID4gKwkJcmV0dXJuIGZhbHNlOw0KPiA+ ICsNCj4gPiArCW9sZHZhbCA9IHZhbDsNCj4gPiArCXJldHVybiB0cnVlOw0KPiA+ICt9DQo+ID4g Kw0KPiA+ICtzdGF0aWMgaW50IHBzcl9yZXN0b3JlX2RlYnVnZnNfZmQgPSAtMTsNCj4gDQo+IE1h eWJlIG1vdmUgdGhpcyB0byB0aGUgdG9wIG9mIHRoZSBmaWxlLg0KPiANCj4gT3RoZXIgdGhhbiB0 aGF0IExHVE0uDQo+IA0KPiA+ICsNCj4gPiArc3RhdGljIHZvaWQgcmVzdG9yZV9wc3JfZGVidWdm cyhpbnQgc2lnKQ0KPiA+ICt7DQo+ID4gKwlwc3Jfd3JpdGUocHNyX3Jlc3RvcmVfZGVidWdmc19m ZCwgIjAiKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGJvb2wgcHNyX3NldChpbnQgZmQs IGJvb2wgZW5hYmxlKQ0KPiA+ICt7DQo+ID4gKwlpbnQgcmV0Ow0KPiA+ICsNCj4gPiArCXJldCA9 IGhhc19wc3JfZGVidWdmcyhmZCk7DQo+ID4gKwlpZiAocmV0ID09IC1FTk9ERVYpIHsNCj4gPiAr CQlpZ3Rfc2tpcF9vbl9mKGVuYWJsZSwgIlBTUiBub3QgYXZhaWxhYmxlXG4iKTsNCj4gPiArCQly ZXR1cm4gZmFsc2U7DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICsJaWYgKHJldCA9PSAtRUlOVkFMKSB7 DQo+ID4gKwkJcmV0ID0gcHNyX21vZHBhcmFtX3NldChlbmFibGUpOw0KPiA+ICsJfSBlbHNlIHsN Cj4gPiArCQlyZXQgPSBwc3Jfd3JpdGUoZmQsIGVuYWJsZSA/ICIweDMiIDogIjB4MSIpOw0KPiA+ ICsJCWlndF9hc3NlcnQocmV0ID4gMCk7DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICsJLyogUmVzdG9y ZSBvcmlnaW5hbCB2YWx1ZSBvbiBleGl0ICovDQo+ID4gKwlpZiAocHNyX3Jlc3RvcmVfZGVidWdm c19mZCA9PSAtMSkgew0KPiA+ICsJCXBzcl9yZXN0b3JlX2RlYnVnZnNfZmQgPSBkdXAoZmQpOw0K PiA+ICsJCWlndF9hc3NlcnQocHNyX3Jlc3RvcmVfZGVidWdmc19mZCA+PSAwKTsNCj4gPiArCQlp Z3RfaW5zdGFsbF9leGl0X2hhbmRsZXIocmVzdG9yZV9wc3JfZGVidWdmcyk7DQo+ID4gKwl9DQo+ ID4gKw0KPiA+ICsJcmV0dXJuIHJldDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArYm9vbCBwc3JfZW5h YmxlKGludCBmZCkNCj4gPiArew0KPiA+ICsJcmV0dXJuIHBzcl9zZXQoZmQsIHRydWUpOw0KPiA+ ICt9DQo+ID4gKw0KPiA+ICtib29sIHBzcl9kaXNhYmxlKGludCBmZCkNCj4gPiArew0KPiA+ICsJ cmV0dXJuIHBzcl9zZXQoZmQsIGZhbHNlKTsNCj4gPiArfQ0KPiA+IGRpZmYgLS1naXQgYS9saWIv aWd0X3Bzci5oIGIvbGliL2lndF9wc3IuaA0KPiA+IGluZGV4IDk4MGY4NWUwLi4wZWYyMmMzZCAx MDA2NDQNCj4gPiAtLS0gYS9saWIvaWd0X3Bzci5oDQo+ID4gKysrIGIvbGliL2lndF9wc3IuaA0K PiA+IEBAIC0zMCw1ICszMCw3IEBADQo+ID4gIA0KPiA+ICBib29sIHBzcl93YWl0X2VudHJ5KGlu dCBmZCk7DQo+ID4gIGJvb2wgcHNyX2FjdGl2ZShpbnQgZmQsIGJvb2wgY2hlY2tfYWN0aXZlKTsN Cj4gPiArYm9vbCBwc3JfZW5hYmxlKGludCBmZCk7DQo+ID4gK2Jvb2wgcHNyX2Rpc2FibGUoaW50 IGZkKTsNCj4gPiAgDQo+ID4gICNlbmRpZg0KPiA+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfZnJv bnRidWZmZXJfdHJhY2tpbmcuYw0KPiA+IGIvdGVzdHMva21zX2Zyb250YnVmZmVyX3RyYWNraW5n LmMNCj4gPiBpbmRleCAxZGZkN2MxYy4uN2VhMmY2OTcgMTAwNjQ0DQo+ID4gLS0tIGEvdGVzdHMv a21zX2Zyb250YnVmZmVyX3RyYWNraW5nLmMNCj4gPiArKysgYi90ZXN0cy9rbXNfZnJvbnRidWZm ZXJfdHJhY2tpbmcuYw0KPiA+IEBAIC05NDEsOCArOTQxLDYgQEAgc3RhdGljIGJvb2wNCj4gPiBk cnJzX3dhaXRfdW50aWxfcnJfc3dpdGNoX3RvX2xvdyh2b2lkKQ0KPiA+ICANCj4gPiAgI2RlZmlu ZSBmYmNfZW5hYmxlKCkgaWd0X3NldF9tb2R1bGVfcGFyYW1faW50KCJlbmFibGVfZmJjIiwgMSkN Cj4gPiAgI2RlZmluZSBmYmNfZGlzYWJsZSgpIGlndF9zZXRfbW9kdWxlX3BhcmFtX2ludCgiZW5h YmxlX2ZiYyIsIDApDQo+ID4gLSNkZWZpbmUgcHNyX2VuYWJsZSgpIGlndF9zZXRfbW9kdWxlX3Bh cmFtX2ludCgiZW5hYmxlX3BzciIsIDEpDQo+ID4gLSNkZWZpbmUgcHNyX2Rpc2FibGUoKSBpZ3Rf c2V0X21vZHVsZV9wYXJhbV9pbnQoImVuYWJsZV9wc3IiLCAwKQ0KPiA+ICAjZGVmaW5lIGRycnNf ZW5hYmxlKCkJZHJyc19zZXQoMSkNCj4gPiAgI2RlZmluZSBkcnJzX2Rpc2FibGUoKQlkcnJzX3Nl dCgwKQ0KPiA+ICANCj4gPiBAQCAtMTEzNyw3ICsxMTM1LDcgQEAgc3RhdGljIHZvaWQgZGlzYWJs ZV9mZWF0dXJlcyhjb25zdCBzdHJ1Y3QNCj4gPiB0ZXN0X21vZGUgKnQpDQo+ID4gIAkJcmV0dXJu Ow0KPiA+ICANCj4gPiAgCWZiY19kaXNhYmxlKCk7DQo+ID4gLQlwc3JfZGlzYWJsZSgpOw0KPiA+ ICsJcHNyX2Rpc2FibGUoZHJtLmRlYnVnZnMpOw0KPiA+ICAJZHJyc19kaXNhYmxlKCk7DQo+ID4g IH0NCj4gPiAgDQo+ID4gQEAgLTE3MTksNyArMTcxNyw3IEBAIHN0YXRpYyB2b2lkIGVuYWJsZV9m ZWF0dXJlc19mb3JfdGVzdChjb25zdA0KPiA+IHN0cnVjdCB0ZXN0X21vZGUgKnQpDQo+ID4gIAlp ZiAodC0+ZmVhdHVyZSAmIEZFQVRVUkVfRkJDKQ0KPiA+ICAJCWZiY19lbmFibGUoKTsNCj4gPiAg CWlmICh0LT5mZWF0dXJlICYgRkVBVFVSRV9QU1IpDQo+ID4gLQkJcHNyX2VuYWJsZSgpOw0KPiA+ ICsJCXBzcl9lbmFibGUoZHJtLmRlYnVnZnMpOw0KPiA+ICAJaWYgKHQtPmZlYXR1cmUgJiBGRUFU VVJFX0RSUlMpDQo+ID4gIAkJZHJyc19lbmFibGUoKTsNCj4gPiAgfQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3Qt ZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK