Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Pranay Samala <pranay.samala@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <karthik.b.s@intel.com>, <sameer.lattannavar@intel.com>
Subject: Re: [PATCH i-g-t 1/2] tests/kms_flip.c: Updating the skip message
Date: Tue, 22 Oct 2024 01:52:00 +0530	[thread overview]
Message-ID: <b8287182-1717-4e2f-9109-e43cbc546056@intel.com> (raw)
In-Reply-To: <20241015171849.1733664-1-pranay.samala@intel.com>

Hi Pranay,

Please fix the subject. Imperative mood should be used in subject line. 
For guidance on writing effectivecommitmessages, please refer to 
this10-minute read <https://cbea.ms/git-commit/>.

Also,

s/kms_flip.c/kms_flip

On 15-10-2024 22:48, Pranay Samala wrote:
> Debugging would be easier if we had logs available for
> test failures and skips. This patch rephrases the skip
> message for better understanding.
>
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> ---
>   tests/kms_flip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index cbabbe74f..88cd41083 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags)
>   
>   	/* If we have fewer than 2 connected outputs then we won't have any
>   	 * configuration at all. So skip in that case. */
> -	igt_require_f(modes, "At least two displays required\n");
> +	igt_require_f(modes, "At least two displays with same modes are required\n");
>   
>   	if (duration) {
>   		duration = duration * 1000 / modes;

  parent reply	other threads:[~2024-10-21 20:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 17:18 [PATCH i-g-t 1/2] tests/kms_flip.c: Updating the skip message Pranay Samala
2024-10-15 17:18 ` [PATCH i-g-t 2/2] HAX: Do not merge Pranay Samala
2024-10-15 22:13 ` ✗ CI.xeBAT: failure for series starting with [i-g-t,1/2] tests/kms_flip.c: Updating the skip message Patchwork
2024-10-15 22:21 ` ✗ Fi.CI.BAT: " Patchwork
2024-10-16 10:28 ` ✗ CI.xeFULL: " Patchwork
2024-10-17  8:53 ` [PATCH i-g-t 1/2] " Naladala, Ramanaidu
2024-10-21 11:14 ` ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] " Patchwork
2024-10-21 13:40 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-21 15:51 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-21 20:22 ` Sharma, Swati2 [this message]
2024-11-07 13:26 ` [PATCH i-g-t 1/2] " Naladala, Ramanaidu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8287182-1717-4e2f-9109-e43cbc546056@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=pranay.samala@intel.com \
    --cc=sameer.lattannavar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox