public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>, igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
	eben@raspberrypi.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t v4 09/14] igt: fb: Clear YUV dumb buffers
Date: Tue, 22 Jan 2019 16:48:16 +0100	[thread overview]
Message-ID: <b86a88a0e2a20ed3280223b2d3d08ea406c6b865.camel@bootlin.com> (raw)
In-Reply-To: <20190122142844.20899-10-maxime.ripard@bootlin.com>

Hi,

On Tue, 2019-01-22 at 15:28 +0100, Maxime Ripard wrote:
> YUV dumb buffers, just like i915 GEM buffers also need to be cleared once
> allocated. Make sure it happens.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> ---
>  lib/igt_fb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 490563c0ea4b..4becbb4dbc08 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -582,6 +582,9 @@ static int create_bo_for_fb(struct igt_fb *fb)
>  	fb->gem_handle = kmstest_dumb_create(fd, fb->width, fb->height,
>  					     bpp, strides, &fb->size);
>  
> +	if (igt_format_is_yuv(fb->drm_format))
> +		clear_yuv_buffer(fb);
> +
>  	return fb->gem_handle;
>  }
>  
-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-01-22 15:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 14:28 [igt-dev] [PATCH i-g-t v4 00/14] igt: chamelium: Test YUV buffers using the Chamelium Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 01/14] igt: fb: Add subsampling parameters to the formats Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 02/14] igt: fb: Reduce tile size alignment for non intel platforms Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 03/14] igt: fb: generic YUV convertion function Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 04/14] igt: fb: Move i915 YUV buffer clearing code to a function Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 05/14] igt: fb: Move size computation to the common path Maxime Ripard
2019-01-22 15:46   ` Paul Kocialkowski
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 06/14] igt: fb: Refactor dumb buffer allocation path Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 07/14] igt: fb: Account for all planes bpp Maxime Ripard
2019-01-22 15:46   ` Paul Kocialkowski
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 08/14] igt: fb: Don't pass the stride when allocating a dumb, multi-planar buffer Maxime Ripard
2019-01-22 15:48   ` Paul Kocialkowski
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 09/14] igt: fb: Clear YUV dumb buffers Maxime Ripard
2019-01-22 15:48   ` Paul Kocialkowski [this message]
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 10/14] igt: fb: Rework YUV i915 allocation path Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 11/14] igt: fb: Add a bunch of new YUV formats Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 12/14] igt: tests: chamelium: Start to unify tests Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 13/14] igt: tests: chamelium: Convert VGA tests to do_test_display Maxime Ripard
2019-01-22 14:28 ` [igt-dev] [PATCH i-g-t v4 14/14] igt: tests: chamelium: Add YUV formats tests Maxime Ripard
2019-01-22 14:52 ` [igt-dev] ✓ Fi.CI.BAT: success for igt: chamelium: Test YUV buffers using the Chamelium (rev6) Patchwork
2019-01-22 17:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b86a88a0e2a20ed3280223b2d3d08ea406c6b865.camel@bootlin.com \
    --to=paul.kocialkowski@bootlin.com \
    --cc=eben@raspberrypi.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=petri.latvala@intel.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox