Re: [PATCH i-g-t, v2 6/9] tests/kms_sharpness_filter: Add dpms/suspend subtests

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 12/31/2024 6:32 PM, Swati Sharma wrote:
> Add subtests to verify CASF with DPMS and suspend.
>
> v2: -Added CRC based verification (Ankit)
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   tests/kms_sharpness_filter.c | 67 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 67 insertions(+)
>
> diff --git a/tests/kms_sharpness_filter.c b/tests/kms_sharpness_filter.c
> index d1d6558c5..32ad7a752 100644
> --- a/tests/kms_sharpness_filter.c
> +++ b/tests/kms_sharpness_filter.c
> @@ -41,6 +41,14 @@
>    * SUBTEST: filter-tap
>    * Description: Verify content adaptive sharpness filter with resolution change, resolution change
>    * 		will lead to selection of distinct taps.
> + *
> + * SUBTEST: filter-dpms
> + * Description: Verify content adaptive sharpness filter with DPMS.
> + * Functionality: casf, dpms
> + *
> + * SUBTEST: filter-suspend
> + * Description: Verify content adaptive sharpness filter with suspend.
> + * Functionality: casf, suspend
>   */
>   
>   IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
> @@ -70,6 +78,8 @@ enum test_type {
>   	TEST_FILTER_STRENGTH,
>   	TEST_FILTER_TOGGLE,
>   	TEST_FILTER_TAP,
> +	TEST_FILTER_DPMS,
> +	TEST_FILTER_SUSPEND,
>   };
>   
>   const int filter_strength_list[] = {
> @@ -212,9 +222,12 @@ static int test_filter_toggle(data_t *data)
>   
>   static void test_sharpness_filter(data_t *data,  enum test_type type)
>   {
> +	igt_output_t *output = data->output;
>   	drmModeModeInfo *mode = data->mode;
>   	int height = mode->hdisplay;
>   	int width =  mode->vdisplay;
> +	igt_crc_t ref_crc, crc;
> +	igt_pipe_crc_t *pipe_crc = NULL;
>   	int ret;
>   
>   	data->plane[0] = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY);
> @@ -238,11 +251,37 @@ static void test_sharpness_filter(data_t *data,  enum test_type type)
>   
>   	ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
>   
> +	if (type == TEST_FILTER_DPMS || type == TEST_FILTER_SUSPEND) {
> +		pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe_id,
> +					    IGT_PIPE_CRC_SOURCE_AUTO);
> +		igt_pipe_crc_collect_crc(pipe_crc, &ref_crc);
> +	}
> +
> +	if (type == TEST_FILTER_DPMS) {
> +		kmstest_set_connector_dpms(data->drm_fd,
> +					   output->config.connector,
> +					   DRM_MODE_DPMS_OFF);
> +		kmstest_set_connector_dpms(data->drm_fd,
> +					   output->config.connector,
> +					   DRM_MODE_DPMS_ON);
> +	}
> +
> +	if (type == TEST_FILTER_SUSPEND)
> +		igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> +					      SUSPEND_TEST_NONE);
> +
> +	if (type == TEST_FILTER_DPMS || type == TEST_FILTER_SUSPEND) {
> +		igt_pipe_crc_collect_crc(pipe_crc, &crc);
> +		igt_assert_crc_equal(&crc, &ref_crc);
> +	}
> +
>   	if (type == TEST_FILTER_TOGGLE)
>   		ret |= test_filter_toggle(data);
>   
>   	igt_assert_eq(ret, 0);
>   
> +	/* clean-up */
> +	igt_pipe_crc_free(pipe_crc);
>   	cleanup(data);
>   }
>   
> @@ -328,6 +367,12 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
>   			case TEST_FILTER_TOGGLE:
>   				snprintf(name, sizeof(name), "-toggle");
>   				break;
> +			case TEST_FILTER_DPMS:
> +				snprintf(name, sizeof(name), "-dpms");
> +				break;
> +			case TEST_FILTER_SUSPEND:
> +				snprintf(name, sizeof(name), "-suspend");
> +				break;
>   			default:
>   				igt_assert(0);
>   			}
> @@ -462,6 +507,28 @@ igt_main_args("l", NULL, help_str, opt_handler, &data)
>   		run_sharpness_filter_test(&data, TEST_FILTER_TAP);
>   	}
>   
> +	igt_describe("Verify content adaptive sharpness filter "
> +		     "with DPMS.");
> +	igt_subtest_with_dynamic("filter-dpms") {
> +		data.modifier = DRM_FORMAT_MOD_LINEAR;
> +		data.rotation = IGT_ROTATION_0;
> +		data.format = DRM_FORMAT_XRGB8888;
> +		data.filter_strength = MID_FILTER_STRENGTH;
> +
> +		run_sharpness_filter_test(&data, TEST_FILTER_DPMS);
> +	}
> +
> +	igt_describe("Verify content adaptive sharpness filter "
> +		     "with suspend.");
> +	igt_subtest_with_dynamic("filter-suspend") {
> +		data.modifier = DRM_FORMAT_MOD_LINEAR;
> +		data.rotation = IGT_ROTATION_0;
> +		data.format = DRM_FORMAT_XRGB8888;
> +		data.filter_strength = MID_FILTER_STRENGTH;
> +
> +		run_sharpness_filter_test(&data, TEST_FILTER_SUSPEND);
> +	}
> +
>   	igt_fixture {
>   		igt_display_fini(&data.display);
>   		drm_close_driver(data.drm_fd);