From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Mihail.Atanassov@arm.com" <Mihail.Atanassov@arm.com>
Cc: "nd@arm.com" <nd@arm.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: Require an intel card for tests using tiling
Date: Tue, 23 Jul 2019 14:28:15 +0000 [thread overview]
Message-ID: <b8e678f6e446f97d8040cb02e4dd96013818cbb8.camel@intel.com> (raw)
In-Reply-To: <20190723142202.10067-1-mihail.atanassov@arm.com>
On Tue, 2019-07-23 at 14:22 +0000, Mihail Atanassov wrote:
> Not skipping the affected tests causes all the rest to fail on
> non-Intel drivers.
>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
LGTM
Reviewed-by: Simon Ser <simon.ser@intel.com>
And pushed:
To gitlab.freedesktop.org:drm/igt-gpu-tools.git
1a5b48671e08..ab5871ca3a20 master -> master
Thanks!
> ---
> tests/kms_addfb_basic.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 20dfd4f2..666e7165 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -131,6 +131,7 @@ static void invalid_tests(int fd)
> }
>
> igt_subtest("clobberred-modifier") {
> + igt_require_intel(fd);
> f.flags = 0;
> f.modifier[0] = 0;
> gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);
> @@ -302,6 +303,7 @@ static void tiling_tests(int fd)
>
> igt_subtest_group {
> igt_fixture {
> + igt_require_intel(fd);
> tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> DRM_FORMAT_XRGB8888, LOCAL_I915_FORMAT_MOD_X_TILED,
> 1024*4, NULL, NULL, NULL);
> @@ -447,6 +449,7 @@ static void size_tests(int fd)
> }
>
> igt_subtest("bo-too-small-due-to-tiling") {
> + igt_require_intel(fd);
> gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> errno == EINVAL);
> @@ -498,6 +501,7 @@ static void addfb25_tests(int fd)
>
> igt_subtest_group {
> igt_fixture {
> + igt_require_intel(fd);
> gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
> igt_require_fb_modifiers(fd);
> }
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-07-23 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 14:22 [igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: Require an intel card for tests using tiling Mihail Atanassov
2019-07-23 14:28 ` Ser, Simon [this message]
2019-07-23 14:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-07-23 15:08 ` Ser, Simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e678f6e446f97d8040cb02e4dd96013818cbb8.camel@intel.com \
--to=simon.ser@intel.com \
--cc=Mihail.Atanassov@arm.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox