Re: [igt-dev] [PATCH i-g-t 1/9] xe: sync uapi headers

["Grzegorzek, Dominik" <dominik.grzegorzek@intel.com>]

On Fri, 2023-05-26 at 12:37 +0200, Zbigniew Kempczyński wrote:
> On Wed, May 24, 2023 at 04:29:23PM +0200, Dominik Grzegorzek wrote:
> > Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> > ---
> >  include/drm-uapi/xe_drm_tmp.h | 76 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 76 insertions(+)
> >  create mode 100644 include/drm-uapi/xe_drm_tmp.h
> > 
> > diff --git a/include/drm-uapi/xe_drm_tmp.h b/include/drm-uapi/xe_drm_tmp.h
> > new file mode 100644
> > index 000000000..9829cd724
> > --- /dev/null
> > +++ b/include/drm-uapi/xe_drm_tmp.h
> 
> Maybe xe_drm_local.h or xe_drm_staging.h? tmp looks weird imo.

I do not like the name too, just took the exact file from KMD rfc. Will talk with Mika
about renaming it to xe_drm_staging. Ta!
> 
> --
> Zbigniew
> 
> 
> > @@ -0,0 +1,76 @@
> > +#ifndef _UAPI_XE_DRM_TMP_H_
> > +#define _UAPI_XE_DRM_TMP_H_
> > +
> > +#include "xe_drm.h"
> > +
> > +#if defined(__cplusplus)
> > +extern "C" {
> > +#endif
> > +
> > +#define DRM_XE_EUDEBUG_CONNECT			0x5f
> > +
> > +#define DRM_IOCTL_XE_EUDEBUG_CONNECT		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_EUDEBUG_CONNECT, struct drm_xe_eudebug_connect_param)
> > +
> > +/**
> > + * Do a eudebug event read for a debugger connection.
> > + *
> > + * This ioctl is available in debug version 1.
> > + */
> > +#define DRM_XE_EUDEBUG_IOCTL_READ_EVENT _IO('j', 0x0)
> > +
> > +/* XXX: Document events to match their internal counterparts when moved to xe_drm.h */
> > +struct drm_xe_eudebug_event {
> > +	struct xe_user_extension ext;
> > +
> > +	__u32 type;
> > +#define DRM_XE_EUDEBUG_EVENT_NONE     0
> > +#define DRM_XE_EUDEBUG_EVENT_READ     1
> > +#define DRM_XE_EUDEBUG_EVENT_OPEN     2
> > +#define DRM_XE_EUDEBUG_EVENT_VM	      3
> > +#define DRM_XE_EUDEBUG_EVENT_MAX_EVENT DRM_XE_EUDEBUG_EVENT_VM
> > +
> > +	__u32 flags;
> > +#define DRM_XE_EUDEBUG_EVENT_CREATE	(1 << 0)
> > +#define DRM_XE_EUDEBUG_EVENT_DESTROY	(1 << 1)
> > +#define DRM_XE_EUDEBUG_EVENT_STATE_CHANGE (1 << 2)
> > +
> > +	__u64 seqno;
> > +	__u64 size;
> > +} __attribute__((packed));
> > +
> > +struct drm_xe_eudebug_event_client {
> > +	struct drm_xe_eudebug_event base; /* .flags = CREATE/DESTROY */
> > +
> > +	__u64 client_handle; /* This is unique per debug connection */
> > +} __attribute__((packed));
> > +
> > +struct drm_xe_eudebug_event_vm {
> > +	struct drm_xe_eudebug_event base;
> > +
> > +	__u64 client_handle;
> > +	__u64 vm_handle;
> > +} __attribute__((packed));
> > +
> > +/*
> > + * Debugger ABI (ioctl and events) Version History:
> > + * 0 - No debugger available
> > + * 1 - Initial version
> > + */
> > +#define DRM_XE_EUDEBUG_VERSION 1
> > +
> > +struct drm_xe_eudebug_connect_param {
> > +	struct xe_user_extension ext;
> > +
> > +	__u64 pid; /* input: Target process ID */
> > +	__u32 flags;
> > +
> > +	__u32 version; /* output: current ABI (ioctl / events) version */
> > +	__u64 events;  /* input: event types to subscribe to */
> > +	__u64 extensions; /* MBZ */
> > +};
> > +
> > +#if defined(__cplusplus)
> > +}
> > +#endif
> > +
> > +#endif /* _UAPI_XE_DRM_TMP_H_ */
> > -- 
> > 2.34.1
> >