Re: [PATCH i-g-t] tests/kms_vrr: data->switch modes[LOW_RR_MODE] not initialized for lobf test

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Mon, 2024-11-04 at 09:07 +0000, B, Jeevan wrote:
> LGTM
> 
> Reviewed-by: Jeevan B <jeevan.b@intel.com>

Thank you Jeevan for checking my patch. This is now pushed to master.

BR,

Jouni Högander

> 
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander@intel.com>
> > Sent: Thursday, October 31, 2024 5:44 PM
> > To: igt-dev@lists.freedesktop.org
> > Cc: B, Jeevan <jeevan.b@intel.com>; Hogander, Jouni
> > <jouni.hogander@intel.com>
> > Subject: [PATCH i-g-t] tests/kms_vrr: data->switch
> > modes[LOW_RR_MODE]
> > not initialized for lobf test
> > 
> > lobf subtest is using data->switch_modes[LOW_RR_MODE] but not
> > initializing
> > it. Fix this in output_constraint.
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >  tests/kms_vrr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index
> > 36a22eebe..d0db954fa
> > 100644
> > --- a/tests/kms_vrr.c
> > +++ b/tests/kms_vrr.c
> > @@ -923,7 +923,7 @@ static bool output_constraint(data_t *data,
> > igt_output_t *output, uint32_t flags
> >         igt_output_override_mode(output, &data-
> > > switch_modes[HIGH_RR_MODE]);
> > 
> >         /* Search for a low refresh rate mode. */
> > -       if (!(flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS)))
> > +       if (!(flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS |
> > +TEST_LINK_OFF)))
> >                 return true;
> > 
> >         data->switch_modes[LOW_RR_MODE] =
> > low_rr_mode_with_same_res(output, data->range.min);
> > --
> > 2.34.1
>