From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20201117114050.302583-1-tvrtko.ursulin@linux.intel.com> <20201117135918.354284-1-tvrtko.ursulin@linux.intel.com> <160562198607.22621.14513375230209122787@build.alporthouse.com> From: Tvrtko Ursulin Message-ID: Date: Wed, 18 Nov 2020 11:56:02 +0000 MIME-Version: 1.0 In-Reply-To: <160562198607.22621.14513375230209122787@build.alporthouse.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t v2] gem_wsim: Implement device selection List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-ID: On 17/11/2020 14:06, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2020-11-17 13:59:18) >> From: Tvrtko Ursulin >> >> -L and -D on the command line. >> >> With no device specified tool tries to find i915 discrete or integrated in >> that order. >> >> v2: >> * Fix error handling and support render devices. >> >> Signed-off-by: Tvrtko Ursulin > Reviewed-by: Chris Wilson > > Hmm, optarg should be a pointer into the argv, so is the copy necessary? I don't remember if I tried, and I don't see that getopt(3) explains optarg from that angle, so probably safest to keep as is. Too lazy to try.. Or maybe presence of strdup suggests I did already try and that optarg is indeed temporary copy managed by getopt. Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev