From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 653B46E0F6 for ; Tue, 4 Sep 2018 21:59:37 +0000 (UTC) From: "Souza, Jose" Date: Tue, 4 Sep 2018 21:59:34 +0000 Message-ID: References: <20180829215713.20962-1-dhinakaran.pandiyan@intel.com> In-Reply-To: <20180829215713.20962-1-dhinakaran.pandiyan@intel.com> Content-Language: en-US Content-ID: <451D97C3BE3C6642A77339A2F342B8CB@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/6] lib/psr: Add support for toggling edp psr through debugfs, v5. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Pandiyan, Dhinakaran" Cc: "Vivi, Rodrigo" List-ID: T24gV2VkLCAyMDE4LTA4LTI5IGF0IDE0OjU3IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy b3RlOg0KPiBGcm9tOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPg0KPiANCj4gSXQncyBoYXJtZnVsIHRvIHdyaXRlIHRvIGVuYWJsZV9wc3IgYXQg cnVudGltZSwgYW5kIHRoZSBwYXRjaCB0aGF0DQo+IGFsbG93cw0KPiB1cyB0byBjaGFuZ2UgaTkx NV9lZHBfcHNyX2RlYnVnIHdpdGggdGhlIHBhbmVsIHJ1bm5pbmcgd2lsbCByZXF1aXJlDQo+IHVz DQo+IHRvIGFiYW5kb24gdGhlIG1vZHVsZSBwYXJhbWV0ZXIuIEhlbmNlIHRoZSB1c2Vyc3BhY2Ug Y2hhbmdlIG5lZWRzIHRvDQo+IGJlDQo+IHB1dCBpbiBJR1QgZmlyc3QgYmVmb3JlIHdlIGNhbiBj aGFuZ2UgaXQgYXQga2VybmVsIHRpbWUuDQo+IA0KPiBUb2dnbGluZyBpdCB0byBkZWJ1Z2ZzIHdp bGwgbWVhbiB3ZSBjYW4gc2tpcCBhIG1vZGVzZXQgd2hlbiBjaGFuZ2luZw0KPiBvdXINCj4gZmVh dHVyZSBzZXQuDQo+IA0KPiBDaGFuZ2VzIHNpbmNlIHYxOg0KPiAtIFJlYmFzZSB3aXRoIHRoZSBw cmV2aW91cyBwYXRjaGVzIGRyb3BwZWQuDQo+IENoYW5nZXMgc2luY2UgdjI6DQo+IC0gUmViYXNl IG9uIHRvcCBvZiBuZXcgYXBpIGluIGk5MTVfZWRwX3Bzcl9kZWJ1Zy4NCj4gQ2hhbmdlcyBzaW5j ZSB2MzoNCj4gLSBFbmFibGUgSVJRIGRlYnVnZ2luZyBmb3IgZXh0cmEgbG9nZ2luZy4NCj4gLSBG b3JjZSBQU1IxIG1vZGUuIChkaG5rcm4pDQo+IC0gTW92ZSBQU1IgZW5hYmxlL2Rpc2FibGUgZnVu Y3Rpb25zIHRvIGxpYi9pZ3RfcHNyLiAoZGhua3JuKQ0KPiBDaGFuZ2VzIHNpbmNlIHY0Og0KPiAt IFJlZGlzYWJsZSBpcnFzIHJpZ2h0IGF3YXkgd2hlbiBkZWJ1Z2ZzIGFwaSBkb2Vzbid0IHdvcmsu IChkaG5rcm4pDQo+IC0gVXNlIGhleCBldmVyeXdoZXJlLiAoZGhua3JuKQ0KPiANCj4gUmV2aWV3 ZWQtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29t Pg0KPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuY29tPg0KPiAtLS0NCj4gIGxpYi9pZ3RfcHNyLmMgICAgICAgICAgICAgICAg ICAgIHwgODYNCj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQ0KPiAg bGliL2lndF9wc3IuaCAgICAgICAgICAgICAgICAgICAgfCAgMiArDQo+ICB0ZXN0cy9rbXNfZnJv bnRidWZmZXJfdHJhY2tpbmcuYyB8ICA2ICstLQ0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA4OSBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfcHNy LmMgYi9saWIvaWd0X3Bzci5jDQo+IGluZGV4IGM5NzliMGI1Li42MTRjYWE2ZiAxMDA2NDQNCj4g LS0tIGEvbGliL2lndF9wc3IuYw0KPiArKysgYi9saWIvaWd0X3Bzci5jDQo+IEBAIC0yMSw3ICsy MSw5IEBADQo+ICAgKiBJTiBUSEUgU09GVFdBUkUuDQo+ICAgKi8NCj4gIA0KPiAtI2luY2x1ZGUg ICJpZ3RfcHNyLmgiDQo+ICsjaW5jbHVkZSAiaWd0X3Bzci5oIg0KPiArI2luY2x1ZGUgImlndF9z eXNmcy5oIg0KPiArI2luY2x1ZGUgPGVycm5vLmg+DQo+ICANCj4gIGJvb2wgcHNyX2FjdGl2ZShp bnQgZmQsIGJvb2wgY2hlY2tfYWN0aXZlKQ0KPiAgew0KPiBAQCAtMzgsMyArNDAsODUgQEAgYm9v bCBwc3Jfd2FpdF9lbnRyeShpbnQgZmQpDQo+ICB7DQo+ICAJcmV0dXJuIGlndF93YWl0KHBzcl9h Y3RpdmUoZmQsIHRydWUpLCA1MDAsIDEpOw0KPiAgfQ0KPiArDQo+ICtzdGF0aWMgc3NpemVfdCBw c3Jfd3JpdGUoaW50IGZkLCBjb25zdCBjaGFyICpidWYpDQo+ICt7DQo+ICsJcmV0dXJuIGlndF9z eXNmc193cml0ZShmZCwgImk5MTVfZWRwX3Bzcl9kZWJ1ZyIsIGJ1ZiwNCj4gc3RybGVuKGJ1Zikp Ow0KPiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IGhhc19wc3JfZGVidWdmcyhpbnQgZmQpDQo+ICt7 DQo+ICsJaW50IHJldDsNCj4gKw0KPiArCS8qDQo+ICsJICogQ2hlY2sgaWYgbmV3IFBTUiBkZWJ1 Z2ZzIGFwaSBpcyB1c2FibGUgYnkgd3JpdGluZyBhbiBpbnZhbGlkDQo+IHZhbHVlLg0KPiArCSAq IExlZ2FjeSBtb2RlIHdpbGwgcmV0dXJuIE9LIGhlcmUsIGRlYnVnZnMgYXBpIHdpbGwgcmV0dXJu DQo+IC1FSU5WQUwuDQo+ICsJICogLUVOT0RFViBpcyByZXR1cm5lZC4NCj4gKwkgKi8NCj4gKwly ZXQgPSBwc3Jfd3JpdGUoZmQsICIweGYiKTsNCj4gKwlpZiAocmV0ID09IC1FSU5WQUwpDQo+ICsJ CXJldHVybiAwOw0KPiArCWVsc2UgaWYgKHJldCA8IDApDQo+ICsJCXJldHVybiByZXQ7DQo+ICsN Cj4gKwkvKiBsZWdhY3kgZGVidWdmcyBhcGksIHdlIGVuYWJsZWQgaXJxcyBieSB3cml0aW5nLCBk aXNhYmxlDQo+IHRoZW0uICovDQo+ICsJcHNyX3dyaXRlKGZkLCAiMCIpOw0KPiArCXJldHVybiAt RUlOVkFMOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgYm9vbCBwc3JfbW9kcGFyYW1fc2V0KGludCB2 YWwpDQo+ICt7DQo+ICsJc3RhdGljIGludCBvbGR2YWwgPSAtMTsNCg0KVGhpcyBsb29rcyB3cm9u Zywgd2h5IG5vdCByZWFkIHRoZSBtb2R1bGUgcGFyYW1ldGVyPyBpdCB3aWxsIGd1YXJhdGVlDQp0 aGF0IHRoZSByZXR1cm5lZCB2YWx1ZSBpcyBjb3JyZWN0IGhlcmUgaWYgc29tZXRoaW5nIGVsc2Ug bGVmdCB0aGUNCnBhcmFtZXRlciB3aXRoIGFub3RoZXIgdmFsdWUuDQoNCg0KPiArDQo+ICsJaWd0 X3NldF9tb2R1bGVfcGFyYW1faW50KCJlbmFibGVfcHNyIiwgdmFsKTsNCj4gKw0KPiArCWlmICh2 YWwgPT0gb2xkdmFsKQ0KPiArCQlyZXR1cm4gZmFsc2U7DQo+ICsNCj4gKwlvbGR2YWwgPSB2YWw7 DQo+ICsJcmV0dXJuIHRydWU7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgcHNyX3Jlc3RvcmVf ZGVidWdmc19mZCA9IC0xOw0KDQpNYXliZSBtb3ZlIHRoaXMgdG8gdGhlIHRvcCBvZiB0aGUgZmls ZS4NCg0KT3RoZXIgdGhhbiB0aGF0IExHVE0uDQoNCj4gKw0KPiArc3RhdGljIHZvaWQgcmVzdG9y ZV9wc3JfZGVidWdmcyhpbnQgc2lnKQ0KPiArew0KPiArCXBzcl93cml0ZShwc3JfcmVzdG9yZV9k ZWJ1Z2ZzX2ZkLCAiMCIpOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgYm9vbCBwc3Jfc2V0KGludCBm ZCwgYm9vbCBlbmFibGUpDQo+ICt7DQo+ICsJaW50IHJldDsNCj4gKw0KPiArCXJldCA9IGhhc19w c3JfZGVidWdmcyhmZCk7DQo+ICsJaWYgKHJldCA9PSAtRU5PREVWKSB7DQo+ICsJCWlndF9za2lw X29uX2YoZW5hYmxlLCAiUFNSIG5vdCBhdmFpbGFibGVcbiIpOw0KPiArCQlyZXR1cm4gZmFsc2U7 DQo+ICsJfQ0KPiArDQo+ICsJaWYgKHJldCA9PSAtRUlOVkFMKSB7DQo+ICsJCXJldCA9IHBzcl9t b2RwYXJhbV9zZXQoZW5hYmxlKTsNCj4gKwl9IGVsc2Ugew0KPiArCQlyZXQgPSBwc3Jfd3JpdGUo ZmQsIGVuYWJsZSA/ICIweDMiIDogIjB4MSIpOw0KPiArCQlpZ3RfYXNzZXJ0KHJldCA+IDApOw0K PiArCX0NCj4gKw0KPiArCS8qIFJlc3RvcmUgb3JpZ2luYWwgdmFsdWUgb24gZXhpdCAqLw0KPiAr CWlmIChwc3JfcmVzdG9yZV9kZWJ1Z2ZzX2ZkID09IC0xKSB7DQo+ICsJCXBzcl9yZXN0b3JlX2Rl YnVnZnNfZmQgPSBkdXAoZmQpOw0KPiArCQlpZ3RfYXNzZXJ0KHBzcl9yZXN0b3JlX2RlYnVnZnNf ZmQgPj0gMCk7DQo+ICsJCWlndF9pbnN0YWxsX2V4aXRfaGFuZGxlcihyZXN0b3JlX3Bzcl9kZWJ1 Z2ZzKTsNCj4gKwl9DQo+ICsNCj4gKwlyZXR1cm4gcmV0Ow0KPiArfQ0KPiArDQo+ICtib29sIHBz cl9lbmFibGUoaW50IGZkKQ0KPiArew0KPiArCXJldHVybiBwc3Jfc2V0KGZkLCB0cnVlKTsNCj4g K30NCj4gKw0KPiArYm9vbCBwc3JfZGlzYWJsZShpbnQgZmQpDQo+ICt7DQo+ICsJcmV0dXJuIHBz cl9zZXQoZmQsIGZhbHNlKTsNCj4gK30NCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfcHNyLmggYi9s aWIvaWd0X3Bzci5oDQo+IGluZGV4IDk4MGY4NWUwLi4wZWYyMmMzZCAxMDA2NDQNCj4gLS0tIGEv bGliL2lndF9wc3IuaA0KPiArKysgYi9saWIvaWd0X3Bzci5oDQo+IEBAIC0zMCw1ICszMCw3IEBA DQo+ICANCj4gIGJvb2wgcHNyX3dhaXRfZW50cnkoaW50IGZkKTsNCj4gIGJvb2wgcHNyX2FjdGl2 ZShpbnQgZmQsIGJvb2wgY2hlY2tfYWN0aXZlKTsNCj4gK2Jvb2wgcHNyX2VuYWJsZShpbnQgZmQp Ow0KPiArYm9vbCBwc3JfZGlzYWJsZShpbnQgZmQpOw0KPiAgDQo+ICAjZW5kaWYNCj4gZGlmZiAt LWdpdCBhL3Rlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5jDQo+IGIvdGVzdHMva21zX2Zy b250YnVmZmVyX3RyYWNraW5nLmMNCj4gaW5kZXggMWRmZDdjMWMuLjdlYTJmNjk3IDEwMDY0NA0K PiAtLS0gYS90ZXN0cy9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYw0KPiArKysgYi90ZXN0cy9r bXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYw0KPiBAQCAtOTQxLDggKzk0MSw2IEBAIHN0YXRpYyBi b29sDQo+IGRycnNfd2FpdF91bnRpbF9ycl9zd2l0Y2hfdG9fbG93KHZvaWQpDQo+ICANCj4gICNk ZWZpbmUgZmJjX2VuYWJsZSgpIGlndF9zZXRfbW9kdWxlX3BhcmFtX2ludCgiZW5hYmxlX2ZiYyIs IDEpDQo+ICAjZGVmaW5lIGZiY19kaXNhYmxlKCkgaWd0X3NldF9tb2R1bGVfcGFyYW1faW50KCJl bmFibGVfZmJjIiwgMCkNCj4gLSNkZWZpbmUgcHNyX2VuYWJsZSgpIGlndF9zZXRfbW9kdWxlX3Bh cmFtX2ludCgiZW5hYmxlX3BzciIsIDEpDQo+IC0jZGVmaW5lIHBzcl9kaXNhYmxlKCkgaWd0X3Nl dF9tb2R1bGVfcGFyYW1faW50KCJlbmFibGVfcHNyIiwgMCkNCj4gICNkZWZpbmUgZHJyc19lbmFi bGUoKQlkcnJzX3NldCgxKQ0KPiAgI2RlZmluZSBkcnJzX2Rpc2FibGUoKQlkcnJzX3NldCgwKQ0K PiAgDQo+IEBAIC0xMTM3LDcgKzExMzUsNyBAQCBzdGF0aWMgdm9pZCBkaXNhYmxlX2ZlYXR1cmVz KGNvbnN0IHN0cnVjdA0KPiB0ZXN0X21vZGUgKnQpDQo+ICAJCXJldHVybjsNCj4gIA0KPiAgCWZi Y19kaXNhYmxlKCk7DQo+IC0JcHNyX2Rpc2FibGUoKTsNCj4gKwlwc3JfZGlzYWJsZShkcm0uZGVi dWdmcyk7DQo+ICAJZHJyc19kaXNhYmxlKCk7DQo+ICB9DQo+ICANCj4gQEAgLTE3MTksNyArMTcx Nyw3IEBAIHN0YXRpYyB2b2lkIGVuYWJsZV9mZWF0dXJlc19mb3JfdGVzdChjb25zdA0KPiBzdHJ1 Y3QgdGVzdF9tb2RlICp0KQ0KPiAgCWlmICh0LT5mZWF0dXJlICYgRkVBVFVSRV9GQkMpDQo+ICAJ CWZiY19lbmFibGUoKTsNCj4gIAlpZiAodC0+ZmVhdHVyZSAmIEZFQVRVUkVfUFNSKQ0KPiAtCQlw c3JfZW5hYmxlKCk7DQo+ICsJCXBzcl9lbmFibGUoZHJtLmRlYnVnZnMpOw0KPiAgCWlmICh0LT5m ZWF0dXJlICYgRkVBVFVSRV9EUlJTKQ0KPiAgCQlkcnJzX2VuYWJsZSgpOw0KPiAgfQ0KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5n IGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==