From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE29589BFE for ; Thu, 9 May 2019 12:32:36 +0000 (UTC) References: <1557403084-7803-1-git-send-email-anshuman.gupta@intel.com> <1557403084-7803-2-git-send-email-anshuman.gupta@intel.com> From: Animesh Manna Message-ID: Date: Thu, 9 May 2019 18:02:34 +0530 MIME-Version: 1.0 In-Reply-To: <1557403084-7803-2-git-send-email-anshuman.gupta@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t v5 1/4] igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Anshuman Gupta , igt-dev@lists.freedesktop.org List-ID: SGksCgoKT24gNS85LzIwMTkgNToyOCBQTSwgQW5zaHVtYW4gR3VwdGEgd3JvdGU6Cj4gRW5hYmxp bmcgaTkxNV9wbV9scHNwIGlndCB0ZXN0cyBmb3IgYWxsIHBsYXRmb3JtcyB0aWxsIEdlbjExLgo+ IEVhcmxpZXIgdGhlc2UgdGVzdCB3ZXJlIGVuYWJsZWQgb25seSBvbiBoYXN3ZWxsIGFuZCBicm9h ZHdlbGwKPiBwbGF0Zm9ybXMuCj4KPiB2MjogUmVtb3ZlZCBnbG9iYWwgbm9fbHBzcF9wd19pZHgu IFtBbmltZXNoXQo+ICAgICAgQ2hlY2sgb25seSBzdGF0ZSB2YWx1ZSBmb3IgcG93ZXIgd2VsbC4g W0FuaW1lc2hdCj4gICAgICBBZGRpbmcgaWd0X3dhaXQgb2YgMSBzZWNvbmQgYXMgc29tZXRpbWVz IHNjcmVlbnNfZGlzYWJsZWQKPiAgICAgIHRlc3QgZmFpbHMgYmVjYXVzZSBBVURJTyBwb3dlciBk b21haW4gd2FzIGhhdmluZyBub24temVybwo+ICAgICAgcG93ZXIgZG9tYWluIHJlZmVyZW5jZSBj b3VudC5bSW1yZV0KPiAgICAgIER1bXBpbmcgaTkxNV9wbV9ydW50aW1lX3N0YXR1cyBhbmQgaTkx NV9wb3dlcl9kb21haW5faW5mbwo+ICAgICAgaW4gY2FzZSB0ZXN0IGZhaWxzLltJbXJlXQo+IHYz OiBIYXZpbmcgaWd0X3dhaXQoKSB0byBjaGVjayBscHNwX2VuYWJsZWQoKSBvbmx5IHRvIHRoZSBw YXJ0Cj4gICAgICBvZiB0ZXN0IGFmZmVjdGVkIGJ5IGRlbGF5ZWQgYXVkaW8gY29kZWMgZGlzYWJs aW5nLgo+Cj4gQ2M6IGltcmUuZGVha0BpbnRlbC5jb20KPiBTaWduZWQtb2ZmLWJ5OiBBbnNodW1h biBHdXB0YSA8YW5zaHVtYW4uZ3VwdGFAaW50ZWwuY29tPgo+IC0tLQo+ICAgdGVzdHMvaTkxNS9p OTE1X3BtX2xwc3AuYyB8IDg4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNzAgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvdGVzdHMvaTkxNS9pOTE1X3BtX2xwc3AuYyBiL3Rlc3Rz L2k5MTUvaTkxNV9wbV9scHNwLmMKPiBpbmRleCBiMzE5ZGJlLi4xYWJlNTg3IDEwMDY0NAo+IC0t LSBhL3Rlc3RzL2k5MTUvaTkxNV9wbV9scHNwLmMKPiArKysgYi90ZXN0cy9pOTE1L2k5MTVfcG1f bHBzcC5jCj4gQEAgLTMwLDI2ICszMCw2OCBAQAo+ICAgI2luY2x1ZGUgPGZjbnRsLmg+Cj4gICAj aW5jbHVkZSA8dW5pc3RkLmg+Cj4gICAKPiArI2luY2x1ZGUgImlndF9zeXNmcy5oIgo+ICsKPiAr I2RlZmluZSAgIEhTV19QV19DVExfSURYX0dMT0JBTCAgICAgICAgICAgICAgICAgMTUKPiArI2Rl ZmluZSAgIFNLTF9QV19DVExfSURYX1BXXzIgICAgICAgICAgICAgICAgICAgMTUKPiArI2RlZmlu ZSAgIElDTF9QV19DVExfSURYX1BXXzMgICAgICAgICAgICAgICAgICAgMgo+ICsKPiArI2RlZmlu ZSAgIEhTV19QV1JfV0VMTF9DVExfUkVRKHB3X2lkeCkgICAgICAgICAgKDB4MiA8PCAoKHB3X2lk eCkgKiAyKSkKCkhTV19QV1JfV0VMTF9DVExfUkVRIGNhbiBiZSByZW1vdmVkIGFzIG5vdCB1c2Vk IGFueXdoZXJlLgoKCj4gKyNkZWZpbmUgICBIU1dfUFdSX1dFTExfQ1RMX1NUQVRFKHB3X2lkeCkg ICAgICAgICgweDEgPDwgKChwd19pZHgpICogMikpCgpJIGNhbiB1bmRlcnN0YW5kIHRoYXQgaGVy ZSB0cmllZCB0byBmb2xsb3cgc2ltaWxhciBkcml2ZXIgZGVzaWduIHRvIApjYWxjdWxhdGUgbWFz ayBmb3IgcG93ZXIgd2VsbCByZWdpc3RlciwKYnV0IHZhbGlkYXRpb24gcG9pbnQgb2YgdmlldyBu b3QgbmVjZXNzYXJpbHkgbmVlZCB0byBoYXZlIHNhbWUgZGVzaWduIApsaWtlIGRyaXZlciBhbmQg bWF5YmUgYmV0dGVyIG5vdCB0byBmb2xsb3cgdG8gY2F0Y2ggZHJpdmVyIGlzc3VlIGlmIApwb3Nz aWJsZS4KCkFzIHBlciBtZSwgPHBsYXRmb3JtPl9QVzJfRU5BQkxFX01BU0sgaXMgc3VmZmljaWVu dCB0byBjaGVjayB0aGUgc3RhdGUgCm9mIHBvd2VyIHdlbGwgMi4KCj4gKwo+ICsjZGVmaW5lIERV TVBfREJHRlMoZmlsZTEsIGZpbGUyLCBmZCkJCQlcCj4gKwkiJXM6XG4lc1xuJXM6XG4lc1xuIiwg ZmlsZTEsCQkJXAo+ICsJaWd0X3N5c2ZzX2dldChmZCwgZmlsZTEpLCBmaWxlMiwJCVwKPiArCWln dF9zeXNmc19nZXQoZmQsIGZpbGUyKQkJCVwKPiAgIAo+ICAgc3RhdGljIGJvb2wgc3VwcG9ydHNf bHBzcCh1aW50MzJfdCBkZXZpZCkKPiAgIHsKPiAtCXJldHVybiBJU19IQVNXRUxMKGRldmlkKSB8 fCBJU19CUk9BRFdFTEwoZGV2aWQpOwo+ICsJcmV0dXJuIElTX0hBU1dFTEwoZGV2aWQpIHx8IElT X0JST0FEV0VMTChkZXZpZCkKPiArCQkJCSB8fCBBVF9MRUFTVF9HRU4oZGV2aWQsIDkpOwo+ICt9 Cj4gKwo+ICtzdGF0aWMgaW50IGdldF9ub19scHNwX3B3X2lkeCh1aW50MzJfdCBkZXZpZCkKPiAr ewoKV2UgY2FuIHJldHVybiA8cGxhdGZvcm0+X1BXMl9FTkFCTEVfTUFTSyBmcm9tIHRoaXMgZnVu Y3Rpb24uIEZ1bmN0aW9uIApuYW1lIHNob3VsZCBiZSB1cGRhdGVkIGFjY29yZGluZ2x5LgoKUmVn YXJkcywKQW5pbWVzaAoKPiArCWludCBub19scHNwX3B3X2lkeDsKPiArCj4gKwlpZiAoSVNfSEFT V0VMTChkZXZpZCkgfHwgSVNfQlJPQURXRUxMKGRldmlkKSkKPiArCQlub19scHNwX3B3X2lkeCA9 IEhTV19QV19DVExfSURYX0dMT0JBTDsKPiArCWVsc2UgaWYgKElTX0dFTihkZXZpZCwgMTEpKQo+ ICsJCW5vX2xwc3BfcHdfaWR4ID0gSUNMX1BXX0NUTF9JRFhfUFdfMzsKPiArCWVsc2UgaWYgKEFU X0xFQVNUX0dFTihkZXZpZCwgOSkpCj4gKwkJbm9fbHBzcF9wd19pZHggPSBTS0xfUFdfQ1RMX0lE WF9QV18yOwo+ICsJZWxzZQo+ICsJCW5vX2xwc3BfcHdfaWR4ID0gLTE7Cj4gKwo+ICsJcmV0dXJu IG5vX2xwc3BfcHdfaWR4Owo+ICAgfQo+ICAgCj4gLXN0YXRpYyBib29sIGxwc3BfaXNfZW5hYmxl ZChpbnQgZHJtX2ZkKQo+ICtzdGF0aWMgYm9vbCBscHNwX2lzX2VuYWJsZWQodWludDMyX3QgZGV2 aWQpCj4gICB7Cj4gLQl1aW50MzJfdCB2YWw7Cj4gKwl1aW50MzJfdCB2YWwsIG1hc2s7Cj4gKwlp bnQgcHdfaWR4Owo+ICsKPiArCXB3X2lkeCA9IGdldF9ub19scHNwX3B3X2lkeChkZXZpZCk7Cj4g KwlpZ3RfcmVxdWlyZShwd19pZHggPiAwKTsKPiArCW1hc2sgPSBIU1dfUFdSX1dFTExfQ1RMX1NU QVRFKHB3X2lkeCk7Cj4gICAKPiAgIAl2YWwgPSBJTlJFRyhIU1dfUFdSX1dFTExfQ1RMMik7Cj4g LQlyZXR1cm4gISh2YWwgJiBIU1dfUFdSX1dFTExfU1RBVEVfRU5BQkxFRCk7Cj4gKwlyZXR1cm4g ISh2YWwgJiBtYXNrKTsKPiAgIH0KPiAgIAo+ICAgLyogVGhlIExQU1AgbW9kZSBpcyBhbGwgYWJv dXQgYW4gZW5hYmxlZCBwaXBlLCBidXQgd2UgZXhwZWN0IHRvIGFsc28gYmUgaW4gdGhlCj4gICAg KiBsb3cgcG93ZXIgbW9kZSB3aGVuIG5vIHBpcGVzIGFyZSBlbmFibGVkLCBzbyBkbyB0aGlzIGNo ZWNrIGFueXdheS4gKi8KPiAtc3RhdGljIHZvaWQgc2NyZWVuc19kaXNhYmxlZF9zdWJ0ZXN0KGlu dCBkcm1fZmQsIGRybU1vZGVSZXNQdHIgZHJtX3JlcykKPiArc3RhdGljIHZvaWQgc2NyZWVuc19k aXNhYmxlZF9zdWJ0ZXN0KGludCBkcm1fZmQsIGRybU1vZGVSZXNQdHIgZHJtX3JlcywKPiArCQkJ CSAgICAgdWludDMyX3QgZGV2aWQsIGludCBmZCkKPiAgIHsKPiAgIAlrbXN0ZXN0X3Vuc2V0X2Fs bF9jcnRjcyhkcm1fZmQsIGRybV9yZXMpOwo+IC0JaWd0X2Fzc2VydChscHNwX2lzX2VuYWJsZWQo ZHJtX2ZkKSk7Cj4gKwo+ICsJLyogU29tZSB0aW1lcyBkZWxheWVkIGF1ZGlvIGNvZGVjIGRpc2Fi bGluZyBjYXVzZXMgdG8gZmFpbCB0aGUgdGVzdC4KPiArCSAqIFVzaW5nIGlndF93YWl0IHRvIGNo ZWNrIGxwc3AgYWZ0ZXIgZHJtX21vZGVfc2V0Y3J0YygpLgo+ICsJICovCj4gKwlpZ3RfYXNzZXJ0 X2YoaWd0X3dhaXQobHBzcF9pc19lbmFibGVkKGRldmlkKSwgMTAwMCwgMTAwKSwKPiArCQkgICAg IERVTVBfREJHRlMoImk5MTVfcnVudGltZV9wbV9zdGF0dXMiLAo+ICsJCQkJImk5MTVfcG93ZXJf ZG9tYWluX2luZm8iLCBmZCkpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdWludDMyX3QgY3JlYXRl X2ZiKGludCBkcm1fZmQsIGludCB3aWR0aCwgaW50IGhlaWdodCkKPiBAQCAtNjIsNyArMTA0LDcg QEAgc3RhdGljIHVpbnQzMl90IGNyZWF0ZV9mYihpbnQgZHJtX2ZkLCBpbnQgd2lkdGgsIGludCBo ZWlnaHQpCj4gICAKPiAgIHN0YXRpYyB2b2lkIGVkcF9zdWJ0ZXN0KGludCBkcm1fZmQsIGRybU1v ZGVSZXNQdHIgZHJtX3JlcywKPiAgIAkJCWRybU1vZGVDb25uZWN0b3JQdHIgKmRybV9jb25uZWN0 b3JzLCB1aW50MzJfdCBkZXZpZCwKPiAtCQkJYm9vbCB1c2VfcGFuZWxfZml0dGVyKQo+ICsJCQli b29sIHVzZV9wYW5lbF9maXR0ZXIsIGludCBmZCkKPiAgIHsKPiAgIAlpbnQgaSwgcmM7Cj4gICAJ dWludDMyX3QgY3J0Y19pZCA9IDAsIGJ1ZmZlcl9pZCA9IDA7Cj4gQEAgLTEzMywxNiArMTc1LDE4 IEBAIHN0YXRpYyB2b2lkIGVkcF9zdWJ0ZXN0KGludCBkcm1fZmQsIGRybU1vZGVSZXNQdHIgZHJt X3JlcywKPiAgIAo+ICAgCWlmICh1c2VfcGFuZWxfZml0dGVyKSB7Cj4gICAJCWlmIChJU19IQVNX RUxMKGRldmlkKSkKPiAtCQkJaWd0X2Fzc2VydCghbHBzcF9pc19lbmFibGVkKGRybV9mZCkpOwo+ ICsJCQlpZ3RfYXNzZXJ0KCFscHNwX2lzX2VuYWJsZWQoZGV2aWQpKTsKPiAgIAkJZWxzZQo+IC0J CQlpZ3RfYXNzZXJ0KGxwc3BfaXNfZW5hYmxlZChkcm1fZmQpKTsKPiArCQkJaWd0X2Fzc2VydChs cHNwX2lzX2VuYWJsZWQoZGV2aWQpKTsKPiAgIAl9IGVsc2Ugewo+IC0JCWlndF9hc3NlcnQobHBz cF9pc19lbmFibGVkKGRybV9mZCkpOwo+ICsJCWlndF9hc3NlcnRfZihscHNwX2lzX2VuYWJsZWQo ZGV2aWQpLAo+ICsJCQkgICAgIERVTVBfREJHRlMoImk5MTVfcnVudGltZV9wbV9zdGF0dXMiLAo+ ICsJCQkJCSJpOTE1X3Bvd2VyX2RvbWFpbl9pbmZvIiwgZmQpKTsKPiAgIAl9Cj4gICB9Cj4gICAK PiAtc3RhdGljIHZvaWQgbm9uX2VkcF9zdWJ0ZXN0KGludCBkcm1fZmQsIGRybU1vZGVSZXNQdHIg ZHJtX3JlcywKPiAtCQkJICAgIGRybU1vZGVDb25uZWN0b3JQdHIgKmRybV9jb25uZWN0b3JzKQo+ ICtzdGF0aWMgdm9pZCBub25fZWRwX3N1YnRlc3QoaW50IGRybV9mZCwgZHJtTW9kZVJlc1B0ciBk cm1fcmVzLCB1aW50MzJfdCBkZXZpZCwKPiArCQkJICAgIGRybU1vZGVDb25uZWN0b3JQdHIgKmRy bV9jb25uZWN0b3JzLCBpbnQgZmQpCj4gICB7Cj4gICAJaW50IGksIHJjOwo+ICAgCXVpbnQzMl90 IGNydGNfaWQgPSAwLCBidWZmZXJfaWQgPSAwOwo+IEBAIC0xNzcsOCArMjIxLDkgQEAgc3RhdGlj IHZvaWQgbm9uX2VkcF9zdWJ0ZXN0KGludCBkcm1fZmQsIGRybU1vZGVSZXNQdHIgZHJtX3JlcywK PiAgIAlyYyA9IGRybU1vZGVTZXRDcnRjKGRybV9mZCwgY3J0Y19pZCwgYnVmZmVyX2lkLCAwLCAw LAo+ICAgCQkJICAgICZjb25uZWN0b3ItPmNvbm5lY3Rvcl9pZCwgMSwgbW9kZSk7Cj4gICAJaWd0 X2Fzc2VydF9lcShyYywgMCk7Cj4gLQo+IC0JaWd0X2Fzc2VydCghbHBzcF9pc19lbmFibGVkKGRy bV9mZCkpOwo+ICsJaWd0X2Fzc2VydF9mKCFscHNwX2lzX2VuYWJsZWQoZGV2aWQpLAo+ICsJCSAg ICAgRFVNUF9EQkdGUygiaTkxNV9ydW50aW1lX3BtX3N0YXR1cyIsCj4gKwkJCQkiaTkxNV9wb3dl cl9kb21haW5faW5mbyIsIGZkKSk7Cj4gICB9Cj4gICAKPiAgICNkZWZpbmUgTUFYX0NPTk5FQ1RP UlMgMzIKPiBAQCAtMTkwLDYgKzIzNSw4IEBAIGRybU1vZGVDb25uZWN0b3JQdHIgZHJtX2Nvbm5l Y3RvcnNbTUFYX0NPTk5FQ1RPUlNdOwo+ICAgCj4gICBpZ3RfbWFpbgo+ICAgewo+ICsJaW50IGRl YnVnZnM7Cj4gKwo+ICAgCWlndF9maXh0dXJlIHsKPiAgIAkJaW50IGk7Cj4gICAKPiBAQCAtMjEy LDE3ICsyNTksMjIgQEAgaWd0X21haW4KPiAgIAo+ICAgCQlpbnRlbF9yZWdpc3Rlcl9hY2Nlc3Nf aW5pdChpbnRlbF9nZXRfcGNpX2RldmljZSgpLCAwLCBkcm1fZmQpOwo+ICAgCj4gKwkJaWd0X3Jl cXVpcmUoZ2V0X25vX2xwc3BfcHdfaWR4KGRldmlkKSA+IDApOwo+ICAgCQlrbXN0ZXN0X3NldF92 dF9ncmFwaGljc19tb2RlKCk7Cj4gKwkJZGVidWdmcyA9IGlndF9kZWJ1Z2ZzX2Rpcihkcm1fZmQp Owo+ICAgCX0KPiAgIAo+ICAgCWlndF9zdWJ0ZXN0KCJzY3JlZW5zLWRpc2FibGVkIikKPiAtCQlz Y3JlZW5zX2Rpc2FibGVkX3N1YnRlc3QoZHJtX2ZkLCBkcm1fcmVzKTsKPiArCQlzY3JlZW5zX2Rp c2FibGVkX3N1YnRlc3QoZHJtX2ZkLCBkcm1fcmVzLCBkZXZpZCwgZGVidWdmcyk7Cj4gICAJaWd0 X3N1YnRlc3QoImVkcC1uYXRpdmUiKQo+IC0JCWVkcF9zdWJ0ZXN0KGRybV9mZCwgZHJtX3Jlcywg ZHJtX2Nvbm5lY3RvcnMsIGRldmlkLCBmYWxzZSk7Cj4gKwkJZWRwX3N1YnRlc3QoZHJtX2ZkLCBk cm1fcmVzLCBkcm1fY29ubmVjdG9ycywgZGV2aWQsIGZhbHNlLAo+ICsJCQkgICAgZGVidWdmcyk7 Cj4gICAJaWd0X3N1YnRlc3QoImVkcC1wYW5lbC1maXR0ZXIiKQo+IC0JCWVkcF9zdWJ0ZXN0KGRy bV9mZCwgZHJtX3JlcywgZHJtX2Nvbm5lY3RvcnMsIGRldmlkLCB0cnVlKTsKPiArCQllZHBfc3Vi dGVzdChkcm1fZmQsIGRybV9yZXMsIGRybV9jb25uZWN0b3JzLCBkZXZpZCwgdHJ1ZSwKPiArCQkJ ICAgIGRlYnVnZnMpOwo+ICAgCWlndF9zdWJ0ZXN0KCJub24tZWRwIikKPiAtCQlub25fZWRwX3N1 YnRlc3QoZHJtX2ZkLCBkcm1fcmVzLCBkcm1fY29ubmVjdG9ycyk7Cj4gKwkJbm9uX2VkcF9zdWJ0 ZXN0KGRybV9mZCwgZHJtX3JlcywgZGV2aWQsIGRybV9jb25uZWN0b3JzLAo+ICsJCQkJZGVidWdm cyk7Cj4gICAKPiAgIAlpZ3RfZml4dHVyZSB7Cj4gICAJCWludCBpOwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0 LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2