Re: [PATCH v2] tools/xe-perf-recorder: Add mmio-trigger support

[Shekhar Chauhan <shekhar.chauhan@intel.com>]

On 7/16/2026 2:03, Dixit, Ashutosh wrote:
> On Tue, 14 Jul 2026 04:23:04 -0700, Kamil Konieczny wrote:
> Hi Kamil,
>
>>> On second thoughts, let us leave check_mmio_trigger_report() in (as is) for
>>> now, so we will at least have some indication and my guess is we will
>>> occasionally see the second mmio triggered report missing.
>>>
>>> So let us leave it in for now and later fix it by a future patch.
>>>
>> imho function should be renamed. As Jani wrote: "Please don't
>> add functions named "check something". It's one of the most
>> ambiguous verbs you could use in a function name."
> Would you have a reference to this, so we can see what Jani means? Or what
> would you think is a better name for the function?

I've sent the v3 without touching this subject and addressing other 
review comments; once we can finalize on this, I'll send a v4 (shouldn't 
be a big deal then)

-shekhar

>
> Thanks.
> --
> Ashutosh

-- 
Shekhar Chauhan
Linux Graphics Software Engineer
Intel Corporation