From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 790766E145 for ; Thu, 12 Mar 2020 11:15:14 +0000 (UTC) From: "Peres, Martin" Date: Thu, 12 Mar 2020 11:15:11 +0000 Message-ID: References: <20200312095137.551252-1-arkadiusz.hiler@intel.com> <20200312095137.551252-2-arkadiusz.hiler@intel.com> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_chamelium: Don't fail random palnes tests on invalid config List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Hiler, Arkadiusz" , "igt-dev@lists.freedesktop.org" Cc: "Latvala, Petri" List-ID: s/palnes/planes On 2020-03-12 11:51, Hiler, Arkadiusz wrote: > It is possible to generate a configuration that the driver rejects > because it cannot be handled (e.g. exceeding the number of available > scalers). Until now the test was failing in such cases with: > > igt_kms-CRITICAL: Test assertion failure function igt_display_commit_atomic, file ../lib/igt_kms.c:3490: > igt_kms-CRITICAL: Failed assertion: ret == 0 > igt_kms-CRITICAL: Last errno: 22, Invalid argument > igt_kms-CRITICAL: error: -22 != 0 > > With this change we will just note that the atomic commit is invalid and > pass the test without causing random noise. I was about to object strongly, but thinking about it further, I think this whole subtest makes no sense. We have a ton of tests for planes, and if the targeted HW does not have support for CRCs, then it should be emulated using pipe writeback or using chamelium as a source of CRC. Anyway, fixing this test would require a loop of atomic tries until a suitable configuration would be found, until then, I would rather skip than give the idea that the test could test anything. In summary, either: - nuke the subtest - make it skip upon atomic check failure - fix it by looking for valid configurations I am just against the idea of passing a test without it doing anything. Martin _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev