From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0A2C6E0DB for ; Fri, 20 Apr 2018 23:58:48 +0000 (UTC) References: <20180420111528.14430-1-lukasz.kalamarz@intel.com> From: Daniele Ceraolo Spurio Message-ID: Date: Fri, 20 Apr 2018 16:58:47 -0700 MIME-Version: 1.0 In-Reply-To: <20180420111528.14430-1-lukasz.kalamarz@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t v4 1/4] lib/rendercopy_gen7: Reorganizing batch allocations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lukasz Kalamarz , igt-dev@lists.freedesktop.org List-ID: CgpPbiAyMC8wNC8xOCAwNDoxNSwgTHVrYXN6IEthbGFtYXJ6IHdyb3RlOgo+IFRoaXMgbGliIHdh cyB3cml0dGVuIGluIGEgZGlmZmVyZW50IG1hbm5lciB0aGFuIGFsbCBvdGhlciBsaWJzLAo+IHdo aWNoIHdhcyBjYXVzaW5nIHNvbWUgaXNzdWVzIGR1cmluZyByZWZhY3RvcmluZy4gUHJldmlvdXMK PiBpbXBsZW1lbnRhdGlvbiB3YXMgdXNpbmcgdHdvIHBvaW50ZXJzIChwdHIgYW5kIHN0YXRlKSB0 bwo+IGFjY2VzcyB0d28gcGFydHMgb2YgYmF0Y2hidWZmZXIgaW4gdGhlIHNhbWUgdGltZS4gQ3Vy cmVudAo+IGltcGxlbWVudGF0aW9uIGlzIHJldXNpbmcgcHRyIHdpdGggYSBkb3duc2lkZSBvZiBu ZWVkaW5nCj4gdG8gZW5zdXJlIHRoZSBzdGF0ZS9jb21tYW5kIG9yZGVyaW5nIGlzIHByb3Blci4K PiAKPiB2MzogTW9kaWZpZWQgY29tbWl0IG1lc3NhZ2UgYW5kIGFkZGVkIGJhdGNoIGJvdW5kYXJ5 IGNoZWNrCj4gCj4gU2lnbmVkLW9mZi1ieTogTHVrYXN6IEthbGFtYXJ6IDxsdWthc3oua2FsYW1h cnpAaW50ZWwuY29tPgo+IENjOiBLYXRhcnp5bmEgRGVjIDxrYXRhcnp5bmEuZGVjQGludGVsLmNv bT4KPiBDYzogUmFkb3NsYXcgU3p3aWNodGVuYmVyZyA8cmFkb3NsYXcuc3p3aWNodGVuYmVyZ0Bp bnRlbC5jb20+Cj4gQ2M6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3Nw dXJpb0BpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFu aWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KCkRhbmllbGUKCj4gLS0tCj4gICBsaWIvcmVu ZGVyY29weV9nZW43LmMgfCA3NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspLCAzMiBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL3JlbmRlcmNvcHlfZ2VuNy5jIGIvbGli L3JlbmRlcmNvcHlfZ2VuNy5jCj4gaW5kZXggM2I5MjQwNi4uMjY0OWFlMyAxMDA2NDQKPiAtLS0g YS9saWIvcmVuZGVyY29weV9nZW43LmMKPiArKysgYi9saWIvcmVuZGVyY29weV9nZW43LmMKPiBA QCAtMzUsNyArMzUsNyBAQCBzdGF0aWMgY29uc3QgdWludDMyX3QgcHNfa2VybmVsW11bNF0gPSB7 Cj4gICBzdGF0aWMgdWludDMyX3QKPiAgIGJhdGNoX3VzZWQoc3RydWN0IGludGVsX2JhdGNoYnVm ZmVyICpiYXRjaCkKPiAgIHsKPiAtCXJldHVybiBiYXRjaC0+c3RhdGUgLSBiYXRjaC0+YnVmZmVy Owo+ICsJcmV0dXJuIGJhdGNoLT5wdHIgLSBiYXRjaC0+YnVmZmVyOwo+ICAgfQo+ICAgCj4gICBz dGF0aWMgdWludDMyX3QKPiBAQCAtNDMsNyArNDMsNyBAQCBiYXRjaF9hbGlnbihzdHJ1Y3QgaW50 ZWxfYmF0Y2hidWZmZXIgKmJhdGNoLCB1aW50MzJfdCBhbGlnbikKPiAgIHsKPiAgIAl1aW50MzJf dCBvZmZzZXQgPSBiYXRjaF91c2VkKGJhdGNoKTsKPiAgIAlvZmZzZXQgPSBBTElHTihvZmZzZXQs IGFsaWduKTsKPiAtCWJhdGNoLT5zdGF0ZSA9IGJhdGNoLT5idWZmZXIgKyBvZmZzZXQ7Cj4gKwli YXRjaC0+cHRyID0gYmF0Y2gtPmJ1ZmZlciArIG9mZnNldDsKPiAgIAlyZXR1cm4gb2Zmc2V0Owo+ ICAgfQo+ICAgCj4gQEAgLTUxLDcgKzUxLDcgQEAgc3RhdGljIHZvaWQgKgo+ICAgYmF0Y2hfYWxs b2Moc3RydWN0IGludGVsX2JhdGNoYnVmZmVyICpiYXRjaCwgdWludDMyX3Qgc2l6ZSwgdWludDMy X3QgYWxpZ24pCj4gICB7Cj4gICAJdWludDMyX3Qgb2Zmc2V0ID0gYmF0Y2hfYWxpZ24oYmF0Y2gs IGFsaWduKTsKPiAtCWJhdGNoLT5zdGF0ZSArPSBzaXplOwo+ICsJYmF0Y2gtPnB0ciArPSBzaXpl Owo+ICAgCXJldHVybiBtZW1zZXQoYmF0Y2gtPmJ1ZmZlciArIG9mZnNldCwgMCwgc2l6ZSk7Cj4g ICB9Cj4gICAKPiBAQCAtMTk4LDE1ICsxOTgsOSBAQCBnZW43X2NyZWF0ZV92ZXJ0ZXhfYnVmZmVy KHN0cnVjdCBpbnRlbF9iYXRjaGJ1ZmZlciAqYmF0Y2gsCj4gICBzdGF0aWMgdm9pZCBnZW43X2Vt aXRfdmVydGV4X2J1ZmZlcihzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZmZXIgKmJhdGNoLAo+ICAgCQkJ CSAgICBpbnQgc3JjX3gsIGludCBzcmNfeSwKPiAgIAkJCQkgICAgaW50IGRzdF94LCBpbnQgZHN0 X3ksCj4gLQkJCQkgICAgaW50IHdpZHRoLCBpbnQgaGVpZ2h0KQo+ICsJCQkJICAgIGludCB3aWR0 aCwgaW50IGhlaWdodCwKPiArCQkJCSAgICB1aW50MzJfdCBvZmZzZXQpCj4gICB7Cj4gLQl1aW50 MzJfdCBvZmZzZXQ7Cj4gLQo+IC0Jb2Zmc2V0ID0gZ2VuN19jcmVhdGVfdmVydGV4X2J1ZmZlcihi YXRjaCwKPiAtCQkJCQkgICBzcmNfeCwgc3JjX3ksCj4gLQkJCQkJICAgZHN0X3gsIGRzdF95LAo+ IC0JCQkJCSAgIHdpZHRoLCBoZWlnaHQpOwo+IC0KPiAgIAlPVVRfQkFUQ0goR0VON18zRFNUQVRF X1ZFUlRFWF9CVUZGRVJTIHwgKDUgLSAyKSk7Cj4gICAJT1VUX0JBVENIKDAgPDwgR0VON19WQjBf QlVGRkVSX0lOREVYX1NISUZUIHwKPiAgIAkJICBHRU43X1ZCMF9WRVJURVhEQVRBIHwKPiBAQCAt MjM4LDEwICsyMzIsMTEgQEAgZ2VuN19iaW5kX3N1cmZhY2VzKHN0cnVjdCBpbnRlbF9iYXRjaGJ1 ZmZlciAqYmF0Y2gsCj4gICBzdGF0aWMgdm9pZAo+ICAgZ2VuN19lbWl0X2JpbmRpbmdfdGFibGUo c3RydWN0IGludGVsX2JhdGNoYnVmZmVyICpiYXRjaCwKPiAgIAkJCXN0cnVjdCBpZ3RfYnVmICpz cmMsCj4gLQkJCXN0cnVjdCBpZ3RfYnVmICpkc3QpCj4gKwkJCXN0cnVjdCBpZ3RfYnVmICpkc3Qs Cj4gKwkJCXVpbnQzMl90IGJpbmRfc3VyZl9vZmYpCj4gICB7Cj4gICAJT1VUX0JBVENIKEdFTjdf M0RTVEFURV9CSU5ESU5HX1RBQkxFX1BPSU5URVJTX1BTIHwgKDIgLSAyKSk7Cj4gLQlPVVRfQkFU Q0goZ2VuN19iaW5kX3N1cmZhY2VzKGJhdGNoLCBzcmMsIGRzdCkpOwo+ICsJT1VUX0JBVENIKGJp bmRfc3VyZl9vZmYpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZAo+IEBAIC0yOTgsMTMgKzI5 MywxNCBAQCBnZW43X2NyZWF0ZV9jY192aWV3cG9ydChzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZmZXIg KmJhdGNoKQo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZAo+IC1nZW43X2VtaXRfY2Moc3RydWN0 IGludGVsX2JhdGNoYnVmZmVyICpiYXRjaCkKPiArZ2VuN19lbWl0X2NjKHN0cnVjdCBpbnRlbF9i YXRjaGJ1ZmZlciAqYmF0Y2gsIHVpbnQzMl90IGJsZW5kX3N0YXRlLAo+ICsJICAgICB1aW50MzJf dCBjY192aWV3cG9ydCkKPiAgIHsKPiAtICAgICAgICBPVVRfQkFUQ0goR0VON18zRFNUQVRFX0JM RU5EX1NUQVRFX1BPSU5URVJTIHwgKDIgLSAyKSk7Cj4gLSAgICAgICAgT1VUX0JBVENIKGdlbjdf Y3JlYXRlX2JsZW5kX3N0YXRlKGJhdGNoKSk7Cj4gKwlPVVRfQkFUQ0goR0VON18zRFNUQVRFX0JM RU5EX1NUQVRFX1BPSU5URVJTIHwgKDIgLSAyKSk7Cj4gKwlPVVRfQkFUQ0goYmxlbmRfc3RhdGUp Owo+ICAgCj4gLSAgICAgICAgT1VUX0JBVENIKEdFTjdfM0RTVEFURV9WSUVXUE9SVF9TVEFURV9Q T0lOVEVSU19DQyB8ICgyIC0gMikpOwo+IC0JT1VUX0JBVENIKGdlbjdfY3JlYXRlX2NjX3ZpZXdw b3J0KGJhdGNoKSk7Cj4gKwlPVVRfQkFUQ0goR0VON18zRFNUQVRFX1ZJRVdQT1JUX1NUQVRFX1BP SU5URVJTX0NDIHwgKDIgLSAyKSk7Cj4gKwlPVVRfQkFUQ0goY2Nfdmlld3BvcnQpOwo+ICAgfQo+ ICAgCj4gICBzdGF0aWMgdWludDMyX3QKPiBAQCAtMzI3LDEwICszMjMsMTAgQEAgZ2VuN19jcmVh dGVfc2FtcGxlcihzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZmZXIgKmJhdGNoKQo+ICAgfQo+ICAgCj4g ICBzdGF0aWMgdm9pZAo+IC1nZW43X2VtaXRfc2FtcGxlcihzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZm ZXIgKmJhdGNoKQo+ICtnZW43X2VtaXRfc2FtcGxlcihzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZmZXIg KmJhdGNoLCB1aW50MzJfdCBzYW1wbGVyX29mZikKPiAgIHsKPiAtICAgICAgICBPVVRfQkFUQ0go R0VON18zRFNUQVRFX1NBTVBMRVJfU1RBVEVfUE9JTlRFUlNfUFMgfCAoMiAtIDIpKTsKPiAtICAg ICAgICBPVVRfQkFUQ0goZ2VuN19jcmVhdGVfc2FtcGxlcihiYXRjaCkpOwo+ICsJT1VUX0JBVENI KEdFTjdfM0RTVEFURV9TQU1QTEVSX1NUQVRFX1BPSU5URVJTX1BTIHwgKDIgLSAyKSk7Cj4gKwlP VVRfQkFUQ0goc2FtcGxlcl9vZmYpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZAo+IEBAIC00 NjgsNyArNDY0LDcgQEAgZ2VuN19lbWl0X3NiZShzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZmZXIgKmJh dGNoKQo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZAo+IC1nZW43X2VtaXRfcHMoc3RydWN0IGlu dGVsX2JhdGNoYnVmZmVyICpiYXRjaCkKPiArZ2VuN19lbWl0X3BzKHN0cnVjdCBpbnRlbF9iYXRj aGJ1ZmZlciAqYmF0Y2gsIHVpbnQzMl90IGtlcm5lbF9vZmYpCj4gICB7Cj4gICAJaW50IHRocmVh ZHM7Cj4gICAKPiBAQCAtNDc4LDcgKzQ3NCw3IEBAIGdlbjdfZW1pdF9wcyhzdHJ1Y3QgaW50ZWxf YmF0Y2hidWZmZXIgKmJhdGNoKQo+ICAgCQl0aHJlYWRzID0gNDAgPDwgSVZCX1BTX01BWF9USFJF QURTX1NISUZUOwo+ICAgCj4gICAJT1VUX0JBVENIKEdFTjdfM0RTVEFURV9QUyB8ICg4IC0gMikp Owo+IC0JT1VUX0JBVENIKGJhdGNoX2NvcHkoYmF0Y2gsIHBzX2tlcm5lbCwgc2l6ZW9mKHBzX2tl cm5lbCksIDY0KSk7Cj4gKwlPVVRfQkFUQ0goa2VybmVsX29mZik7Cj4gICAJT1VUX0JBVENIKDEg PDwgR0VON19QU19TQU1QTEVSX0NPVU5UX1NISUZUIHwKPiAgIAkJICAyIDw8IEdFTjdfUFNfQklO RElOR19UQUJMRV9FTlRSWV9DT1VOVF9TSElGVCk7Cj4gICAJT1VUX0JBVENIKDApOyAvKiBzY3Jh dGNoIGFkZHJlc3MgKi8KPiBAQCAtNTM1LDEyICs1MzEsMjkgQEAgdm9pZCBnZW43X3JlbmRlcl9j b3B5ZnVuYyhzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZmZXIgKmJhdGNoLAo+ICAgCQkJICB1bnNpZ25l ZCB3aWR0aCwgdW5zaWduZWQgaGVpZ2h0LAo+ICAgCQkJICBzdHJ1Y3QgaWd0X2J1ZiAqZHN0LCB1 bnNpZ25lZCBkc3RfeCwgdW5zaWduZWQgZHN0X3kpCj4gICB7Cj4gKwl1aW50MzJfdCBwc19iaW5k aW5nX3RhYmxlLCBwc19zYW1wbGVyX29mZiwgcHNfa2VybmVsX29mZjsKPiArCXVpbnQzMl90IGJs ZW5kX3N0YXRlLCBjY192aWV3cG9ydDsKPiArCXVpbnQzMl90IHZlcnRleF9idWZmZXI7Cj4gICAJ dWludDMyX3QgYmF0Y2hfZW5kOwo+ICAgCj4gICAJaW50ZWxfYmF0Y2hidWZmZXJfZmx1c2hfd2l0 aF9jb250ZXh0KGJhdGNoLCBjb250ZXh0KTsKPiAgIAo+IC0JYmF0Y2gtPnN0YXRlID0gJmJhdGNo LT5idWZmZXJbQkFUQ0hfU1RBVEVfU1BMSVRdOwo+ICsJYmF0Y2gtPnB0ciA9ICZiYXRjaC0+YnVm ZmVyW0JBVENIX1NUQVRFX1NQTElUXTsKPiAgIAo+ICsKPiArCWJsZW5kX3N0YXRlID0gZ2VuN19j cmVhdGVfYmxlbmRfc3RhdGUoYmF0Y2gpOwo+ICsJY2Nfdmlld3BvcnQgPSBnZW43X2NyZWF0ZV9j Y192aWV3cG9ydChiYXRjaCk7Cj4gKwlwc19zYW1wbGVyX29mZiA9IGdlbjdfY3JlYXRlX3NhbXBs ZXIoYmF0Y2gpOwo+ICsJcHNfa2VybmVsX29mZiA9IGJhdGNoX2NvcHkoYmF0Y2gsIHBzX2tlcm5l bCwgc2l6ZW9mKHBzX2tlcm5lbCksIDY0KTsKPiArCXZlcnRleF9idWZmZXIgPSBnZW43X2NyZWF0 ZV92ZXJ0ZXhfYnVmZmVyKGJhdGNoLAo+ICsJCQkJCQkgIHNyY194LCBzcmNfeSwKPiArCQkJCQkJ ICBkc3RfeCwgZHN0X3ksCj4gKwkJCQkJCSAgd2lkdGgsIGhlaWdodCk7Cj4gKwlwc19iaW5kaW5n X3RhYmxlID0gZ2VuN19iaW5kX3N1cmZhY2VzKGJhdGNoLCBzcmMsIGRzdCk7Cj4gKwo+ICsJaWd0 X2Fzc2VydChiYXRjaC0+cHRyIDwgJmJhdGNoLT5idWZmZXJbNDA5NV0pOwo+ICsKPiArCWJhdGNo LT5wdHIgPSBiYXRjaC0+YnVmZmVyOwo+ICAgCU9VVF9CQVRDSChHRU43X1BJUEVMSU5FX1NFTEVD VCB8IFBJUEVMSU5FX1NFTEVDVF8zRCk7Cj4gICAKPiAgIAlnZW43X2VtaXRfc3RhdGVfYmFzZV9h ZGRyZXNzKGJhdGNoKTsKPiBAQCAtNTU2LDE4ICs1NjksMTggQEAgdm9pZCBnZW43X3JlbmRlcl9j b3B5ZnVuYyhzdHJ1Y3QgaW50ZWxfYmF0Y2hidWZmZXIgKmJhdGNoLAo+ICAgCWdlbjdfZW1pdF93 bShiYXRjaCk7Cj4gICAJZ2VuN19lbWl0X3N0cmVhbW91dChiYXRjaCk7Cj4gICAJZ2VuN19lbWl0 X251bGxfZGVwdGhfYnVmZmVyKGJhdGNoKTsKPiAtCj4gLQlnZW43X2VtaXRfY2MoYmF0Y2gpOwo+ IC0gICAgICAgIGdlbjdfZW1pdF9zYW1wbGVyKGJhdGNoKTsKPiArCWdlbjdfZW1pdF9jYyhiYXRj aCwgYmxlbmRfc3RhdGUsIGNjX3ZpZXdwb3J0KTsKPiArCWdlbjdfZW1pdF9zYW1wbGVyKGJhdGNo LCBwc19zYW1wbGVyX29mZik7Cj4gICAgICAgICAgIGdlbjdfZW1pdF9zYmUoYmF0Y2gpOwo+IC0g ICAgICAgIGdlbjdfZW1pdF9wcyhiYXRjaCk7Cj4gKwlnZW43X2VtaXRfcHMoYmF0Y2gsIHBzX2tl cm5lbF9vZmYpOwo+ICAgICAgICAgICBnZW43X2VtaXRfdmVydGV4X2VsZW1lbnRzKGJhdGNoKTsK PiAtICAgICAgICBnZW43X2VtaXRfdmVydGV4X2J1ZmZlcihiYXRjaCwKPiAtCQkJCXNyY194LCBz cmNfeSwgZHN0X3gsIGRzdF95LCB3aWR0aCwgaGVpZ2h0KTsKPiAtCWdlbjdfZW1pdF9iaW5kaW5n X3RhYmxlKGJhdGNoLCBzcmMsIGRzdCk7Cj4gKwlnZW43X2VtaXRfdmVydGV4X2J1ZmZlcihiYXRj aCwgc3JjX3gsIHNyY195LAo+ICsJCQkJZHN0X3gsIGRzdF95LCB3aWR0aCwKPiArCQkJCWhlaWdo dCwgdmVydGV4X2J1ZmZlcik7Cj4gKwlnZW43X2VtaXRfYmluZGluZ190YWJsZShiYXRjaCwgc3Jj LCBkc3QsIHBzX2JpbmRpbmdfdGFibGUpOwo+ICAgCWdlbjdfZW1pdF9kcmF3aW5nX3JlY3Rhbmds ZShiYXRjaCwgZHN0KTsKPiAgIAo+IC0gICAgICAgIE9VVF9CQVRDSChHRU43XzNEUFJJTUlUSVZF IHwgKDctIDIpKTsKPiArCU9VVF9CQVRDSChHRU43XzNEUFJJTUlUSVZFIHwgKDcgLSAyKSk7Cj4g ICAgICAgICAgIE9VVF9CQVRDSChHRU43XzNEUFJJTUlUSVZFX1ZFUlRFWF9TRVFVRU5USUFMIHwg XzNEUFJJTV9SRUNUTElTVCk7Cj4gICAgICAgICAgIE9VVF9CQVRDSCgzKTsKPiAgICAgICAgICAg T1VUX0JBVENIKDApOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK