From: Peter Senna Tschudin <peter.senna@linux.intel.com>
To: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
igt-dev@lists.freedesktop.org, ryszard.knop@intel.com,
lucas.demarchi@intel.com, katarzyna.piecielska@intel.com,
"Jonathan Cavitt" <jonathan.cavitt@intel.com>
Subject: Re: [PATCH i-g-t v4 1/2] lib/igt_kmemleak: library to interact with kmemleak
Date: Wed, 12 Feb 2025 15:57:09 +0100 [thread overview]
Message-ID: <bd792882-3d64-4afc-bce9-66f2741da3bf@linux.intel.com> (raw)
In-Reply-To: <20250212134137.wiccesysfk2aylmb@kamilkon-desk.igk.intel.com>
On 12.02.2025 14:41, Kamil Konieczny wrote:
> Hi Peter,
> On 2025-02-12 at 14:12:44 +0100, Peter Senna Tschudin wrote:
>>
>>
>> On 12.02.2025 11:01, Zbigniew Kempczyński wrote:
>>> On Wed, Feb 12, 2025 at 10:18:17AM +0100, Peter Senna Tschudin wrote:
>
> [...]
>
>>>> Resume: I prefer to wait until the initial feedback from CI and developers.
>>>> I will be happy to move this to runner later if we decide to not walk the
>>>> unknown road of trying to catch as many transient leaks as we can.
>>>>
>>>> That being said, let me know how to move forward.
>>>
>>> Question is to CI folks, for me this scan should be executed as
>>> dedicated CI run with kmemleak on. And I repeat - I don't see reason
>>> we should add this support to the tests, as few line script which
>>> wraps around test by kmemleak clear/scan is enough. We already have
>>> scripts directory so it is good place for such wrapper.
>>
>> So I am moving the code to the runner directory, and using printf() instead
>> of igt_warn(). Any other request for the series?
>>
>> [...]
>>
>
> or fprintf() or write() so you could write to a file instead
> of stdout, as stdout isn't collected now by runner itself (it
> goes to igt_runnerNN.txt but that is another story).
The errors in question here are exactly about writing to disk, so
I am positive that it only makes sense for them to go to stdout or
stderr. Are you ok with printing an error message instead of trying
to save to disk?
next prev parent reply other threads:[~2025-02-12 14:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 15:15 [PATCH i-g-t v4 0/2] Integrate kmemleak scans in igt_runner Peter Senna Tschudin
2025-01-28 15:15 ` [PATCH i-g-t v4 1/2] lib/igt_kmemleak: library to interact with kmemleak Peter Senna Tschudin
2025-01-31 12:34 ` Kamil Konieczny
2025-02-03 9:23 ` Peter Senna Tschudin
2025-02-11 16:17 ` Zbigniew Kempczyński
2025-02-11 19:12 ` Peter Senna Tschudin
2025-02-12 8:36 ` Zbigniew Kempczyński
2025-02-12 9:18 ` Peter Senna Tschudin
2025-02-12 10:01 ` Zbigniew Kempczyński
2025-02-12 13:12 ` Peter Senna Tschudin
2025-02-12 13:41 ` Kamil Konieczny
2025-02-12 14:57 ` Peter Senna Tschudin [this message]
2025-02-25 13:46 ` Peter Senna Tschudin
2025-02-25 18:06 ` Peter Senna Tschudin
2025-01-31 12:38 ` Kamil Konieczny
2025-02-03 9:14 ` Peter Senna Tschudin
2025-02-12 14:26 ` Kamil Konieczny
2025-01-28 15:15 ` [PATCH i-g-t v4 2/2] runner/executor: Integrate igt_kmemleak scans Peter Senna Tschudin
2025-01-31 12:50 ` Kamil Konieczny
2025-02-03 9:10 ` Peter Senna Tschudin
2025-02-12 14:24 ` Kamil Konieczny
2025-02-12 14:53 ` Peter Senna Tschudin
2025-01-28 20:48 ` ✓ i915.CI.BAT: success for Integrate kmemleak scans in igt_runner (rev2) Patchwork
2025-01-28 20:49 ` Patchwork
2025-01-28 20:52 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-29 10:40 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-29 13:18 ` Peter Senna Tschudin
2025-01-29 11:25 ` ✗ i915.CI.Full: " Patchwork
2025-01-29 13:19 ` Peter Senna Tschudin
2025-01-30 6:18 ` Ravali, JupallyX
2025-01-30 5:26 ` ✓ i915.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd792882-3d64-4afc-bce9-66f2741da3bf@linux.intel.com \
--to=peter.senna@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=katarzyna.piecielska@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=ryszard.knop@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox