From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Kempczynski, Zbigniew" <zbigniew.kempczynski@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "juhapekka.heikkila@gmail.com" <juhapekka.heikkila@gmail.com>
Subject: Re: [PATCH i-g-t] lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces
Date: Thu, 1 Feb 2024 13:49:56 +0000 [thread overview]
Message-ID: <bdb9a8f410fc68c1bb4654fe5466b72bc4c2ce5c.camel@intel.com> (raw)
In-Reply-To: <20240201130904.388276-1-zbigniew.kempczynski@intel.com>
On Thu, 2024-02-01 at 14:09 +0100, Zbigniew Kempczyński wrote:
> Missing setting Kernel0Enable bit results in lack of rasterization
> of right and bottom part of the surface. Fix this as kms tests
> depends
> on that.
Seems to fix the problem with missing pixels on non-modulo-16 surfaces:
Tested-by: Jouni Högander <jouni.hogander@intel.com>
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> lib/rendercopy_gen9.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> index bdfd9be087..a63d5320b3 100644
> --- a/lib/rendercopy_gen9.c
> +++ b/lib/rendercopy_gen9.c
> @@ -863,7 +863,7 @@ gen8_emit_ps(struct intel_bb *ibb, uint32_t
> kernel, bool fast_clear) {
> intel_bb_out(ibb, 0);
>
> intel_bb_out(ibb, GEN7_3DSTATE_PS | (12-2));
> - intel_bb_out(ibb, kernel);
> + intel_bb_out(ibb, kernel | 1);
> intel_bb_out(ibb, 0); /* kernel hi */
>
> if (fast_clear)
next prev parent reply other threads:[~2024-02-01 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 13:09 [PATCH i-g-t] lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces Zbigniew Kempczyński
2024-02-01 13:49 ` Hogander, Jouni [this message]
2024-02-01 14:08 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-02-01 14:09 ` ✓ CI.xeBAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdb9a8f410fc68c1bb4654fe5466b72bc4c2ce5c.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox