Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Govindapillai, Vinod" <vinod.govindapillai@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Hogander, Jouni" <jouni.hogander@intel.com>
Subject: Re: [PATCH i-g-t 2/2] tests/intel/kms_fbt: Remove checking display_ver for fpcpsr tests
Date: Wed, 27 Mar 2024 12:27:28 +0000	[thread overview]
Message-ID: <bdcf2a2255098ee411f9f214acfff1a2511bb509.camel@intel.com> (raw)
In-Reply-To: <20240327054750.159017-2-jouni.hogander@intel.com>

On Wed, 2024-03-27 at 07:47 +0200, Jouni Högander wrote:
> We have now solution to check if fbcpsr tests can be run which works for
> any display version. Remove redundant related display version check.
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  tests/intel/kms_frontbuffer_tracking.c | 7 -------
>  1 file changed, 7 deletions(-)

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> 
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index 6d5395a0c..e45d17dd6 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -2925,13 +2925,6 @@ static void check_test_requirements(const struct test_mode *t)
>  
>         if (opt.only_pipes != PIPE_COUNT)
>                 igt_require(t->pipes == opt.only_pipes);
> -
> -       /* Kernel disables fbc for display versions 12 and 13 if psr is enabled. */
> -       if (drm.display_ver >= 12 && drm.display_ver <= 13)
> -               igt_require_f(!((t->feature & FEATURE_PSR) &&
> -                               (t->feature & FEATURE_FBC)),
> -                             "Can't test PSR and FBC together\n");
> -
>  }
>  
>  static void set_crtc_fbs(const struct test_mode *t)


  reply	other threads:[~2024-03-27 12:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  5:47 [PATCH i-g-t 1/2] tests/intel/kms_fbt: Skip fbcpsr tests on Wa_14016291713 Jouni Högander
2024-03-27  5:47 ` [PATCH i-g-t 2/2] tests/intel/kms_fbt: Remove checking display_ver for fpcpsr tests Jouni Högander
2024-03-27 12:27   ` Govindapillai, Vinod [this message]
2024-03-27  6:29 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] tests/intel/kms_fbt: Skip fbcpsr tests on Wa_14016291713 Patchwork
2024-03-27  6:39 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-27 12:26 ` [PATCH i-g-t 1/2] " Govindapillai, Vinod
2024-03-28 10:32   ` Hogander, Jouni
2024-03-28  1:52 ` ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
2024-03-28 10:23   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdcf2a2255098ee411f9f214acfff1a2511bb509.camel@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox