From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190524072551.24429-1-chris@chris-wilson.co.uk> <20190524084508.28885-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: Date: Fri, 24 May 2019 10:35:18 +0100 MIME-Version: 1.0 In-Reply-To: <20190524084508.28885-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t v2] benchmarks/gem_wsim: Manually calculate VLA struct sizes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDI0LzA1LzIwMTkgMDk6NDUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBcHBhcmVudGx5IFZM QSBzdHJ1Y3RzIChlLmcuIHN0cnVjdCB7IGludCBhcnJheVtjb3VudF0gfSkgaXMgYSBnY2MKPiBl eHRlbnNpb24gdGhhdCBjbGFuZyByZWZ1c2VzIHRvIHN1cHBvcnQgYXMgaGFuZGxpbmcgbWVtb3J5 IGxheW91dCBpcyB0b28KPiBkaWZmaWN1bHQgZm9yIGl0LiBTbyBjYWxjdWxhdGUgdGhlIHNpemUg YnkgaGFuZCEKPiAKPiB2MjogVXNlIGFsbG9jYSgpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgYmVuY2htYXJrcy9nZW1fd3NpbS5j IHwgMTE1ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDY0IGluc2VydGlvbnMoKyksIDUxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9iZW5jaG1hcmtzL2dlbV93c2ltLmMgYi9iZW5jaG1hcmtzL2dlbV93c2ltLmMKPiBp bmRleCBlMmZmYjkzYTkuLmRiMTk5MjViMSAxMDA2NDQKPiAtLS0gYS9iZW5jaG1hcmtzL2dlbV93 c2ltLmMKPiArKysgYi9iZW5jaG1hcmtzL2dlbV93c2ltLmMKPiBAQCAtMTQ0MSw2ICsxNDQxLDI5 IEBAIHNldF9jdHhfc3NldShzdHJ1Y3QgY3R4ICpjdHgsIHVpbnQ2NF90IHNsaWNlX21hc2spCj4g ICAJcmV0dXJuIHNsaWNlX21hc2s7Cj4gICB9Cj4gICAKPiArc3RhdGljIHNpemVfdCBzaXplb2Zf bG9hZF9iYWxhbmNlKGludCBjb3VudCkKPiArewo+ICsJc3RydWN0IGk5MTVfY29udGV4dF9lbmdp bmVzX2xvYWRfYmFsYW5jZSAqcHRyOwo+ICsKPiArCXJldHVybiBzaXplb2YoKnB0cikgKyBjb3Vu dCAqIHNpemVvZihwdHItPmVuZ2luZXNbMF0pOwo+ICt9Cj4gKwo+ICtzdGF0aWMgc2l6ZV90IHNp emVvZl9wYXJhbV9lbmdpbmVzKGludCBjb3VudCkKPiArewo+ICsJc3RydWN0IGk5MTVfY29udGV4 dF9wYXJhbV9lbmdpbmVzICpwdHI7Cj4gKwo+ICsJcmV0dXJuIHNpemVvZigqcHRyKSArIGNvdW50 ICogc2l6ZW9mKHB0ci0+ZW5naW5lc1swXSk7Cj4gK30KPiArCj4gK3N0YXRpYyBzaXplX3Qgc2l6 ZW9mX2VuZ2luZXNfYm9uZChpbnQgY291bnQpCj4gK3sKPiArCXN0cnVjdCBpOTE1X2NvbnRleHRf ZW5naW5lc19ib25kICpwdHI7Cj4gKwo+ICsJcmV0dXJuIHNpemVvZigqcHRyKSArIGNvdW50ICog c2l6ZW9mKHB0ci0+ZW5naW5lc1swXSk7Cj4gK30KPiArCj4gKyNkZWZpbmUgYWxsb2NhMChzeikg KHsgc2l6ZV90IHN6X18gPSAoc3opOyBtZW1zZXQoYWxsb2NhKHN6X18pLCAwLCBzel9fKTsgfSkK PiArCj4gICBzdGF0aWMgaW50Cj4gICBwcmVwYXJlX3dvcmtsb2FkKHVuc2lnbmVkIGludCBpZCwg c3RydWN0IHdvcmtsb2FkICp3cmssIHVuc2lnbmVkIGludCBmbGFncykKPiAgIHsKPiBAQCAtMTY3 Niw2NiArMTY5OSw1NCBAQCBwcmVwYXJlX3dvcmtsb2FkKHVuc2lnbmVkIGludCBpZCwgc3RydWN0 IHdvcmtsb2FkICp3cmssIHVuc2lnbmVkIGludCBmbGFncykKPiAgIAkJfQo+ICAgCj4gICAJCWlm IChjdHgtPmVuZ2luZV9tYXApIHsKPiAtCQkJSTkxNV9ERUZJTkVfQ09OVEVYVF9QQVJBTV9FTkdJ TkVTKHNldF9lbmdpbmVzLAo+IC0JCQkJCQkJICBjdHgtPmVuZ2luZV9tYXBfY291bnQgKyAxKTsK PiAtCQkJSTkxNV9ERUZJTkVfQ09OVEVYVF9FTkdJTkVTX0xPQURfQkFMQU5DRShsb2FkX2JhbGFu Y2UsCj4gLQkJCQkJCQkJIGN0eC0+ZW5naW5lX21hcF9jb3VudCk7Cj4gKwkJCXN0cnVjdCBpOTE1 X2NvbnRleHRfcGFyYW1fZW5naW5lcyAqc2V0X2VuZ2luZXMgPQo+ICsJCQkJYWxsb2NhMChzaXpl b2ZfcGFyYW1fZW5naW5lcyhjdHgtPmVuZ2luZV9tYXBfY291bnQgKyAxKSk7Cj4gKwkJCXN0cnVj dCBpOTE1X2NvbnRleHRfZW5naW5lc19sb2FkX2JhbGFuY2UgKmxvYWRfYmFsYW5jZSA9Cj4gKwkJ CQlhbGxvY2EwKHNpemVvZl9sb2FkX2JhbGFuY2UoY3R4LT5lbmdpbmVfbWFwX2NvdW50KSk7Cj4g ICAJCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW0gcGFyYW0gPSB7Cj4gICAJCQkJ LmN0eF9pZCA9IGN0eF9pZCwKPiAgIAkJCQkucGFyYW0gPSBJOTE1X0NPTlRFWFRfUEFSQU1fRU5H SU5FUywKPiAtCQkJCS5zaXplID0gc2l6ZW9mKHNldF9lbmdpbmVzKSwKPiAtCQkJCS52YWx1ZSA9 IHRvX3VzZXJfcG9pbnRlcigmc2V0X2VuZ2luZXMpLAo+ICsJCQkJLnNpemUgPSBzaXplb2ZfcGFy YW1fZW5naW5lcyhjdHgtPmVuZ2luZV9tYXBfY291bnQgKyAxKSwKPiArCQkJCS52YWx1ZSA9IHRv X3VzZXJfcG9pbnRlcihzZXRfZW5naW5lcyksCj4gICAJCQl9Owo+ICsJCQlzdHJ1Y3QgaTkxNV9j b250ZXh0X2VuZ2luZXNfYm9uZCAqbGFzdCA9IE5VTEw7Cj4gICAKPiAgIAkJCWlmIChjdHgtPndh bnRzX2JhbGFuY2UpIHsKPiAtCQkJCXNldF9lbmdpbmVzLmV4dGVuc2lvbnMgPQo+IC0JCQkJCXRv X3VzZXJfcG9pbnRlcigmbG9hZF9iYWxhbmNlKTsKPiArCQkJCXNldF9lbmdpbmVzLT5leHRlbnNp b25zID0KPiArCQkJCQl0b191c2VyX3BvaW50ZXIobG9hZF9iYWxhbmNlKTsKPiAgIAo+IC0JCQkJ bWVtc2V0KCZsb2FkX2JhbGFuY2UsIDAsIHNpemVvZihsb2FkX2JhbGFuY2UpKTsKPiAtCQkJCWxv YWRfYmFsYW5jZS5iYXNlLm5hbWUgPQo+ICsJCQkJbG9hZF9iYWxhbmNlLT5iYXNlLm5hbWUgPQo+ ICAgCQkJCQlJOTE1X0NPTlRFWFRfRU5HSU5FU19FWFRfTE9BRF9CQUxBTkNFOwo+IC0JCQkJbG9h ZF9iYWxhbmNlLm51bV9zaWJsaW5ncyA9Cj4gKwkJCQlsb2FkX2JhbGFuY2UtPm51bV9zaWJsaW5n cyA9Cj4gICAJCQkJCWN0eC0+ZW5naW5lX21hcF9jb3VudDsKPiAgIAo+ICAgCQkJCWZvciAoaiA9 IDA7IGogPCBjdHgtPmVuZ2luZV9tYXBfY291bnQ7IGorKykKPiAtCQkJCQlsb2FkX2JhbGFuY2Uu ZW5naW5lc1tqXSA9Cj4gKwkJCQkJbG9hZF9iYWxhbmNlLT5lbmdpbmVzW2pdID0KPiAgIAkJCQkJ CWdldF9lbmdpbmUoY3R4LT5lbmdpbmVfbWFwW2pdKTsKPiAtCQkJfSBlbHNlIHsKPiAtCQkJCXNl dF9lbmdpbmVzLmV4dGVuc2lvbnMgPSAwOwo+ICAgCQkJfQo+ICAgCj4gICAJCQkvKiBSZXNlcnZl IHNsb3QgZm9yIHZpcnR1YWwgZW5naW5lLiAqLwo+IC0JCQlzZXRfZW5naW5lcy5lbmdpbmVzWzBd LmVuZ2luZV9jbGFzcyA9Cj4gKwkJCXNldF9lbmdpbmVzLT5lbmdpbmVzWzBdLmVuZ2luZV9jbGFz cyA9Cj4gICAJCQkJSTkxNV9FTkdJTkVfQ0xBU1NfSU5WQUxJRDsKPiAtCQkJc2V0X2VuZ2luZXMu ZW5naW5lc1swXS5lbmdpbmVfaW5zdGFuY2UgPQo+ICsJCQlzZXRfZW5naW5lcy0+ZW5naW5lc1sw XS5lbmdpbmVfaW5zdGFuY2UgPQo+ICAgCQkJCUk5MTVfRU5HSU5FX0NMQVNTX0lOVkFMSURfTk9O RTsKPiAgIAo+ICAgCQkJZm9yIChqID0gMTsgaiA8PSBjdHgtPmVuZ2luZV9tYXBfY291bnQ7IGor KykKPiAtCQkJCXNldF9lbmdpbmVzLmVuZ2luZXNbal0gPQo+ICsJCQkJc2V0X2VuZ2luZXMtPmVu Z2luZXNbal0gPQo+ICAgCQkJCQlnZXRfZW5naW5lKGN0eC0+ZW5naW5lX21hcFtqIC0gMV0pOwo+ ICAgCj4gKwkJCWxhc3QgPSBOVUxMOwo+ICAgCQkJZm9yIChqID0gMDsgaiA8IGN0eC0+Ym9uZF9j b3VudDsgaisrKSB7Cj4gICAJCQkJdW5zaWduZWQgbG9uZyBtYXNrID0gY3R4LT5ib25kc1tqXS5t YXNrOwo+IC0JCQkJSTkxNV9ERUZJTkVfQ09OVEVYVF9FTkdJTkVTX0JPTkQoYm9uZCwKPiAtCQkJ CQkJCQkgX19idWlsdGluX3BvcGNvdW50KG1hc2spKTsKPiAtCQkJCXN0cnVjdCBpOTE1X2NvbnRl eHRfZW5naW5lc19ib25kICpwID0gTlVMTCwgKnByZXY7Cj4gKwkJCQlzdHJ1Y3QgaTkxNV9jb250 ZXh0X2VuZ2luZXNfYm9uZCAqYm9uZCA9Cj4gKwkJCQkJYWxsb2NhMChzaXplb2ZfZW5naW5lc19i b25kKF9fYnVpbHRpbl9wb3Bjb3VudChtYXNrKSkpOwo+ICAgCQkJCXVuc2lnbmVkIGludCBiLCBl Owo+ICAgCj4gLQkJCQlwcmV2ID0gcDsKPiAtCQkJCXAgPSBhbGxvY2Eoc2l6ZW9mKGJvbmQpKTsK PiAtCQkJCWFzc2VydChwKTsKPiAtCQkJCW1lbXNldChwLCAwLCBzaXplb2YoYm9uZCkpOwo+ICsJ CQkJYm9uZC0+YmFzZS5uZXh0X2V4dGVuc2lvbiA9IHRvX3VzZXJfcG9pbnRlcihsYXN0KTsKPiAr CQkJCWJvbmQtPmJhc2UubmFtZSA9IEk5MTVfQ09OVEVYVF9FTkdJTkVTX0VYVF9CT05EOwo+ICAg Cj4gLQkJCQlpZiAoaiA9PSAwKQo+IC0JCQkJCWxvYWRfYmFsYW5jZS5iYXNlLm5leHRfZXh0ZW5z aW9uID0KPiAtCQkJCQkJdG9fdXNlcl9wb2ludGVyKHApOwo+IC0JCQkJZWxzZSBpZiAoaiA8IChj dHgtPmJvbmRfY291bnQgLSAxKSkKPiAtCQkJCQlwcmV2LT5iYXNlLm5leHRfZXh0ZW5zaW9uID0K PiAtCQkJCQkJdG9fdXNlcl9wb2ludGVyKHApOwo+IC0KPiAtCQkJCXAtPmJhc2UubmFtZSA9IEk5 MTVfQ09OVEVYVF9FTkdJTkVTX0VYVF9CT05EOwo+IC0JCQkJcC0+dmlydHVhbF9pbmRleCA9IDA7 Cj4gLQkJCQlwLT5tYXN0ZXIgPSBnZXRfZW5naW5lKGN0eC0+Ym9uZHNbal0ubWFzdGVyKTsKPiAr CQkJCWJvbmQtPnZpcnR1YWxfaW5kZXggPSAwOwo+ICsJCQkJYm9uZC0+bWFzdGVyID0gZ2V0X2Vu Z2luZShjdHgtPmJvbmRzW2pdLm1hc3Rlcik7Cj4gICAKPiAgIAkJCQlmb3IgKGIgPSAwLCBlID0g MDsgbWFzazsgZSsrLCBtYXNrID4+PSAxKSB7Cj4gICAJCQkJCXVuc2lnbmVkIGludCBpZHg7Cj4g QEAgLTE3NDMsNDIgKzE3NTQsNDQgQEAgcHJlcGFyZV93b3JrbG9hZCh1bnNpZ25lZCBpbnQgaWQs IHN0cnVjdCB3b3JrbG9hZCAqd3JrLCB1bnNpZ25lZCBpbnQgZmxhZ3MpCj4gICAJCQkJCWlmICgh KG1hc2sgJiAxKSkKPiAgIAkJCQkJCWNvbnRpbnVlOwo+ICAgCj4gLQkJCQkJaWR4ID0gZmluZF9l bmdpbmUoJnNldF9lbmdpbmVzLmVuZ2luZXNbMV0sCj4gKwkJCQkJaWR4ID0gZmluZF9lbmdpbmUo JnNldF9lbmdpbmVzLT5lbmdpbmVzWzFdLAo+ICAgCQkJCQkJCSAgY3R4LT5lbmdpbmVfbWFwX2Nv dW50LAo+ICAgCQkJCQkJCSAgZSk7Cj4gLQkJCQkJcC0+ZW5naW5lc1tiKytdID0KPiAtCQkJCQkJ c2V0X2VuZ2luZXMuZW5naW5lc1sxICsgaWR4XTsKPiArCQkJCQlib25kLT5lbmdpbmVzW2IrK10g PQo+ICsJCQkJCQlzZXRfZW5naW5lcy0+ZW5naW5lc1sxICsgaWR4XTsKPiAgIAkJCQl9Cj4gKwo+ ICsJCQkJbGFzdCA9IGJvbmQ7Cj4gICAJCQl9Cj4gKwkJCWxvYWRfYmFsYW5jZS0+YmFzZS5uZXh0 X2V4dGVuc2lvbiA9IHRvX3VzZXJfcG9pbnRlcihsYXN0KTsKPiAgIAo+ICAgCQkJZ2VtX2NvbnRl eHRfc2V0X3BhcmFtKGZkLCAmcGFyYW0pOwo+ICAgCQl9IGVsc2UgaWYgKGN0eC0+d2FudHNfYmFs YW5jZSkgewo+ICAgCQkJY29uc3QgdW5zaWduZWQgaW50IGNvdW50ID0gbnVtX2VuZ2luZXNfaW5f Y2xhc3MoVkNTKTsKPiAtCQkJSTkxNV9ERUZJTkVfQ09OVEVYVF9FTkdJTkVTX0xPQURfQkFMQU5D RShsb2FkX2JhbGFuY2UsCj4gLQkJCQkJCQkJIGNvdW50KTsKPiAtCQkJSTkxNV9ERUZJTkVfQ09O VEVYVF9QQVJBTV9FTkdJTkVTKHNldF9lbmdpbmVzLAo+IC0JCQkJCQkJICBjb3VudCArIDEpOwo+ ICsJCQlzdHJ1Y3QgaTkxNV9jb250ZXh0X2VuZ2luZXNfbG9hZF9iYWxhbmNlICpsb2FkX2JhbGFu Y2UgPQo+ICsJCQkJYWxsb2NhMChzaXplb2ZfbG9hZF9iYWxhbmNlKGNvdW50KSk7Cj4gKwkJCXN0 cnVjdCBpOTE1X2NvbnRleHRfcGFyYW1fZW5naW5lcyAqc2V0X2VuZ2luZXMgPQo+ICsJCQkJYWxs b2NhMChzaXplb2ZfcGFyYW1fZW5naW5lcyhjb3VudCArIDEpKTsKPiAgIAkJCXN0cnVjdCBkcm1f aTkxNV9nZW1fY29udGV4dF9wYXJhbSBwYXJhbSA9IHsKPiAgIAkJCQkuY3R4X2lkID0gY3R4X2lk LAo+ICAgCQkJCS5wYXJhbSA9IEk5MTVfQ09OVEVYVF9QQVJBTV9FTkdJTkVTLAo+IC0JCQkJLnNp emUgPSBzaXplb2Yoc2V0X2VuZ2luZXMpLAo+IC0JCQkJLnZhbHVlID0gdG9fdXNlcl9wb2ludGVy KCZzZXRfZW5naW5lcyksCj4gKwkJCQkuc2l6ZSA9IHNpemVvZl9wYXJhbV9lbmdpbmVzKGNvdW50 ICsgMSksCj4gKwkJCQkudmFsdWUgPSB0b191c2VyX3BvaW50ZXIoc2V0X2VuZ2luZXMpLAo+ICAg CQkJfTsKPiAgIAo+IC0JCQlzZXRfZW5naW5lcy5leHRlbnNpb25zID0gdG9fdXNlcl9wb2ludGVy KCZsb2FkX2JhbGFuY2UpOwo+ICsJCQlzZXRfZW5naW5lcy0+ZXh0ZW5zaW9ucyA9IHRvX3VzZXJf cG9pbnRlcihsb2FkX2JhbGFuY2UpOwo+ICAgCj4gLQkJCXNldF9lbmdpbmVzLmVuZ2luZXNbMF0u ZW5naW5lX2NsYXNzID0KPiArCQkJc2V0X2VuZ2luZXMtPmVuZ2luZXNbMF0uZW5naW5lX2NsYXNz ID0KPiAgIAkJCQlJOTE1X0VOR0lORV9DTEFTU19JTlZBTElEOwo+IC0JCQlzZXRfZW5naW5lcy5l bmdpbmVzWzBdLmVuZ2luZV9pbnN0YW5jZSA9Cj4gKwkJCXNldF9lbmdpbmVzLT5lbmdpbmVzWzBd LmVuZ2luZV9pbnN0YW5jZSA9Cj4gICAJCQkJSTkxNV9FTkdJTkVfQ0xBU1NfSU5WQUxJRF9OT05F Owo+IC0JCQlmaWxsX2VuZ2luZXNfY2xhc3MoJnNldF9lbmdpbmVzLmVuZ2luZXNbMV0sIFZDUyk7 Cj4gKwkJCWZpbGxfZW5naW5lc19jbGFzcygmc2V0X2VuZ2luZXMtPmVuZ2luZXNbMV0sIFZDUyk7 Cj4gICAKPiAtCQkJbWVtc2V0KCZsb2FkX2JhbGFuY2UsIDAsIHNpemVvZihsb2FkX2JhbGFuY2Up KTsKPiAtCQkJbG9hZF9iYWxhbmNlLmJhc2UubmFtZSA9Cj4gKwkJCWxvYWRfYmFsYW5jZS0+YmFz ZS5uYW1lID0KPiAgIAkJCQlJOTE1X0NPTlRFWFRfRU5HSU5FU19FWFRfTE9BRF9CQUxBTkNFOwo+ IC0JCQlsb2FkX2JhbGFuY2UubnVtX3NpYmxpbmdzID0gY291bnQ7Cj4gKwkJCWxvYWRfYmFsYW5j ZS0+bnVtX3NpYmxpbmdzID0gY291bnQ7Cj4gICAKPiAtCQkJZmlsbF9lbmdpbmVzX2NsYXNzKCZs b2FkX2JhbGFuY2UuZW5naW5lc1swXSwgVkNTKTsKPiArCQkJZmlsbF9lbmdpbmVzX2NsYXNzKCZs b2FkX2JhbGFuY2UtPmVuZ2luZXNbMF0sIFZDUyk7Cj4gICAKPiAgIAkJCWdlbV9jb250ZXh0X3Nl dF9wYXJhbShmZCwgJnBhcmFtKTsKPiAgIAkJfQo+IAoKU2VlbXMgY29ycmVjdC4KCllvdSBjb3Vs ZG4ndCByZXNpc3QgdGhyb3dpbmcgaW4gdGhlIHJldmVyc2UgYm9uZCBsaXN0IGJ1aWxkaW5nIApz aW1wbGlmaWNhdGlvbiBhcyB3ZWxsLiA6KQoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0Cmln dC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==