From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20DF66E2F8 for ; Fri, 22 Mar 2019 09:56:52 +0000 (UTC) References: <20190321160528.4131-1-andi.shyti@intel.com> <20190321160528.4131-5-andi.shyti@intel.com> <6b531677-8e74-c51c-535a-bb5e1c1f2ac7@linux.intel.com> <155324155883.26447.7921522281863006035@skylake-alporthouse-com> From: Tvrtko Ursulin Message-ID: Date: Fri, 22 Mar 2019 09:56:49 +0000 MIME-Version: 1.0 In-Reply-To: <155324155883.26447.7921522281863006035@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v15 4/5] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDIyLzAzLzIwMTkgMDc6NTksIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTIyIDA3OjQ3OjAyKQo+Pgo+PiBPbiAyMS8wMy8yMDE5IDE2OjA1 LCBBbmRpIFNoeXRpIHdyb3RlOgo+Pj4gK3sKPj4+ICsgICAgIHN0YXRpYyBjb25zdCBjaGFyICp1 bmtub3duX25hbWUgPSAidW5rbm93biIsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAqdmly dHVhbF9uYW1lID0gInZpcnR1YWwiOwo+Pgo+PiBVbnVzdWFsIHN0eWxlIGJ1dCBpdCBpcyBhY3R1 YWxseSByZWFkYWJsZSBzbyBJIHRoaW5rIEkgbGlrZSBpdC4KPiAKPiBCYWgsIGlmIEkgY2FuJ3Qg ZmluZCBhIGNpbm89IHNldHRpbmcsIEknbSBub3QgYWRvcHRpbmcgaXQgOykKPiAKPj4+ICsKPj4+ ICsgICAgIGUyLT5jbGFzcyAgICA9IGNsYXNzOwo+Pj4gKyAgICAgZTItPmluc3RhbmNlID0gaW5z dGFuY2U7Cj4+PiArICAgICBlMi0+ZmxhZ3MgICAgPSBmbGFnczsKPj4+ICsKPj4+ICsgICAgIGlm IChjbGFzcyA8IDAgJiYgaW5zdGFuY2UgPCAwKSB7Cj4+PiArICAgICAgICAgICAgIGUyLT5uYW1l ID0gdmlydHVhbF9uYW1lOwo+Pj4gKyAgICAgfSBlbHNlIHsKPj4+ICsgICAgICAgICAgICAgY29u c3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICpfX2UyOwo+Pj4gKwo+Pj4gKyAgICAg ICAgICAgICBfX2Zvcl9lYWNoX3N0YXRpY19lbmdpbmUoX19lMikKPj4+ICsgICAgICAgICAgICAg ICAgICAgICBpZiAoX19lMi0+Y2xhc3MgPT0gY2xhc3MgJiYgX19lMi0+aW5zdGFuY2UgPT0gaW5z dGFuY2UpCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPj4+ICsKPj4+ ICsgICAgICAgICAgICAgZTItPm5hbWUgPSBfX2UyLT5uYW1lID8gX19lMi0+bmFtZSA6IHVua25v d25fbmFtZTsKPj4KPj4gSSd2ZSBub3cgc3RhcnRlZCB0byB3b3JyeSBhYm91dCBob3cgd2lsbCBD SS9idWdsb2cgaGFuZGxlIHVzIGZvcmdldHRpbmcKPj4gdG8gZXhwYW5kIHRoZSBzdGF0aWMgbGlz dC4gKE1vcmUgdGhhbiBvbmUgc3VidGVzdCBvZiBhIHNhbWUgbmFtZSBmb3IKPj4gInRlc3QtJGVu Z2luZV9uYW1lIiBvbmVzPykgRG8gd2Ugd2FudCBhbmQgaWd0X3dhcm4gb24gdW5rbm93biBlbmdp bmVzIHRvCj4+IG1ha2UgaXQgbW9yZSB2aXNpYmxlPyBPciBldmVuIGp1c3QgY3Jhc2g/Cj4gCj4g U2V0IGZsYWdzIHRvIC0xdWxsLiBUaGF0IHNob3VsZCBjYXVzZSBFSU5WQUwgZm9yZXZlciBvbmUg aG9wZXMuCj4gCj4gV2Ugc2hvdWxkbid0IGdldCBhbnkgdGVzdCAoYXRtKSB3aXRoIHVua25vd24g YXMgd2Ugb25seSB1c2UgdGhlIHN0YXRpYwo+IHRhYmxlIGZvciB0ZXN0IGdlbmVyYXRpb24uIEZv ciBydW50aW1lIHRlc3QgZGlzY292ZXJ5LCB3ZSBjYW4gYXBwbHkgdGhlCj4gZmlsdGVyIG9mIGRv ZXMgdGhpcyBlbmdpbmUgYWN0dWFsbHkgZXhpc3QuCgpZZXMgSSBnb3QgY29uZnVzZWQuCgo+Pj4g K3ZvaWQgaW50ZWxfbmV4dF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2luZV9kYXRhICplZCk7Cj4+ PiArCj4+PiArI2RlZmluZSBJU19QSFlTSUNBTF9FTkdJTkUoZTIpICgoZTItPmNsYXNzID49IDAp ICYmIChlMi0+aW5zdGFuY2UgPj0gMCkpCj4+Cj4+IENocmlzLCBkbyB5b3UgdGhpbmsgdGhpcyB3 aWxsIGJlIGZ1dHVyZSBwcm9vZiBlbm91Z2g/Cj4gCj4gQXQgdGhlIG1vbWVudCwgd2UndmUgcmVz ZXJ2ZWQganVzdCB0aGUgb25lIGlkZW50aWZpZXIgZm9yIHBsYWNlaG9sZGVycwo+IChjbGFzcyA9 PSBJOTE1X0VOR0lORV9DTEFTU19JTlZBTElEKS4gQW5kIEkgZmVlbCBjb25maWRlbnQgdGhhdCBz aG91bGQKPiBiZSBlbm91Z2guCj4gCj4gVGhlIHByb2JsZW0gaXMgaWYgc29tZXRoaW5nIGVsc2Ug Z2F2ZSB1cyBtdWx0aXBsZSBpbnN0YW5jZXMgb2YgYSBsb2dpY2FsCj4gZW5naW5lIGZvciB3aGlj aCB3ZSBoYXZlIG5vIG1lYW5zIHRvIGRldGVybWluZSB0aGUgcGh5c2ljYWwgbWFwcGluZywKPiB3 aGljaCBpcyB2dnYKPiAKPj4gSSByZW1lbWJlcmVkIGhvdyBhdCBvbmUgcG9pbnQgSSBoYWQgIklT X1BIWVNJQ0FMIiBhcyBhIGZsYWcgaW4gZW5naW5lIHF1ZXJ5Lgo+Pgo+PiBPciB3ZSBtYWtlIHRo aXMgaGVyZSBtb3JlIGV4cGxpY2l0IGJ5IGJlaW5nICJJU19WSVJUVUFMIiBhbmQgaW52ZXJ0IHRo ZQo+PiB0ZXN0IGluIHRoZSBjYWxsZXI/Cj4gCj4gQXllLiBJIHRoaW5rIHlvdSBhcmUgcmlnaHQg aGVyZSwgYW5kIHdlIG5lZWQgdG8gcHV0IGEgY2FwcyBmaWVsZCBpbnRvCj4gdGhlIGVuZ2luZV9k YXRhIChmaWxsZWQgaW4gYnkgaTkxNV9xdWVyeSBmb3IgdmFsaWQgY2xhc3NlcyBhbmQgZGVmYXVs dAo+IHRvICFwaHlzIGZvciBpbnZhbGlkIHNsb3RzKS4gQSBsb3Qgb2YgdGhlIGZvcl9lYWNoX3Bo eXNpY2FsX2VuZ2luZSgpCj4gdGVzdHMgZG8gbm90IG1ha2Ugc2Vuc2UgaWYgdGhlcmUgaXMgYXV0 b21hZ2ljIGVuZ2luZSBtYXBwaW5nIGdvaW5nIG9uCj4gYmVoaW5kIHRoZSBzY2VuZXMuCgpZb3Ug YXJlIHNpbXBseSBzYXlpbmcgdG8gbW92ZSB0aGUgIklTX1BIWUlTSUNBTCIgdGVzdCB0byBpbml0 X2VuZ2luZSAKaGVyZSBhbmQgc3RvcmUgaXQgaW4gYSBmbGFnIHBlciBlbmdpbmU/CgpSZWdhcmRz LAoKVHZydGtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2