From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCC1C6E022 for ; Fri, 21 Dec 2018 11:48:44 +0000 (UTC) References: <49a265f3-c714-f4ec-7d49-d0eff5be4714@linux.intel.com> <20181214153452.4845-1-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: Date: Fri, 21 Dec 2018 11:48:42 +0000 MIME-Version: 1.0 In-Reply-To: <20181214153452.4845-1-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v3.5 2/3] lib: implement new engine discovery interface List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti Cc: IGT dev , Andi Shyti , Tvrtko Ursulin List-ID: Ck9uIDE0LzEyLzIwMTggMTU6MzQsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gSGkgVHZydGtvLAo+IAo+ IHdvdWxkIHRoZSBmb2xsb3dpbmcgcGF0Y2ggd29yaz8gdGhlICJmb3JfZWFjaF9lbmdpbmVfY3R4 KCkiIGdldHMKPiBhbiBhcmd1bWVudCBtb3JlIHRoYXQgaXMgYSBkb3VibGUgcG9pbnRlciB0byBh ICJzdHJ1Y3QKPiBpbnRlbF9leGVjdXRpb25fZW5naW5lMiIuCj4gCj4gVGhlIF9fZ2VtX3NldHVw X2N0eF9lbmdpbmVzKCkgZnVuY3Rpb24gYWxsb2NhdGVzIGFuIGFycmF5IG9mCj4gZW5naW5lcyB3 aGVyZSBpdCBzdG9yZXMgdGhlIGVuZ2luZXMgcHJlc2VudCBpbiB0aGUgR1BVLgo+IAo+IFRoZSBu ZXcgaXRlcmF0b3IgY2FuIGJlIHVzZWQgZWl0aGVyOgo+IAo+ICAgIC4uLgo+ICAgIHN0cnVjdCBp bnRlbF9leGVjdXRpb25fZW5naW5lMiAqZW5naW5lczsKPiAKPiAgICBmb3JfZWFjaF9lbmdpbmVf Y3R4KGZkLCBjdHhfaWQsIHIsICZlbmdpbmVzKSB7Cj4gICAgICBwcmludGYoImVuZ2luZSAlZCBp cyAlc1xuIiwgciwgZW5naW5lc1tyXS5uYW1lKTsKPiAgICB9Cj4gCj4gb3IsIGlmIHRoZSB1c2Vy IGlzIG5vdCBpbnRlcmVzdGVkIGF0IGdldHRpbmcgdGhlIHN0cnVjdHVyZSwgY2FuCj4gc2VuZCBO VUxMIGluc3RlYWQgYW5kIGdldCBub3RoaW5nLgo+IAo+ICAgIGZvcl9lYWNoX2VuZ2luZV9jdHgo ZmQsIGN0eF9pZCwgciwgTlVMTCkgewo+ICAgICAgLi4uCj4gICAgfQo+IAo+IElzIHRoaXMgd2hh dCB5b3UgbWVhbnQgdG8gZ2V0IGZyb20gdGhlIGtlcm5lbD8KCkkgd2FzIHRoaW5raW5nIHRoYXQg ZWl0aGVyIG9uIHRoZSBmaXJzdCBjYWxsIHRvIHRoZSBuZXcgaXRlcmF0b3IsIG9yIApzb21ld2hl cmUgZnJvbSBkcm0gZmQgb3Blbiwgd2Ugd291bGQgY3JlYXRlIHRoaXMgZHluYW1pYyBhcnJheSwg CnJlcGxhY2luZyB0aGUgZXhpc3Rpbmcgc3RhdGljIGFycmF5IGluIGxpYi9pZ3RfZ3QuYy4KClNv IHdlIHdvdWxkbid0IGhhdmUgdGhpcyBleHRyYSBwYXJhbWV0ZXIgdG8gdGhlIGl0ZXJhdG9yLgoK QW5vdGhlciBub3RlIC0gc2VlIHRvIGNvbnZlcnQgZm9yX2VhY2hfZW5naW5lX2NsYXNzX2luc3Rh bmNlIHRvIHRoZSBuZXcgCnNjaGVtZSBhbmQgYWxzbyBhbGwgcGxhY2VzIHdoaWNoIHVzZSBQTVUg dG8gcHJvYmUgZm9yIGVuZ2luZSBleGlzdGVuY2UuIAooQ291bGQgYmUgb25seSBwZXJmX3BtdSBp cyB1cHN0cmVhbSB3aGljaCBkb2VzIGl0LikKCkJhc2ljYWxseSBhbGwgY29kZSB3aGljaCB1c2Vz IGdlbV9jbGFzc19pbnN0YW5jZV90b19lYl9mbGFncyBuZWVkcyB0byBiZSAKY29udmVydGVkIHRv IHRoZSBlbmdpbmUgbWFwIGFwcHJvYWNoIGFuZCB0aGF0IGhlbHBlciByZW1vdmVkLgoKQ2FuIGJl IGEgc2Vjb25kIHN0YWdlIHRvZ2V0aGVyIHdpdGggZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lIGNv bnZlcnNpb24uCgpSZWdhcmRzLAoKVHZydGtvCgo+IAo+IFRoYW5rcywKPiBBbmRpCj4gCj4gLS0t Cj4gICBsaWIvaWd0X2d0LmMgfCA5OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4gICBsaWIvaWd0X2d0LmggfCAgNiArKysrCj4gICAyIGZpbGVz IGNoYW5nZWQsIDEwNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZ3Qu YyBiL2xpYi9pZ3RfZ3QuYwo+IGluZGV4IGEyMDYxOTI0NjI5Ni4uODYxNmRiYTQ0ZjEzIDEwMDY0 NAo+IC0tLSBhL2xpYi9pZ3RfZ3QuYwo+ICsrKyBiL2xpYi9pZ3RfZ3QuYwo+IEBAIC02NTAsMyAr NjUwLDEwMiBAQCBib29sIGdlbV9yaW5nX2hhc19waHlzaWNhbF9lbmdpbmUoaW50IGZkLCB1bnNp Z25lZCByaW5nKQo+ICAgCj4gICAJcmV0dXJuIGdlbV9oYXNfcmluZyhmZCwgcmluZyk7Cj4gICB9 Cj4gKwo+ICtzdGF0aWMgc3RydWN0IGRybV9pOTE1X3F1ZXJ5X2VuZ2luZV9pbmZvICpxdWVyeV9l bmdpbmVzKGludCBmZCkKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3F1ZXJ5IHF1ZXJ5ID0geyB9 Owo+ICsJc3RydWN0IGRybV9pOTE1X3F1ZXJ5X2l0ZW0gaXRlbSA9IHsgfTsKPiArCXN0cnVjdCBk cm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbyAqcXVlcnlfZW5naW5lczsKPiArCj4gKwlpdGVtLnF1 ZXJ5X2lkID0gRFJNX0k5MTVfUVVFUllfRU5HSU5FX0lORk87Cj4gKwlxdWVyeS5pdGVtc19wdHIg PSB0b191c2VyX3BvaW50ZXIoJml0ZW0pOwo+ICsJcXVlcnkubnVtX2l0ZW1zID0gMTsKPiArCj4g KwkvKgo+ICsJICogVGhlIGZpcnN0IGlvY3RsIGlzIHNlbnQgd2l0aCBpdGVtLmxlbmd0aCA9IDAK PiArCSAqIHdoaWNoIGFza3MgdG8gdGhlIGRyaXZlciB0byBzdG9yZSBpbiBsZW5ndGggdGhlCj4g KwkgKiBtZW1vcnkgbmVlZGVkIGZvciB0aGUgZW5naW5lcy4gSW4gdGhlIGRyaXZlciwgbGVuZ3Ro Cj4gKwkgKiBpcyBlcXVhbCB0bwo+ICsJICoKPiArCSAqICAgbGVuID0gc2l6ZW9mKHN0cnVjdCBk cm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbykgKwo+ICsJICogICAgICAgICAgICAgICAgICAgSU5U RUxfSU5GTyhpOTE1KS0+bnVtX3JpbmdzICoKPiArCSAqICAgICAgICAgICAgICAgICAgIHNpemVv ZihzdHJ1Y3QgZHJtX2k5MTVfZW5naW5lX2luZm8pOwo+ICsJICovCj4gKwlpZ3RfcmVxdWlyZSgh aW9jdGwoZmQsIERSTV9JT0NUTF9JOTE1X1FVRVJZLCAmcXVlcnkpKTsKPiArCj4gKwlpZ3RfYXNz ZXJ0KChxdWVyeV9lbmdpbmVzID0gY2FsbG9jKGl0ZW0ubGVuZ3RoLCAxKSkpOwo+ICsJaXRlbS5k YXRhX3B0ciA9IHRvX3VzZXJfcG9pbnRlcihxdWVyeV9lbmdpbmVzKTsKPiArCj4gKwkvKiBUaGUg c2Vjb25kIGlvY3RsIHN0b3JlcyB0aGUgZW5naW5lcyBpbiBxdWVyeV9lbmdpbmVzICovCj4gKwlp Z3RfcmVxdWlyZSghaW9jdGwoZmQsIERSTV9JT0NUTF9JOTE1X1FVRVJZLCAmcXVlcnkpKTsKPiAr Cj4gKwlyZXR1cm4gcXVlcnlfZW5naW5lczsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgc3RvcmVf ZW5naW5lKHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqdG8sCj4gKwkJCSBzdHJ1Y3Qg ZHJtX2k5MTVfZW5naW5lX2luZm8gKmZyb20pCj4gK3sKPiArCWludCBpOwo+ICsKPiArCWZvciAo aSA9IDA7IGkgPCBBUlJBWV9TSVpFKGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMik7IGkrKykKPiAr CQlpZiAoZnJvbS0+Y2xhc3MgPT0gaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyW2ldLmNsYXNzICYm Cj4gKwkJICAgIGZyb20tPmluc3RhbmNlID09IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMltpXS5p bnN0YW5jZSkgewo+ICsJCQl0by0+bmFtZSA9IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMltpXS5u YW1lOwo+ICsJCQl0by0+aW5zdGFuY2UgPSBpbnRlbF9leGVjdXRpb25fZW5naW5lczJbaV0uaW5z dGFuY2U7Cj4gKwkJCXRvLT5jbGFzcyA9IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMltpXS5jbGFz czsKPiArCQl9Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHNldF9wYXJhbShpbnQgZmQsIHVpbnQz Ml90IGN0eF9pZCwKPiArCQkgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5lX2luZm8g KnF1ZXJ5X2VuZ2luZSwKPiArCQkgICAgICBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIg KmVuZ2luZXMpCj4gK3sKPiArCWludCBpOwo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0 X3BhcmFtIGN0eF9wYXJhbTsKPiArCXN0cnVjdCBpOTE1X2NvbnRleHRfcGFyYW1fZW5naW5lcyAq Y3R4X2VuZ2luZTsKPiArCXNpemVfdCBzaXplID0gc2l6ZW9mKHN0cnVjdCBpOTE1X2NvbnRleHRf cGFyYW1fZW5naW5lcykgKwo+ICsJCSAgICAgIHF1ZXJ5X2VuZ2luZS0+bnVtX2VuZ2luZXMgKgo+ ICsJCSAgICAgIHNpemVvZigqY3R4X2VuZ2luZS0+Y2xhc3NfaW5zdGFuY2UpOwo+ICsKPiArCWln dF9hc3NlcnQoKGN0eF9lbmdpbmUgPSBtYWxsb2Moc2l6ZSkpKTsKPiArCj4gKwljdHhfZW5naW5l LT5leHRlbnNpb25zID0gMDsKPiArCWZvciAoaSA9IDA7IGkgPCBxdWVyeV9lbmdpbmUtPm51bV9l bmdpbmVzOyBpKyspIHsKPiArCj4gKwkJY3R4X2VuZ2luZS0+Y2xhc3NfaW5zdGFuY2VbaV0uY2xh c3MgPSBxdWVyeV9lbmdpbmUtPmVuZ2luZXNbaV0uY2xhc3M7Cj4gKwkJY3R4X2VuZ2luZS0+Y2xh c3NfaW5zdGFuY2VbaV0uaW5zdGFuY2UgPSBxdWVyeV9lbmdpbmUtPmVuZ2luZXNbaV0uaW5zdGFu Y2U7Cj4gKwo+ICsJCWlmKGVuZ2luZXMpCj4gKwkJCXN0b3JlX2VuZ2luZSgmZW5naW5lc1tpXSwg JnF1ZXJ5X2VuZ2luZS0+ZW5naW5lc1tpXSk7Cj4gKwl9Cj4gKwo+ICsJY3R4X3BhcmFtLmN0eF9p ZCA9IGN0eF9pZDsKPiArCWN0eF9wYXJhbS5zaXplID0gc2l6ZTsKPiArCWN0eF9wYXJhbS5wYXJh bSA9IEk5MTVfQ09OVEVYVF9QQVJBTV9FTkdJTkVTOwo+ICsJY3R4X3BhcmFtLnZhbHVlID0gdG9f dXNlcl9wb2ludGVyKGN0eF9lbmdpbmUpOwo+ICsKPiArCS8qIGNoZWNrIHdoZXRoZXIgd2UgZnJl ZSB0aGUgZW5naW5lcyAqLwo+ICsJaWd0X3JlcXVpcmUoIWlvY3RsKGZkLCBEUk1fSU9DVExfSTkx NV9HRU1fQ09OVEVYVF9TRVRQQVJBTSwgJmN0eF9wYXJhbSkpOwo+ICsKPiArCWZyZWUoY3R4X2Vu Z2luZSk7Cj4gK30KPiArCj4gK2ludCBfX2dlbV9zZXR1cF9jdHhfZW5naW5lcyhpbnQgZmQsIHVp bnQzMl90IGN0eF9pZCwKPiArCQkJICAgIHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAq KmVuZ2luZXMpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbyAqcXVl cnlfZW5naW5lOwo+ICsJaW50IG47Cj4gKwo+ICsJcXVlcnlfZW5naW5lID0gcXVlcnlfZW5naW5l cyhmZCk7Cj4gKwo+ICsJbiA9IHF1ZXJ5X2VuZ2luZS0+bnVtX2VuZ2luZXM7Cj4gKwo+ICsJaWYg KGVuZ2luZXMpCj4gKwkJaWd0X2Fzc2VydCgqZW5naW5lcyA9IG1hbGxvYyhuICogc2l6ZW9mKCoq ZW5naW5lcykpKTsKPiArCj4gKwlzZXRfcGFyYW0oZmQsIGN0eF9pZCwgcXVlcnlfZW5naW5lLCBl bmdpbmVzID8gKmVuZ2luZXMgOiBOVUxMKTsKPiArCj4gKwlmcmVlKHF1ZXJ5X2VuZ2luZSk7Cj4g Kwo+ICsJcmV0dXJuIG47Cj4gK30KPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9ndC5oIGIvbGliL2ln dF9ndC5oCj4gaW5kZXggNTRlOTVkYTk4MDg0Li5jYjUxMDgyYjFiZWQgMTAwNjQ0Cj4gLS0tIGEv bGliL2lndF9ndC5oCj4gKysrIGIvbGliL2lndF9ndC5oCj4gQEAgLTg2LDYgKzg2LDEwIEBAIGV4 dGVybiBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZSB7Cj4gICAJICAgICBlX18r KykgXAo+ICAgCQlmb3JfaWYgKGdlbV9yaW5nX2hhc19waHlzaWNhbF9lbmdpbmUoZmRfXywgZmxh Z3NfXyA9IGVfXy0+ZXhlY19pZCB8IGVfXy0+ZmxhZ3MpKQo+ICAgCj4gKyNkZWZpbmUgZm9yX2Vh Y2hfZW5naW5lX2N0eChmZCwgY3R4LCBlLCBlbmdpbmVzKSBcCj4gKwkJZm9yIChpbnQgX19tID0g X19nZW1fc2V0dXBfY3R4X2VuZ2luZXMoZmQsIGN0eCwgZW5naW5lcyksIF9fZSA9IGUgPSAxOyBc Cj4gKwkJCQlfX2UgPCBfX207IGUgPSArK19fZSkKPiArCj4gICBib29sIGdlbV9yaW5nX2lzX3Bo eXNpY2FsX2VuZ2luZShpbnQgZmQsIHVuc2lnbmVkIGludCByaW5nKTsKPiAgIGJvb2wgZ2VtX3Jp bmdfaGFzX3BoeXNpY2FsX2VuZ2luZShpbnQgZmQsIHVuc2lnbmVkIGludCByaW5nKTsKPiAgIAo+ IEBAIC05Nyw2ICsxMDEsOCBAQCBleHRlcm4gY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9l bmdpbmUyIHsKPiAgIAlpbnQgaW5zdGFuY2U7Cj4gICB9IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVz MltdOwo+ICAgCj4gK2ludCBfX2dlbV9zZXR1cF9jdHhfZW5naW5lcyhpbnQgZmQsIHVpbnQzMl90 IGN0eF9pZCwgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICoqZW5naW5lcyk7Cj4gKwo+ ICAgdW5zaWduZWQgaW50Cj4gICBnZW1fY2xhc3NfaW5zdGFuY2VfdG9fZWJfZmxhZ3MoaW50IGdl bV9mZCwKPiAgIAkJCSAgICAgICBlbnVtIGRybV9pOTE1X2dlbV9lbmdpbmVfY2xhc3MgY2xhc3Ms Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1k ZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=