Re: [PATCH i-g-t 19/19] lib/kms: Nuke for_each_valid_output_on_pipe()

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 25 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> for_each_valid_output_on_pipe() is no unused. Get rid of it.

*now

>
> And with that we also lose the last caller of
> igt_pipe_connector_valid() so nuke that one too.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  lib/igt_kms.h | 27 ---------------------------
>  1 file changed, 27 deletions(-)
>
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 8a3919a55e77..fb2597193467 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -670,19 +670,6 @@ static inline bool igt_output_is_connected(igt_output_t *output)
>  	return false;
>  }
>  
> -/**
> - * igt_pipe_connector_valid:
> - * @pipe: pipe to check.
> - * @output: #igt_output_t to check.
> - *
> - * Checks whether the given pipe and output can be used together.
> - */
> -static inline bool igt_pipe_connector_valid(enum pipe pipe, igt_output_t *output)
> -{
> -	return igt_output_is_connected(output) &&
> -		output->config.valid_crtc_index_mask & (1 << (pipe));
> -}
> -
>  /**
>   * igt_crtc_connector_valid:
>   * @crtc: CRTC to check.
> @@ -801,20 +788,6 @@ igt_output_t **__igt_pipe_populate_outputs(igt_display_t *display,
>  		for_each_if (*__output && \
>  			     ((crtc) = igt_crtc_for_pipe((display), (__output - __outputs)), (output) = *__output, 1))
>  
> -/**
> - * for_each_valid_output_on_pipe:
> - * @display: a pointer to an #igt_display_t structure
> - * @pipe: Pipe to enumerate valid outputs over
> - * @output: The enumerated output.
> - *
> - * This for loop is called over all connected @output that can be used
> - * on this @pipe . If there are no valid outputs for this pipe, nothing
> - * happens.
> - */
> -#define for_each_valid_output_on_pipe(display, pipe, output) \
> -	for_each_connected_output((display), (output)) \
> -		for_each_if (igt_pipe_connector_valid((pipe), (output)))
> -
>  /**
>   * for_each_valid_output_on_crtc:
>   * @display: a pointer to an #igt_display_t structure

-- 
Jani Nikula, Intel