From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAAE36E90D for ; Fri, 15 Nov 2019 16:01:50 +0000 (UTC) References: <20191115121445.11693-1-petri.latvala@intel.com> From: Tvrtko Ursulin Message-ID: Date: Fri, 15 Nov 2019 16:01:45 +0000 MIME-Version: 1.0 In-Reply-To: <20191115121445.11693-1-petri.latvala@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [RFC PATCH i-g-t] lib/i915: Generate engine names at runtime List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Petri Latvala , igt-dev@lists.freedesktop.org Cc: Tvrtko Ursulin List-ID: Ck9uIDE1LzExLzIwMTkgMTI6MTQsIFBldHJpIExhdHZhbGEgd3JvdGU6Cj4gVGhlIGtlcm5lbCBz dXBwbGllcyB1cyBhbiBlbmdpbmUgbGlzdCB3aXRoIGVuZ2luZSBjbGFzcyBhbmQgYW4KPiBpbnN0 YW5jZSBpZC4gSWYgdGhlIGhhcmRjb2RlZCBlbmdpbmUgbGlzdCBkb2Vzbid0IGhhdmUgdGhlCj4g Y2xhc3MraW5zdGFuY2Ugd2UgZ2V0LCBjb25zdHJ1Y3QgdGhlIGVuZ2luZSBuYW1lIHdpdGggcHJp bnRmIGluc3RlYWQKPiBvZiBjYWxsaW5nIGFkZGl0aW9uYWwgZW5naW5lcyAidW5rbm93biIuCj4g Cj4gU2lnbmVkLW9mZi1ieTogUGV0cmkgTGF0dmFsYSA8cGV0cmkubGF0dmFsYUBpbnRlbC5jb20+ Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IENjOiBBbmRpIFNoeXRpIDxh bmRpLnNoeXRpQGludGVsLmNvbT4KPiBDYzogS2F0YXJ6eW5hIERlYyA8a2F0YXJ6eW5hLmRlY0Bp bnRlbC5jb20+Cj4gCj4gLS0tCj4gICBsaWIvaTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmMgfCAy NyArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiAgIGxpYi9pOTE1L2dlbV9lbmdpbmVfdG9w b2xvZ3kuaCB8ICAyICstCj4gICBsaWIvaWd0X2d0LmMgICAgICAgICAgICAgICAgICAgfCAgOCAr KysrKysrKwo+ICAgbGliL2lndF9ndC5oICAgICAgICAgICAgICAgICAgIHwgIDcgKysrKysrLQo+ ICAgNCBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvbGliL2k5MTUvZ2VtX2VuZ2luZV90b3BvbG9neS5jIGIvbGliL2k5MTUv Z2VtX2VuZ2luZV90b3BvbG9neS5jCj4gaW5kZXggNzkwZDQ1NWYuLjA3MDdmMjM3IDEwMDY0NAo+ IC0tLSBhL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuYwo+ICsrKyBiL2xpYi9pOTE1L2dl bV9lbmdpbmVfdG9wb2xvZ3kuYwo+IEBAIC0xMDMsNiArMTAzLDcgQEAgc3RhdGljIHZvaWQgaW5p dF9lbmdpbmUoc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICplMiwKPiAgIAljb25zdCBz dHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKl9fZTI7Cj4gICAJc3RhdGljIGNvbnN0IGNo YXIgKnVua25vd25fbmFtZSA9ICJ1bmtub3duIiwKPiAgIAkJCSAgKnZpcnR1YWxfbmFtZSA9ICJ2 aXJ0dWFsIjsKPiArCWNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lX2NsYXNzICpj bHM7Cj4gICAKPiAgIAllMi0+Y2xhc3MgICAgPSBjbGFzczsKPiAgIAllMi0+aW5zdGFuY2UgPSBp bnN0YW5jZTsKPiBAQCAtMTExLDcgKzExMiw3IEBAIHN0YXRpYyB2b2lkIGluaXRfZW5naW5lKHN0 cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZTIsCj4gICAJLyogZW5naW5lIGlzIGEgdmly dHVhbCBlbmdpbmUgKi8KPiAgIAlpZiAoY2xhc3MgPT0gSTkxNV9FTkdJTkVfQ0xBU1NfSU5WQUxJ RCAmJgo+ICAgCSAgICBpbnN0YW5jZSA9PSBJOTE1X0VOR0lORV9DTEFTU19JTlZBTElEX1ZJUlRV QUwpIHsKPiAtCQllMi0+bmFtZSA9IHZpcnR1YWxfbmFtZTsKPiArCQlzdHJuY3B5KGUyLT5uYW1l LCB2aXJ0dWFsX25hbWUsIHNpemVvZihlMi0+bmFtZSkpOwo+ICAgCQllMi0+aXNfdmlydHVhbCA9 IHRydWU7Cj4gICAJCXJldHVybjsKPiAgIAl9Cj4gQEAgLTEyMCwxMiArMTIxLDIyIEBAIHN0YXRp YyB2b2lkIGluaXRfZW5naW5lKHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZTIsCj4g ICAJCWlmIChfX2UyLT5jbGFzcyA9PSBjbGFzcyAmJiBfX2UyLT5pbnN0YW5jZSA9PSBpbnN0YW5j ZSkKPiAgIAkJCWJyZWFrOwo+ICAgCj4gLQlpZiAoX19lMi0+bmFtZSkgewo+IC0JCWUyLT5uYW1l ID0gX19lMi0+bmFtZTsKPiArCWlmIChfX2UyLT5uYW1lWzBdKSB7Cj4gKwkJc3RybmNweShlMi0+ bmFtZSwgX19lMi0+bmFtZSwgc2l6ZW9mKGUyLT5uYW1lKSk7Cj4gICAJfSBlbHNlIHsKPiAtCQlp Z3Rfd2FybigiZm91bmQgdW5rbm93biBlbmdpbmUgKCVkLCAlZClcbiIsIGNsYXNzLCBpbnN0YW5j ZSk7Cj4gLQkJZTItPm5hbWUgPSB1bmtub3duX25hbWU7Cj4gLQkJZTItPmZsYWdzID0gLTE7Cj4g KwkJZm9yIChjbHMgPSBpbnRlbF9leGVjdXRpb25fZW5naW5lX2NsYXNzX21hcDsgY2xzLT5uYW1l OyBjbHMrKykgewo+ICsJCQlpZiAoY2xzLT5jbGFzcyA9PSBjbGFzcykgewo+ICsJCQkJc25wcmlu dGYoZTItPm5hbWUsIHNpemVvZihlMi0+bmFtZSksICIlcyVkIiwgY2xzLT5uYW1lLCBpbnN0YW5j ZSk7Cj4gKwkJCQlpZ3RfaW5mbygidW5rbm93biBidXQgc3VwcG9ydGVkIGVuZ2luZSAlcyBmb3Vu ZFxuIiwgZTItPm5hbWUpOwoKSG0gbm90IHJlYWxseSB1bmtub3duLCBqdXN0IGEgbmV3IGluc3Rh bmNlIHJlbGF0aXZlIHRvIHRoZSBzdGF0aWMgdGFibGUuIApJJ2QgcHJvYmFibHkgZG93bmdyYWRl IHRoaXMgdG8gZGVidWcgbGV2ZWw/Cgo+ICsJCQkJYnJlYWs7Cj4gKwkJCX0KPiArCQl9Cj4gKwo+ ICsJCWlmICghZTItPm5hbWVbMF0pIHsKPiArCQkJaWd0X2luZm8oImZvdW5kIHVua25vd24gZW5n aW5lICglZCwgJWQpXG4iLCBjbGFzcywgaW5zdGFuY2UpOwo+ICsJCQlzdHJuY3B5KGUyLT5uYW1l LCB1bmtub3duX25hbWUsIHNpemVvZihlMi0+bmFtZSkpOwoKdW5rbm93bjxjbGFzcz46PGluc3Rh bmNlPiA/CgpBbmQgc2F5IHVua25vd24gX2NsYXNzXyBpbiB0aGUgbG9nIG1lc3NhZ2U/CgoKPiAr CQkJZTItPmZsYWdzID0gLTE7Cj4gKwkJfQo+ICAgCX0KPiAgIAo+ICAgCS8qIGp1c3QgdG8gcmVt YXJrIGl0ICovCj4gQEAgLTIyMyw3ICsyMzQsNyBAQCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEg aW50ZWxfaW5pdF9lbmdpbmVfbGlzdChpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCkKPiAgIAkJCXN0 cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqX19lMiA9Cj4gICAJCQkJJmVuZ2luZV9kYXRh LmVuZ2luZXNbZW5naW5lX2RhdGEubmVuZ2luZXNdOwo+ICAgCj4gLQkJCV9fZTItPm5hbWUgICAg ICAgPSBlMi0+bmFtZTsKPiArCQkJc3RybmNweShfX2UyLT5uYW1lLCBlMi0+bmFtZSwgc2l6ZW9m KF9fZTItPm5hbWUpKTsKPiAgIAkJCV9fZTItPmluc3RhbmNlICAgPSBlMi0+aW5zdGFuY2U7Cj4g ICAJCQlfX2UyLT5jbGFzcyAgICAgID0gZTItPmNsYXNzOwo+ICAgCQkJX19lMi0+ZmxhZ3MgICAg ICA9IGUyLT5mbGFnczsKPiBAQCAtMzAyLDcgKzMxMyw3IEBAIHN0cnVjdCBpbnRlbF9leGVjdXRp b25fZW5naW5lMiBnZW1fZWJfZmxhZ3NfdG9fZW5naW5lKHVuc2lnbmVkIGludCBmbGFncykKPiAg IAo+ICAgCWlmIChyaW5nID09IEk5MTVfRVhFQ19ERUZBVUxUKSB7Cj4gICAJCWUyX18uZmxhZ3Mg PSBJOTE1X0VYRUNfREVGQVVMVDsKPiAtCQllMl9fLm5hbWUgPSAiZGVmYXVsdCI7Cj4gKwkJc3Ry bmNweShlMl9fLm5hbWUsICJkZWZhdWx0Iiwgc2l6ZW9mKGUyX18ubmFtZSkpOwo+ICAgCX0gZWxz ZSB7Cj4gICAJCWNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZTI7Cj4gICAK PiBkaWZmIC0tZ2l0IGEvbGliL2k5MTUvZ2VtX2VuZ2luZV90b3BvbG9neS5oIGIvbGliL2k5MTUv Z2VtX2VuZ2luZV90b3BvbG9neS5oCj4gaW5kZXggZDk4NzczZTAuLjUyNTc0MWNjIDEwMDY0NAo+ IC0tLSBhL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuaAo+ICsrKyBiL2xpYi9pOTE1L2dl bV9lbmdpbmVfdG9wb2xvZ3kuaAo+IEBAIC02MSw3ICs2MSw3IEBAIGJvb2wgZ2VtX2VuZ2luZV9p c19lcXVhbChjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUxLAo+ICAgc3Ry dWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyIGdlbV9lYl9mbGFnc190b19lbmdpbmUodW5zaWdu ZWQgaW50IGZsYWdzKTsKPiAgIAo+ICAgI2RlZmluZSBfX2Zvcl9lYWNoX3N0YXRpY19lbmdpbmUo ZV9fKSBcCj4gLQlmb3IgKChlX18pID0gaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyOyAoZV9fKS0+ bmFtZTsgKGVfXykrKykKPiArCWZvciAoKGVfXykgPSBpbnRlbF9leGVjdXRpb25fZW5naW5lczI7 IChlX18pLT5uYW1lWzBdOyAoZV9fKSsrKQo+ICAgCj4gICAjZGVmaW5lIGZvcl9lYWNoX2NvbnRl eHRfZW5naW5lKGZkX18sIGN0eF9fLCBlX18pIFwKPiAgIAlmb3IgKHN0cnVjdCBpbnRlbF9lbmdp bmVfZGF0YSBpX18gPSBpbnRlbF9pbml0X2VuZ2luZV9saXN0KGZkX18sIGN0eF9fKTsgXAo+IGRp ZmYgLS1naXQgYS9saWIvaWd0X2d0LmMgYi9saWIvaWd0X2d0LmMKPiBpbmRleCAyNTZjN2NiYy4u MjVlNmM0NTUgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9ndC5jCj4gKysrIGIvbGliL2lndF9ndC5j Cj4gQEAgLTU5Niw2ICs1OTYsMTQgQEAgY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdp bmUyIGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMltdID0gewo+ICAgCXsgfQo+ICAgfTsKPiAgIAo+ ICtjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZV9jbGFzcyBpbnRlbF9leGVjdXRp b25fZW5naW5lX2NsYXNzX21hcFtdID0gewo+ICsJeyAicmNzIiwgSTkxNV9FTkdJTkVfQ0xBU1Nf UkVOREVSIH0sCj4gKwl7ICJiY3MiLCBJOTE1X0VOR0lORV9DTEFTU19DT1BZIH0sCj4gKwl7ICJ2 Y3MiLCBJOTE1X0VOR0lORV9DTEFTU19WSURFTyB9LAo+ICsJeyAidmVjcyIsIEk5MTVfRU5HSU5F X0NMQVNTX1ZJREVPX0VOSEFOQ0UgfSwKPiArCXsgfQo+ICt9Owo+ICsKPiAgIGludCBnZW1fZXhl Y2J1Zl9mbGFnc190b19lbmdpbmVfY2xhc3ModW5zaWduZWQgaW50IGZsYWdzKQo+ICAgewo+ICAg CXN3aXRjaCAoZmxhZ3MgJiAweDNmKSB7Cj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZ3QuaCBiL2xp Yi9pZ3RfZ3QuaAo+IGluZGV4IDY2MDg4ZDM5Li4wMjY4MDMxZiAxMDA2NDQKPiAtLS0gYS9saWIv aWd0X2d0LmgKPiArKysgYi9saWIvaWd0X2d0LmgKPiBAQCAtOTUsMTMgKzk1LDE4IEBAIGJvb2wg Z2VtX2Nhbl9zdG9yZV9kd29yZChpbnQgZmQsIHVuc2lnbmVkIGludCBlbmdpbmUpOwo+ICAgYm9v bCBnZW1fY2xhc3NfY2FuX3N0b3JlX2R3b3JkKGludCBmZCwgaW50IGNsYXNzKTsKPiAgIAo+ICAg ZXh0ZXJuIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiB7Cj4gLQljb25zdCBj aGFyICpuYW1lOwo+ICsJY2hhciBuYW1lWzEwXTsKPiAgIAlpbnQgY2xhc3M7Cj4gICAJaW50IGlu c3RhbmNlOwo+ICAgCXVpbnQ2NF90IGZsYWdzOwo+ICAgCWJvb2wgaXNfdmlydHVhbDsKPiAgIH0g aW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyW107Cj4gICAKPiArZXh0ZXJuIGNvbnN0IHN0cnVjdCBp bnRlbF9leGVjdXRpb25fZW5naW5lX2NsYXNzIHsKPiArCWNvbnN0IGNoYXIgKm5hbWU7Cj4gKwlp bnQgY2xhc3M7Cj4gK30gaW50ZWxfZXhlY3V0aW9uX2VuZ2luZV9jbGFzc19tYXBbXTsKPiArCj4g ICBpbnQgZ2VtX2V4ZWNidWZfZmxhZ3NfdG9fZW5naW5lX2NsYXNzKHVuc2lnbmVkIGludCBmbGFn cyk7Cj4gICAKPiAgICNlbmRpZiAvKiBJR1RfR1RfSCAqLwo+IAoKSW1wbGVtZW50YXRpb24gbG9v a3Mgb2theSB0byBtZSwgYnV0IHdoYXQgZG9lcyBpdCBnYWlucyB1cz8gUG90ZW50aWFsbHkgCmlu dHJvZHVjZXMgYSBzbGlnaHQgY29uZnVzaW9uIGJldHdlZW4gc3VidGVzdHMgYXMgZW51bWVyYXRl ZCBieSBlbmdpbmUgCmFuZCBlbmdpbmVzIGl0ZXJhdGVkIGluc2lkZSBzb21lIHRlc3RzLgoKT25s eSBhbiBpbnRlcmltIHN0ZXAgYmVmb3JlIGVsaW1pbmF0aW9uIG9mIHRoZSBzdGF0aWMgYXJyYXk/ IEJ1dCBkYW5nZXIgCmlzIGluIHRoZSBhYm92ZSBtaXNtYXRjaC4KClJlZ2FyZHMsCgpUdnJ0a28K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2