Re: [PATCH i-g-t] tests/kms_atomic: Read the error msg on atomic_ioctl failure

["Murthy, Arun R" <arun.r.murthy@intel.com>]

Hi Kamil,

     Thanks for the review.
Sorry I forgot to add [DO_NOT_REVIEW] tag for this patch.
This patch was pushed just to get to know the usage from user for 
reviewing the KMD patch.
I will be enhance the test and will push the patch for review.

Thanks and Regards,
Arun R Murthy
--------------------

On 18-02-2026 18:48, Kamil Konieczny wrote:
> Hi Arun,
> On 2026-02-10 at 14:23:33 +0530, Arun R Murthy wrote:
>> On atomic_ioctl failure compare the failure flag with the expected
>> invalid reason and pass if same else fail the test.
>>
>> The corresponding KMD changes are pushed for review @
>> https://patchwork.freedesktop.org/series/152276/
>>
>> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
>> ---
>>   tests/kms_atomic.c | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
>> index fa321cc3c..a609a9f14 100644
>> --- a/tests/kms_atomic.c
>> +++ b/tests/kms_atomic.c
>> @@ -1041,13 +1041,17 @@ static void crtc_invalid_params_fence(data_t *data, igt_output_t *output)
>>   static void atomic_invalid_params(data_t *data, igt_output_t *output)
>>   {
>>   	struct drm_mode_atomic ioc;
>> +	struct drm_mode_atomic_err_code *err_code;
>>   	uint32_t obj_raw[16]; /* array of objects (sized by count_objs) */
>>   	uint32_t num_props_raw[16]; /* array of num props per obj (ditto) */
>>   	uint32_t props_raw[256]; /* array of props (sum of count_props) */
>>   	uint64_t values_raw[256]; /* array of values for properties (ditto) */
>>   	int i;
>>   
>> +	err_code = malloc(sizeof(struct drm_mode_atomic_err_code));
>> +	memset(err_code, 0, sizeof(struct drm_mode_atomic_err_code));
> Use calloc.
>
>>   	memset(&ioc, 0, sizeof(ioc));
>> +	ioc.reserved = (uintptr_t)err_code;
> It is better using function to_user_pointer()
>
>>   
>>   	/* An empty request should do nothing. */
>>   	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);
>> @@ -1076,14 +1080,18 @@ static void atomic_invalid_params(data_t *data, igt_output_t *output)
>>   	/* Nonsense flags. */
>>   	ioc.flags = 0xdeadbeef;
>>   	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EINVAL);
>> +	if (igt_has_drm_cap(data->drm_fd, DRM_CAP_ATOMIC_ERROR_REPORTING))
>> +		igt_assert_eq(err_code->failure_code, DRM_MODE_ATOMIC_INVALID_API_USAGE);
>>   
>>   	ioc.flags = 0;
>>   	/* Safety check that flags is reset properly. */
>>   	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);
>>   
>>   	/* Reserved/MBZ. */
>> -	ioc.reserved = 1;
>> -	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EINVAL);
>> +	if (!igt_has_drm_cap(data->drm_fd, DRM_CAP_ATOMIC_ERROR_REPORTING)) {
>> +		ioc.reserved = 1;
>> +		do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EINVAL);
>> +	}
>>   	ioc.reserved = 0;
>>   	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);
> Where is free(err_code)?
>
> Regards,
> Kamil
>>   
>> -- 
>> 2.25.1
>>