From: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
To: "Wang, Chao-kai (Stylon)" <Stylon.Wang@amd.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding
Date: Mon, 16 Sep 2019 12:35:50 +0000 [thread overview]
Message-ID: <c02fe6c8-a13f-cfc6-e1cd-5ccd0d632783@amd.com> (raw)
In-Reply-To: <20190913095745.GQ4019@platvala-desk.ger.corp.intel.com>
On 2019-09-13 5:57 a.m., Petri Latvala wrote:
> On Wed, Sep 11, 2019 at 02:29:51PM +0000, Kazlauskas, Nicholas wrote:
>> On 2019-09-11 10:11 a.m., Wang, Chao-kai (Stylon) wrote:
>>> From: Stylon Wang <stylon.wang@amd.com>
>>>
>>> HDMI 2.0 compliance tests needs 4K modes with YUV encoding.
>>> This test selects 4K modes based on specified VIC.
>>
>> It helps to note what changed in a patch series in both the patch title
>> and in the commit message here.
>>
>> You can add a v2 to the patch header by appending a -v2 to your command, eg:
>>
>> "git send-email -v2 ..."
>>
>> And in the commit description you should do something like:
>>
>> v2:
>> - example change 1
>> - example change 2
>>
>> Other than that, I do have some general comments and nitpicks:
>>
>> I think this tool might be better off named as just amd_hdmi_compliance
>> so we can expand on this later.
>
> Is there anything specific that makes this tool AMD-specific? It even
> uses DRIVER_ANY.
>
> I guess the same question can be asked about intel_dp_compliance.c...
>
>
>
Nothing yet that I can see in the patch itself.
I know that debugfs entries to help with automating this compliance were
added to amdgpu (like the one that controls 420 vs 444 output), so I
would imagine that they would be added after though.
Nicholas Kazlauskas
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-09-16 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 14:11 [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding Wang, Chao-kai (Stylon)
2019-09-11 14:29 ` Kazlauskas, Nicholas
2019-09-13 9:57 ` Petri Latvala
2019-09-16 12:35 ` Kazlauskas, Nicholas [this message]
2019-09-11 15:07 ` [igt-dev] ✓ Fi.CI.BAT: success for tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) Patchwork
2019-09-12 1:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-09-09 18:29 [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding Wang, Chao-kai (Stylon)
2019-09-09 20:40 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c02fe6c8-a13f-cfc6-e1cd-5ccd0d632783@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=Stylon.Wang@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox