Re: [PATCH i-g-t] tests/kms_plane: Add vblank waits for MediaTek CRC timing

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

> 
[snip]

> > diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> > index 8cef94a1f37e..e4539078c98e 100644
> > --- a/tests/kms_plane.c
> > +++ b/tests/kms_plane.c
> > @@ -351,6 +351,15 @@ test_plane_position_with_output(data_t *data,
> > igt_crtc_t *crtc,
> > 
> >         igt_display_commit(&data->display);
> > 
> > +       /*
> > +        * On MediaTek hardware, cursor plane updates are non-
> > blocking and
> > +        * CRC needs time to reflect the new plane configuration.
> > Wait for
> > +        * a vblank to ensure the update has taken effect.
> > +        */
> > +       if (is_mtk_device(data->drm_fd) && sprite->type ==
> > DRM_PLANE_TYPE_CURSOR)
> > +               igt_wait_for_vblank(data->drm_fd,
> > +                                   data-
> > >display.pipes[pipe].crtc_offset);
> 
> Hmm, I suppose your codebase is a bit outdated?
> Commit 18349d8bc1b2 ("lib/kms: Pass the entire igt_pipe_t to
> igt_wait_for_vblank*()") [1] changed the function signature, so this
> patch doesn't apply to the latest tree.
> 
> [1]:
> https://urldefense.com/v3/__https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/18349d8bc1b25bcf953e1868666214829f75c442
>  
> 
> But I get the concept, and I think that looks okay.
> 

Hi Fei,

Thanks! I'll check why I don't get a build error in my codebase and
send the correct one.

Regards,
Jason-JH Lin

> Regards,
> Fei