From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2800A6E672 for ; Thu, 6 Dec 2018 21:51:52 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id i7so2303952qtj.10 for ; Thu, 06 Dec 2018 13:51:52 -0800 (PST) Message-ID: From: Lyude Paul Date: Thu, 06 Dec 2018 16:51:49 -0500 In-Reply-To: <20181206141132.23349-7-paul.kocialkowski@bootlin.com> References: <20181206141132.23349-1-paul.kocialkowski@bootlin.com> <20181206141132.23349-7-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 6/9] lib/igt_vc4: Add helpers for converting linear to T-tiled XRGB buffers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: T25lIHNtYWxsIG5pdHBpY2sKCk9uIFRodSwgMjAxOC0xMi0wNiBhdCAxNToxMSArMDEwMCwgUGF1 bCBLb2NpYWxrb3dza2kgd3JvdGU6Cj4gSW4gb3JkZXIgdG8gaW50ZWdyYXRlIHRlc3Rpbmcgb2Yg VC10aWxlZCBidWZmZXJzLCB0aGUgZWFzaWVzdCBwYXRoIGlzIHRvCj4gZ2VuZXJhdGUgcGF0dGVy bnMgKHdpdGggdGhlIGFscmVhZHktZXhpc3RpbmcgZnVuY3Rpb25zKSBpbiBsaW5lYXIKPiBidWZm ZXJzIGFuZCBjb252ZXJ0IHRoZW0gdG8gVC10aWxlZCBzdWJzZXF1ZW50bHkuCj4gCj4gQWRkIGhl bHBlcnMgdG8gZG8gdGhhdCBjb252ZXJzaW9uLCB3aXRoIGEgZmlyc3QgaGVscGVyIHRoYXQgcmV0 dXJucyB0aGUKPiBtZW1vcnkgb2Zmc2V0IGZvciBhIGdpdmVuIHBvc2l0aW9uIGluIGEgVC10aWxl ZCBidWZmZXIgYW5kIGEgc2Vjb25kCj4gaGVscGVyIHRoYXQgdXNlcyBpdCBmb3IgY29udmVydGlu ZyBiZXR3ZWVuIGZyYW1lYnVmZmVycy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtv d3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfdmM0 LmMgfCA5NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPiAgbGliL2lndF92YzQuaCB8ICA0ICsrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDEwMCBpbnNl cnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfdmM0LmMgYi9saWIvaWd0X3ZjNC5j Cj4gaW5kZXggMTZkZmU2N2EuLjBiNTEyNGYzIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfdmM0LmMK PiArKysgYi9saWIvaWd0X3ZjNC5jCj4gQEAgLTM0LDYgKzM0LDcgQEAKPiAgI2luY2x1ZGUgImRy bXRlc3QuaCIKPiAgI2luY2x1ZGUgImlndF9hdXguaCIKPiAgI2luY2x1ZGUgImlndF9jb3JlLmgi Cj4gKyNpbmNsdWRlICJpZ3RfZmIuaCIKPiAgI2luY2x1ZGUgImlndF92YzQuaCIKPiAgI2luY2x1 ZGUgImlvY3RsX3dyYXBwZXJzLmgiCj4gICNpbmNsdWRlICJpbnRlbF9yZWcuaCIKPiBAQCAtMTc2 LDMgKzE3Nyw5OCBAQCBib29sIGlndF92YzRfcHVyZ2VhYmxlX2JvKGludCBmZCwgaW50IGhhbmRs ZSwgYm9vbAo+IHB1cmdlYWJsZSkKPiAgCj4gIAlyZXR1cm4gYXJnLnJldGFpbmVkOwo+ICB9Cj4g Kwo+ICt1bnNpZ25lZCBpbnQgaWd0X3ZjNF9mYl90X3RpbGVkX2NvbnZlcnQoc3RydWN0IGlndF9m YiAqZHN0LCBzdHJ1Y3QgaWd0X2ZiCj4gKnNyYykKPiArewo+ICsJdW5zaWduZWQgaW50IGZiX2lk Owo+ICsJdW5zaWduZWQgaW50IGksIGo7Cj4gKwl1aW50MzJfdCAqc3JjX2J1ZjsKPiArCXVpbnQz Ml90ICpkc3RfYnVmOwo+ICsJc2l6ZV90IG9mZnNldDsKPiArCj4gKwlpZ3RfYXNzZXJ0KHNyYy0+ ZHJtX2Zvcm1hdCA9PSBEUk1fRk9STUFUX1hSR0I4ODg4KTsKPiArCj4gKwlmYl9pZCA9IGlndF9j cmVhdGVfZmIoc3JjLT5mZCwgc3JjLT53aWR0aCwgc3JjLT5oZWlnaHQsIHNyYy0KPiA+ZHJtX2Zv cm1hdCwKPiArCQkJICAgICAgRFJNX0ZPUk1BVF9NT0RfQlJPQURDT01fVkM0X1RfVElMRUQsIGRz dCk7Cj4gKwlpZ3RfYXNzZXJ0KGZiX2lkID4gMCk7Cj4gKwo+ICsJc3JjX2J1ZiA9IGlndF9mYl9t YXBfYnVmZmVyKHNyYy0+ZmQsIHNyYyk7Cj4gKwlpZ3RfYXNzZXJ0KHNyY19idWYpOwo+ICsKPiAr CWRzdF9idWYgPSBpZ3RfZmJfbWFwX2J1ZmZlcihkc3QtPmZkLCBkc3QpOwo+ICsJaWd0X2Fzc2Vy dChkc3RfYnVmKTsKPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgc3JjLT5oZWlnaHQ7IGkrKykgewo+ ICsJCWZvciAoaiA9IDA7IGogPCBzcmMtPndpZHRoOyBqKyspIHsKPiArCQkJb2Zmc2V0ID0gaWd0 X3ZjNF90X3RpbGVkX29mZnNldChzcmMtPndpZHRoLCBzcmMtCj4gPmhlaWdodCwKPiArCQkJCQkJ CXNyYy0+ZHJtX2Zvcm1hdCwgaiwgaSkKPiAvIDQ7Cj4gKwkJCSooZHN0X2J1ZiArIG9mZnNldCkg PSAqKHNyY19idWYgKwo+ICsJCQkJCQlzcmMtPnN0cmlkZXNbMF0gLyA0ICogaSArIGopOwo+ICsJ CX0KPiArCX0KPiArCj4gKwlpZ3RfZmJfdW5tYXBfYnVmZmVyKHNyYywgc3JjX2J1Zik7Cj4gKwlp Z3RfZmJfdW5tYXBfYnVmZmVyKGRzdCwgZHN0X2J1Zik7Cj4gKwo+ICsJcmV0dXJuIGZiX2lkOwo+ ICt9Cj4gKwo+ICtzaXplX3QgaWd0X3ZjNF90X3RpbGVkX29mZnNldChzaXplX3Qgd2lkdGgsIHNp emVfdCBoZWlnaHQsIHNpemVfdCBmb3JtYXQsCj4gKwkJCSAgICAgIHNpemVfdCB4LCBzaXplX3Qg eSkKPiArewo+ICsJc2l6ZV90IHQxa19tYXBfZXZlbls0XSA9IHsgMCwgMywgMSwgMiB9Owo+ICsJ c2l6ZV90IHQxa19tYXBfb2RkWzRdID0geyAyLCAxLCAzLCAwIH07Ck5vIG5lZWQgdG8gc3BlY2lm eSB0aGUgYXJyYXkgc2l6ZSBoZXJlLCB0MWtfbWFwX2V2ZW5bXSBhbmQgdDFrX21hcF9vZGRbXQpz aG91bGQgYmUgZmluZS4gQWxzbywgdGhlc2UgbG9vayBsaWtlIHRoZXkgcHJvYmFibHkgc2hvdWxk IGJlIGNvbnN0LgoKPiArCXNpemVfdCBvZmZzZXQgPSAwOwo+ICsJc2l6ZV90IHQ0a193LCB0NGtf eCwgdDRrX3k7Cj4gKwlzaXplX3QgdDFrX3gsIHQxa195Owo+ICsJc2l6ZV90IHQ2NGJfeCwgdDY0 Yl95Owo+ICsJc2l6ZV90IHBpeF94LCBwaXhfeTsKPiArCXVuc2lnbmVkIGludCBpbmRleDsKPiAr Cj4gKwlpZ3RfYXNzZXJ0KGZvcm1hdCA9PSBEUk1fRk9STUFUX1hSR0I4ODg4KTsKPiArCj4gKwkv KiBXaWR0aCBpbiBudW1iZXIgb2YgNEsgdGlsZXMuICovCj4gKwl0NGtfdyA9IEFMSUdOKHdpZHRo LCAzMikgLyAzMjsKPiArCj4gKwkvKiBYIGFuZCB5IGNvb3JkaW5hdGVzIGluIG51bWJlciBvZiA0 SyB0aWxlcyAoMzJ4MzIpLiAqLwo+ICsJdDRrX3ggPSB4IC8gMzI7Cj4gKwl0NGtfeSA9IHkgLyAz MjsKPiArCj4gKwkvKiBJbmNyZWFzZSBvZmZzZXQgdG8gdGhlIGJlZ2lubmluZyBvZiB0aGUgY29y cmVzcG9uZGluZyA0SyB0aWxlLiAqLwo+ICsJb2Zmc2V0ICs9IHQ0a195ICogdDRrX3cgKiAzMiAq IDMyOwo+ICsKPiArCS8qIFggYW5kIFkgY29vcmRpbmF0ZXMgaW4gbnVtYmVyIG9mIDFLIHRpbGVz ICgxNngxNikgd2l0aGluIHRoZSA0Swo+IHRpbGUuICovCj4gKwl0MWtfeCA9ICh4ICUgMzIpIC8g MTY7Cj4gKwl0MWtfeSA9ICh5ICUgMzIpIC8gMTY7Cj4gKwo+ICsJaW5kZXggPSAyICogdDFrX3kg KyB0MWtfeDsKPiArCj4gKwlpZiAodDRrX3kgJSAyKSB7Cj4gKwkJLyogT2RkIHJvd3Mgc3RhcnQg ZnJvbSB0aGUgcmlnaHQuICovCj4gKwkJb2Zmc2V0ICs9ICh0NGtfdyAtIHQ0a194IC0gMSkgKiAz MiAqIDMyOwo+ICsJCW9mZnNldCArPSB0MWtfbWFwX29kZFtpbmRleF0gKiAxNiAqIDE2Owo+ICsJ fSBlbHNlIHsKPiArCQkvKiBFdmVuIHJvd3Mgc3RhcnQgZnJvbSB0aGUgbGVmdC4gKi8KPiArCQlv ZmZzZXQgKz0gdDRrX3ggKiAzMiAqIDMyOwo+ICsJCW9mZnNldCArPSB0MWtfbWFwX2V2ZW5baW5k ZXhdICogMTYgKiAxNjsKPiArCX0KPiArCj4gKwkvKiBYIGFuZCBZIGNvb3JkaW5hdGVzIGluIG51 bWJlciBvZiA2NCBieXRlIHRpbGVzICg0eDQpIHdpdGhpbiB0aGUgMUsKPiB0aWxlLiAqLwo+ICsJ dDY0Yl94ID0gKHggJSAxNikgLyA0Owo+ICsJdDY0Yl95ID0gKHkgJSAxNikgLyA0Owo+ICsKPiAr CS8qIEluY3JlYXNlIG9mZnNldCB0byB0aGUgYmVnaW5uaW5nIG9mIHRoZSBjb3JyZXNwb25kaW5n IDY0IGJ5dGUgdGlsZS4KPiAqLwo+ICsJb2Zmc2V0ICs9IHQ2NGJfeSAqIDQgKiA0ICogNCArIHQ2 NGJfeCAqIDQgKiA0Owo+ICsKPiArCS8qIFggYW5kIFkgY29vcmRpbmF0ZXMgaW4gbnVtYmVyIG9m IHBpeGVscyB3aXRoaW4gdGhlIDY0IGJ5dGUgdGlsZS4gKi8KPiArCXBpeF94ID0geCAlIDQ7Cj4g KwlwaXhfeSA9IHkgJSA0Owo+ICsKPiArCS8qIEluY3JlYXNlIG9mZnNldCB0byB0aGUgY29ycmVj dCBwaXhlbC4gKi8KPiArCW9mZnNldCArPSBwaXhfeSAqIDQgKyBwaXhfeDsKPiArCj4gKwkvKiBN dWx0aXBseSBieSB0aGUgbnVtYmVyIG9mIGJ5dGVzIHBlciBwaXhlbCBmb3IgdGhlIGZvcm1hdC4g Ki8KPiArCW9mZnNldCAqPSA0Owo+ICsKPiArCXJldHVybiBvZmZzZXQ7Cj4gK30KPiBkaWZmIC0t Z2l0IGEvbGliL2lndF92YzQuaCBiL2xpYi9pZ3RfdmM0LmgKPiBpbmRleCBlYmM4YTM4OC4uYWI0 NGY3NzEgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF92YzQuaAo+ICsrKyBiL2xpYi9pZ3RfdmM0LmgK PiBAQCAtMzMsNCArMzMsOCBAQCBib29sIGlndF92YzRfcHVyZ2VhYmxlX2JvKGludCBmZCwgaW50 IGhhbmRsZSwgYm9vbAo+IHB1cmdlYWJsZSk7Cj4gIHZvaWQgaWd0X3ZjNF9zZXRfdGlsaW5nKGlu dCBmZCwgdWludDMyX3QgaGFuZGxlLCB1aW50NjRfdCBtb2RpZmllcik7Cj4gIHVpbnQ2NF90IGln dF92YzRfZ2V0X3RpbGluZyhpbnQgZmQsIHVpbnQzMl90IGhhbmRsZSk7Cj4gIAo+ICt1bnNpZ25l ZCBpbnQgaWd0X3ZjNF9mYl90X3RpbGVkX2NvbnZlcnQoc3RydWN0IGlndF9mYiAqZHN0LCBzdHJ1 Y3QgaWd0X2ZiCj4gKnNyYyk7Cj4gK3NpemVfdCBpZ3RfdmM0X3RfdGlsZWRfb2Zmc2V0KHNpemVf dCB3aWR0aCwgc2l6ZV90IGhlaWdodCwgc2l6ZV90IGZvcm1hdCwKPiArCQkJICAgICAgc2l6ZV90 IHgsIHNpemVfdCB5KTsKPiArCj4gICNlbmRpZiAvKiBJR1RfVkM0X0ggKi8KLS0gCkNoZWVycywK CUx5dWRlIFBhdWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=