From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDBE96ECAA for ; Thu, 31 Jan 2019 12:05:58 +0000 (UTC) References: <20190131085802.9703-1-maarten.lankhorst@linux.intel.com> <20190131102628.GJ4038@platvala-desk.ger.corp.intel.com> From: Maarten Lankhorst Message-ID: Date: Thu, 31 Jan 2019 13:05:56 +0100 MIME-Version: 1.0 In-Reply-To: <20190131102628.GJ4038@platvala-desk.ger.corp.intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org, Petri Latvala Cc: Nicholas Kazlauskas List-ID: T3AgMzEtMDEtMjAxOSBvbSAxMToyNiBzY2hyZWVmIFBldHJpIExhdHZhbGE6Cj4gT24gVGh1LCBK YW4gMzEsIDIwMTkgYXQgMDk6NTg6MDJBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFdlIHVzZWQgdG8gYWRkIHRoZW0gYWxsIDEgYnkgMSwgYnV0IHdlIHJlYWxseSBvbmx5IGNh cmUgYWJvdXQgbm90Cj4+IGhhbmRsaW5nIGEgZmV3Lgo+Pgo+PiBPbmx5IHNraXAgdW5zZXR0aW5n IGFsbCBhdG9taWMgcHJvcGVydGllcywgaW5zdGVhZCBvZiBoYW5kbGluZyBpdAo+PiB0aHJvdWdo IGEgd2hpdGVsaXN0Lgo+Pgo+PiBUaGlzIGZpeGVzIGttc19idXN5LCB3aGljaCB3YXMgdXBkYXRp bmcgdGhlIFZSUiBoaW50LCBldmVuIHRob3VnaAo+PiB3ZSBhbHJlYWR5IHVuc2V0IGl0IGluIHRo ZSBsZWdhY3kgcGF0aC4KPj4KPj4gQ2M6IE5pY2hvbGFzIEthemxhdXNrYXMgPG5rYXpsYXVzQGFt ZC5jb20+Cj4+IENjOiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4KPj4g Q2M6IExlbyBMaSA8c3VucGVuZy5saUBhbWQuY29tPgo+PiBCdWd6aWxsYTogaHR0cHM6Ly9idWdz LmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NDkwCj4+IFNpZ25lZC1vZmYtYnk6 IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+ IC0tLQo+PiAgbGliL2lndF9rbXMuYyB8IDcgKysrLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDMg aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3Rf a21zLmMgYi9saWIvaWd0X2ttcy5jCj4+IGluZGV4IDU4ZjMyOTExZDk5OS4uMWY5OGIyNmZjZDc5 IDEwMDY0NAo+PiAtLS0gYS9saWIvaWd0X2ttcy5jCj4+ICsrKyBiL2xpYi9pZ3Rfa21zLmMKPj4g QEAgLTMyOTgsMTAgKzMyOTgsOSBAQCBkaXNwbGF5X2NvbW1pdF9jaGFuZ2VkKGlndF9kaXNwbGF5 X3QgKmRpc3BsYXksIGVudW0gaWd0X2NvbW1pdF9zdHlsZSBzKQo+PiAgCQkJcGlwZV9vYmotPnZh bHVlc1tJR1RfQ1JUQ19PVVRfRkVOQ0VfUFRSXSA9IDA7Cj4+ICAJCQlwaXBlX29iai0+Y2hhbmdl ZCA9IDA7Cj4+ICAJCX0gZWxzZSB7Cj4+IC0JCQlpZ3RfcGlwZV9vYmpfY2xlYXJfcHJvcF9jaGFu Z2VkKHBpcGVfb2JqLCBJR1RfQ1JUQ19CQUNLR1JPVU5EKTsKPj4gLQkJCWlndF9waXBlX29ial9j bGVhcl9wcm9wX2NoYW5nZWQocGlwZV9vYmosIElHVF9DUlRDX0NUTSk7Cj4+IC0JCQlpZ3RfcGlw ZV9vYmpfY2xlYXJfcHJvcF9jaGFuZ2VkKHBpcGVfb2JqLCBJR1RfQ1JUQ19ERUdBTU1BX0xVVCk7 Cj4+IC0JCQlpZ3RfcGlwZV9vYmpfY2xlYXJfcHJvcF9jaGFuZ2VkKHBpcGVfb2JqLCBJR1RfQ1JU Q19HQU1NQV9MVVQpOwo+PiArCQkJZm9yIChpID0gMDsgaSA8IElHVF9OVU1fQ1JUQ19QUk9QUzsg aSsrKQo+PiArCQkJCWlmICghaXNfYXRvbWljX3Byb3AoaSkpCj4+ICsJCQkJCWlndF9waXBlX29i al9jbGVhcl9wcm9wX2NoYW5nZWQocGlwZV9vYmosIGkpOwo+Cj4gRG9lcyBJR1RfQ1JUQ19WUlJf RU5BQkxFRCBuZWVkIHRvIGJlIGFkZGVkIHRvIGlzX2F0b21pY19wcm9wPwoKVGhlIGxlZ2FjeSBw YXRoOgotIFBlcmZvcm1zIGRybU1vZGVTZXRDcnRjIG9uIHRoZSBwcmltYXJ5IHBsYW5lIHRvIHRy aWdnZXIgYSBtb2Rlc2V0IGFuZCBjb25uZWN0b3IgYXNzaWdubWVudHMKLSBVc2VzIGRybU1vZGVT ZXRDdXJzb3IvZHJtTW9kZU1vdmVDdXJzb3IgdG8gbW92ZSB0aGUgY3Vyc29yIHBsYW5lCi0gVXNl cyBkcm1Nb2RlU2V0UGxhbmUgb24gb3RoZXIgcGxhbmVzLgotIFVzZXMgZHJtTW9kZUNvbm5lY3Rv clNldFByb3BlcnR5IHRvIHNldCBjb25uZWN0b3IgcHJvcGVydGllcy4KLSBDYWxscyBkcm1Nb2Rl T2JqZWN0U2V0UHJvcGVydHkgdG8gdXBkYXRlIGFueSBub24tYXRvbWljIGNydGMgcHJvcGVydGll cy4gUHJvYmFibHkgZ2FtbWEvZXRjIGFzIHdlbGwuClByaW1hcnkgYW5kIGN1cnNvciBwcm9wZXJ0 aWVzIGFyZSBtb3N0bHkgaWdub3JlZCwgZXhjZXB0IHdpdGggd2hhdCBjYW4gYmUgc2V0IHRocm91 Z2ggc2V0Y3Vyc29yL3NldGNydGMuCgpUaGUgdW5pdmVyc2FsIHBhdGg6Ci0gVXNlcyBTZXRQbGFu ZSBvbiBhbGwgcGxhbmVzLgotIENhbGxzIGRybU1vZGVPYmplY3RTZXRQcm9wZXJ0eSBmb3IgYWxs IG5vdCBpZ25vcmVkIHByb3BlcnRpZXMgb24gZWFjaCBwbGFuZS9jb25uZWN0b3IvY3J0Yy4KLSBD YW4ndCBkbyBtb2Rlc2V0cy4KClRoZSBhdG9taWMgcGF0aDoKLSBEb2VzIGEgc2luZ2xlIGF0b21p YyBjb21taXQsIHdpdGggYWxsIGNoYW5nZWQgcHJvcGVydGllcyBhbmQgdGhlaXIgbmV3IHZhbHVl cy4gQWxsIG9mIHRoZSBhYm92ZSBhbmQgbW9yZSAoaW4vb3V0IGZlbmNlIGhhbmRsaW5nKS4uCgpF dmVuIGlmIGl0J3Mgc3RyaWN0bHkgc3BlYWtpbmcgYW4gYXRvbWljIHByb3BlcnR5LCB0aGUgZmFj dCB3ZSBjbGVhciBpdCBpbiBpZ3RfcGlwZV9yZWZyZXNoKCkKbWVhbnMgd2UgaGF2ZSB0byBtYWtl IHN1cmUgdGhhdCB0ZXN0cyBrZWVwIHJ1bm5pbmcsIGFuZCB3ZSBoYXZlIHRvIGNsZWFyIHRoZSBm bGFnIGluIGlndF9kaXNwbGF5X2NvbW1pdCgpCmJlY2F1c2Ugb3RoZXJ3aXNlIGV2ZW4gbW9yZSB0 aGluZ3MgYnJlYWsuIDopCgpQcm9iYWJseSBiZXN0IHRvIG9ubHkga2VlcCB0aGluZ3Mgd2UgYWJz b2x1dGVseSBjYW4ndCByZWFzb25hYmx5IGFub3RoZXIgd2F5IHRoYW4gYXRvbWljIGluIGlzX2F0 b21pYy4KCj4gLi4uCj4KPiBObywgdGhhdCdzIG5vdCBhICJpcyB0aGlzIGFuIGF0b21pYy1vbmx5 IHByb3BlcnR5IiwgaXMgaXQ/Cj4KPgo+IEFueXdheSwgdGhlIGVmZmVjdCBtYXRjaGVzIHRoZSBz ZWNvbmQgY2h1bmsgb2YgTmljaG9sYXMncyBwYXRjaC4KPgo+Cj4gUmV2aWV3ZWQtYnk6IFBldHJp IExhdHZhbGEgPHBldHJpLmxhdHZhbGFAaW50ZWwuY29tPgo+Cj4gVGhlcmUncyBzb21lIHF1ZXVl IGluIHNoYXJkcyBzbyBzdGFuZCBieSBhIGNvdXBsZSBvZiBob3VycyBmb3IgdGhlaXIgcmVzdWx0 cyBiZWZvcmUgbWVyZ2luZy4KPgo+Cj4KPj4gIAo+PiAgCQkJaWYgKHMgIT0gQ09NTUlUX1VOSVZF UlNBTCkgewo+PiAgCQkJCWlndF9waXBlX29ial9jbGVhcl9wcm9wX2NoYW5nZWQocGlwZV9vYmos IElHVF9DUlRDX01PREVfSUQpOwo+PiAtLSAKPj4gMi4yMC4xCj4+Cj4+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGlndC1kZXYgbWFpbGluZyBsaXN0 Cj4+IGlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaWd0LWRldgo=